Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 18:49:20 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Min Li <min.li.xe@renesas.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time
 correction
Message-ID: <YUi7kMkUI/69wHD/@lunn.ch>
References: <1631889589-26941-1-git-send-email-min.li.xe@renesas.com>
 <1631889589-26941-2-git-send-email-min.li.xe@renesas.com>
 <20210917125401.6e22ae13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <OS3PR01MB65936ADCEF63D966B44C5FEFBADD9@OS3PR01MB6593.jpnprd01.prod.outlook.com>
 <20210917140631.696aadc9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <OS3PR01MB65936F7C178EC44467285F2BBAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OS3PR01MB65936F7C178EC44467285F2BBAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com>
Precedence: bulk

On Mon, Sep 20, 2021 at 03:13:14PM +0000, Min Li wrote:
> > 
> >   > On Fri, Jun 25, 2021 at 02:24:24PM +0000, Min Li wrote:
> >   > > How would you suggest to implement the change that make the new
> > driver behavior optional?
> >   > I would say, module parameter or debugfs knob.
> > 
> > Aright, in which case devlink or debugfs, please.
> > 
> Hi Jakub
> 
> The target platform BSP is little old and doesn't support devlink_params_register yet.
> 
> And our design doesn't allow debugfs to be used in released software.

That does not matter. You are not submitting code to your BSP, you are
submitting to mainline. Please use the features mainline provides.

	   Andrew