Received: by 2002:a05:6520:4d:b0:139:a872:a4c9 with SMTP id i13csp2565856lkm; Mon, 20 Sep 2021 18:52:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv3Ftk5wiZfzYqgYZcEdv9EWgbwVL/BiTCm9Rl0U8CcBdWBvEOc4P8nHiQ1uNQK2/jfpFB X-Received: by 2002:a92:c26f:: with SMTP id h15mr19180725ild.271.1632189030037; Mon, 20 Sep 2021 18:50:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632189030; cv=none; d=google.com; s=arc-20160816; b=WSHPtNI2nLTxRbkQd1ylCVpm66OCEpPr7SR8+ushdpTAqHKGf2pCyco8tn3b/GKRH+ bd6KIP7QtgOLAmpJqsc4wno6/EnOgvrFoEJOcPL5JxJ02O9pIckUnDyR94l97GyAA+Lk 0GLbKEXi1Bpogtrxm8EskqY/40tL00r7e7yKf3SUSrazO5XL8ReUKypAoky9JwFz0oXf 11lxVUDEyj/LsHjJeQ3ng3Bb/gl6gZv8196l74eS6g44cAKu3/+Kuqr3IoQ2FRGxRuDu zGdsgaXjaND286AzrzEMN7gX50h+hsh6HMCcNqGnfNfkyT5hVFs2mAbPH/riIH/KkPLe Z+3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ABWiwVtgJu7HnxrT9eDPFxa7E9jy0dVpmpda9EiyQH8=; b=oKxMlPx60XBaKbjJeRyfYItlioGZqbhU2TdIiP+uHiVV3qXJCAO/wo1TMF85eN0mos rWiA5wyTrHXCzGGEJq7kwWPuELctHfiR2WlXWnGrbTNVvvZVtiJFOrhC+1lcT5jGy0PW Ey7f3z9jhPZMEGGcRnmYKmVAwO+YDy1NEWPRqxPiULh1uEEjoz3acrlAP5xROzfUxwXd et6JR6k/Ch+Z+xcpHa8tyyANPJP0iBbsCwe5YkhnRuM8dP5f8mU5RDEk7+O/hltzHmMh r5PnVqABbLFPc5RfpAoIOwl1QPZ7dJKGWIWnsUqQK3osC3y60C28ujSp7yw+WOKuGfO2 l44A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qlgcKDyQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b8si13750556ilm.108.2021.09.20.18.50.18; Mon, 20 Sep 2021 18:50:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qlgcKDyQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358298AbhITSGN (ORCPT + 99 others); Mon, 20 Sep 2021 14:06:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:58286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350727AbhITSAn (ORCPT ); Mon, 20 Sep 2021 14:00:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3DE263227; Mon, 20 Sep 2021 17:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632158154; bh=nZa1LrpL0x/o1GYvWiwkzvbZzI6NCmZVHmx29e7yE/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlgcKDyQM2pH/MgShaJEqBfMnOn+9l+0LOamj2ZcJeB8U3GYItOPVTe6mR0jsvNKb KvrEutDniIyBjp6CgHKfQrEAESCGfAfMOud6QTPL+EK4A5McmyP96guL/YgIG4hUCH mB9GSS7kwuYDejQ5jktNyEP6hIfjIl4XmR+pCu68= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robin Gong , Vinod Koul , Richard Leitner , Shawn Guo Subject: [PATCH 5.4 026/260] dmaengine: imx-sdma: remove duplicated sdma_load_context Date: Mon, 20 Sep 2021 18:40:44 +0200 Message-Id: <20210920163932.014958342@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210920163931.123590023@linuxfoundation.org> References: <20210920163931.123590023@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robin Gong commit e555a03b112838883fdd8185d613c35d043732f2 upstream. Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Vinod Koul Tested-by: Richard Leitner Signed-off-by: Shawn Guo Signed-off-by: Greg Kroah-Hartman --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1134,7 +1134,6 @@ static void sdma_set_watermarklevel_for_ static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1174,9 +1173,7 @@ static int sdma_config_channel(struct dm sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac,