Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932689AbWLNMev (ORCPT ); Thu, 14 Dec 2006 07:34:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932697AbWLNMev (ORCPT ); Thu, 14 Dec 2006 07:34:51 -0500 Received: from ug-out-1314.google.com ([66.249.92.168]:55767 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932689AbWLNMeu (ORCPT ); Thu, 14 Dec 2006 07:34:50 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=QKLYtl2Ly0pCvD8j7kfDYXUkC+t9aPMKqS5klVrCq6g5cWuSDYh1wCPbQfR7XuiY0GSsy33ntBqqoVVwuARwtGXktNmRtlsKFthVupcaaL5TKuHGET0tRtsPUysZ2SMxFSBFi4Nc0RWr8XItShyT4FlPgXI64uAA4zUiF8IM+0k= Message-ID: <5b8e20700612140434v740574cdkfcfbe984fbf763fc@mail.gmail.com> Date: Thu, 14 Dec 2006 07:34:48 -0500 From: "Michael Bommarito" To: ray-gmail@madrabbit.org Subject: Re: [PATCH 2.6.19-git19] BUG due to bad argument to ieee80211softmac_assoc_work Cc: "Mike Galbraith" , linux-kernel@vger.kernel.org In-Reply-To: <2c0942db0612132123o12d8d250rb9583a2dc1588993@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <5b8e20700612131017n1cd8aff3qbe41351435427e25@mail.gmail.com> <1166070494.5853.0.camel@Homer.simpson.net> <5b8e20700612132035w2ad90000wcaca60be5d93277d@mail.gmail.com> <2c0942db0612132123o12d8d250rb9583a2dc1588993@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2265 Lines: 56 Ah, apologies, it's exam time and I probably didn't look hard enough on the mailing list before posting. For the record though, I'd posted the bug (no patch) to bugzilla on the 9th (although it looks as if the email address it was assigned to is actually defunct - anyone know why bugzilla is still using networking_wireless@kernel-bugs.osdl.org ?) Anyway, again, sorry for the duplicate! -Mike On 12/14/06, Ray Lee wrote: > On 12/13/06, Michael Bommarito wrote: > > Sorry, realized I might not have been clear as to what I meant! The > > patch was attached to the bugzilla entry, but I'll attach it here as > > well. My description of the patch itself was really as complicated as > > it gets too (just two lines, switch (void*)mac to > > &mac->assoc.work.work in > > net/ieee80211/softmac/ieee80211softmac_assoc.c), just a small bug > > while somebody was rushing through the work/delayed_work changes. > > --- net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13 > 11:23:03.000000000 -0500 > +++ net/ieee80211/softmac/ieee80211softmac_assoc.c 2006-12-13 > 11:24:26.000000000 -0500 > @@ -167,7 +167,7 @@ > ieee80211softmac_assoc_notify_scan(struct net_device *dev, int > event_type, void *context) > { > struct ieee80211softmac_device *mac = ieee80211_priv(dev); > - ieee80211softmac_assoc_work((void*)mac); > + ieee80211softmac_assoc_work(&mac->associnfo.work.work); > } > > static void > @@ -177,7 +177,7 @@ > > switch (event_type) { > case IEEE80211SOFTMAC_EVENT_AUTHENTICATED: > - ieee80211softmac_assoc_work((void*)mac); > + ieee80211softmac_assoc_work(&mac->associnfo.work.work); > break; > case IEEE80211SOFTMAC_EVENT_AUTH_FAILED: > case IEEE80211SOFTMAC_EVENT_AUTH_TIMEOUT: > > Good catch, though it was already caught. See: > > http://lkml.org/lkml/2006/12/12/46 > > ...for (basically) the same patch. > > But again, good catch :-). > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/