Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2350192pxb; Mon, 20 Sep 2021 19:44:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/V0ovbqnAGUZwYuqgjdLUxVUrNF9x2FZnWQrqrk2Vcpbqo9bNcMmeIc9nh6qYoNBiJV/L X-Received: by 2002:a92:d2c7:: with SMTP id w7mr19473926ilg.71.1632192298773; Mon, 20 Sep 2021 19:44:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632192298; cv=none; d=google.com; s=arc-20160816; b=xX065bm9Sqpf0JVbBcNX6Y/uCKXg0Mg/VCKQV5kfQ+u0xULedBygtuAYirqAiyd6SW g7mOuUbvRHYRy79zlxqMhN5SNLuzOGc0cxiSLjfJz3E774G0bEZHTw4qgzTa4zH4FwmW +OT77Pp7/zKSksTF4U0/Qr3fGn2pfemcpSvqj9eRxYJRuITiT7F9l7ULcxVPAWJ4aJri cb3z7PayvjWVEAOXSWiaVrDi+IIFtWDWhwF92jj/9QHUg8Kb8xLVLAkLEL4qYSq3qZK0 PDuWq4WsT9qkiBPg58m/zTcF4Yw0PyLPBbpwrbh/1PMrYRItK3w8Nw2dgDYm3Xb4xv8O iI8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hg+9v0Gecey1mUzEkR94E/VRosmoDLiqb8k6ggprXrw=; b=OP2NE+l7qwrIHUmNCi0w5u9utFsNJAWUsceVHLJFZZA4zGa+BSuZUpyMME7ycc8Ejh Ha+2ybRivI2AR3Tu/8sm/oOODF9ugFt0tSFla2wBnWSAnLcW/5//EL4TJ9eOvvA5/3m4 sG3K8M4OYCDpX4K8+aXoUIlhg1x8tvfKYVyCSz0pLXT6V5uneQ4hLegkMO1oWsigbqah AkvFo3sRJaNi9d9a+SxM51iToKbfaymO1CyGTwK7bV+edMwFXgF3Ph4vLlMH+RMZR6UH z6YJNOmb5DChZWkPKCuAWJChCPCowOT1U9v/PyQK6vetJIFGeZCL/611Ww2R3WFG00pG m+Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HRKGqy7Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si12978497jat.15.2021.09.20.19.44.47; Mon, 20 Sep 2021 19:44:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HRKGqy7Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378327AbhITSYY (ORCPT + 99 others); Mon, 20 Sep 2021 14:24:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:40988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358712AbhITSQ5 (ORCPT ); Mon, 20 Sep 2021 14:16:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B3F1A6329A; Mon, 20 Sep 2021 17:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632158547; bh=6MefaOf4cg6HZEJQSL27gcWoBuJDG1ar9t4LMs4Akfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HRKGqy7Y37p9lF8o+35Z1sOtLeSyDUPE2sH4aC2+2s0eK2SXZefH7mUJV2HphDewZ fa3AaSPP7+HfAF6f9zIAgjD5xbRRfr9IiiYXJNfF/ennKQnD4xP1FlBG0cJQMXAG78 Fy1MN5mrwJnuddVdee+GLi1usyEv3GPF0KUI0n4U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lucas Stach , Michael Walle , Marek Vasut , Christian Gmeiner Subject: [PATCH 5.4 206/260] drm/etnaviv: add missing MMU context put when reaping MMU mapping Date: Mon, 20 Sep 2021 18:43:44 +0200 Message-Id: <20210920163938.109342919@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210920163931.123590023@linuxfoundation.org> References: <20210920163931.123590023@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lucas Stach commit f2faea8b64125852fa9acc6771c07fc0311a039b upstream. When we forcefully evict a mapping from the the address space and thus the MMU context, the MMU context is leaked, as the mapping no longer points to it, so it doesn't get freed when the GEM object is destroyed. Add the mssing context put to fix the leak. Cc: stable@vger.kernel.org # 5.4 Signed-off-by: Lucas Stach Tested-by: Michael Walle Tested-by: Marek Vasut Reviewed-by: Christian Gmeiner Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c @@ -204,6 +204,7 @@ static int etnaviv_iommu_find_iova(struc */ list_for_each_entry_safe(m, n, &list, scan_node) { etnaviv_iommu_remove_mapping(context, m); + etnaviv_iommu_context_put(m->context); m->context = NULL; list_del_init(&m->mmu_node); list_del_init(&m->scan_node);