Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: wcheng=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 835BAC43460
Subject: Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with
 v5.15-rc1
To:     Amit Pundir <amit.pundir@linaro.org>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jack Pham <jackp@codeaurora.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        John Stultz <john.stultz@linaro.org>,
        linux-usb@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dt <devicetree@vger.kernel.org>
References: <CAMi1Hd3k2snB4-=M57pVrMVom=a9_2a0DTFk-+Hzpubwk-Pr9Q@mail.gmail.com>
From:   Wesley Cheng <wcheng@codeaurora.org>
Message-ID: <64a2a428-8bb1-0078-2403-1ca8e28cf4b1@codeaurora.org>
Date:   Mon, 20 Sep 2021 14:13:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAMi1Hd3k2snB4-=M57pVrMVom=a9_2a0DTFk-+Hzpubwk-Pr9Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Amit,

On 9/20/2021 1:45 PM, Amit Pundir wrote:
> Hi Wesley, All,
> 
> I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO
> resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045
> "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to
> be specific, which switched on this feature by default.
> 
> At times the phone crashes into the fastboot mode after the reboot
> loop, but mostly end up booting to UI after a while. This is what it
> looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4.
> 

I believe Android will attempt a number of bootup sequences and if it
fails, it falls back to fastboot mode.  Are there any available logs you
might be able to collect to see where the issue is?

> PocoF1 does support TX fifo resizing as I can see that in the
> downstream dts. So maybe it is the tx-fifo-max-num which need to be
> adjusted for the device? I couldn't find the tx-fifo-max-num
> equivalent in the downstream tree though
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/
> 

I assume that you've already confirmed reverting that change resolves
the constant reboots?

> Curious if you had any ideas what might be going wrong? For now I'll
> keep digging around tx-fifo-max-num, but I figured I'd ask just in
> case it's obvious to you.
> 

The tx-fifo-max-num parameter should still be set to 6 for SDM845, which
would be the same for more recent targets as well.

Thanks
Wesley Cheng

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project