Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Weinberger <richard@nod.at>
To:     masahiroy@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        Richard Weinberger <richard@nod.at>
Subject: [PATCH 2/2] kconfig: Deny command substitution in string values
Date:   Mon, 20 Sep 2021 23:39:57 +0200
Message-Id: <20210920213957.1064-2-richard@nod.at>
In-Reply-To: <20210920213957.1064-1-richard@nod.at>
References: <20210920213957.1064-1-richard@nod.at>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

The post processed .config file will get included in shell
and makefiles. So make sure that a string does not contain
symbols that allow command substitution.
If such a malformed string is found, return empty string
and report it.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 scripts/kconfig/symbol.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 4a31bb943f79..1035ecdddc99 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -880,6 +880,11 @@ const char *sym_escape_string(struct symbol *sym)
=20
 	in =3D sym_get_string_value(sym);
=20
+	if (strspn(in, "`$")) {
+		fprintf(stderr, "%s: invalid characters in string found\n", sym->name)=
;
+		return xstrdup("\"\"");
+	}
+
 	reslen =3D strlen(in) + strlen("\"\"") + 1;
=20
 	p =3D in;
--=20
2.26.2