Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2378803pxb; Mon, 20 Sep 2021 20:45:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfmbo0dMWsJGtkMfmRLOgDY0wWWBmjcseFNxr9zb4zJluFk/x41aavVv25IVsRR+L57NrL X-Received: by 2002:a17:906:4ad1:: with SMTP id u17mr20916964ejt.407.1632195919240; Mon, 20 Sep 2021 20:45:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632195919; cv=none; d=google.com; s=arc-20160816; b=JZR9XIGmbI3JJ3f1NCDCRQpC3AALTXSuWC5zCJjksnZQZuqwz+vvkYH+N4dgkBk9C5 J1MXsmfi8sRkhxzb2fqPqhUZ7M/wK6ew349q6VNB/oYS3hcdJyeEu4be/IivxfoCH+LE LfyEgjLuz0559bFglUWil1ouyTaQQ0rByQzQxtfWVXJ9TZ9iuld2zoxdmcyFqOLQVA0k sN/S3tt6yaRNlb9C8QcvdydPZK5++A2frkAibVrR16rJd8MPAXJRus9hHYuWO94Sj2Dn ETDHsigguT299h050bgqfqscKmcIrPRT3orHHrBm7Us98GwDq1LaTRZ3WzfIuELFmVuP RL4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=p+xWJ0YkatGIKOHgIGcojVmd5miNxn0VeGIwFFaZE0g=; b=eF2ng3/W11v2cQX+myxBplVbq6l7Vclq0QXBc6yGv2M85X4dqpGRJyslPtn5BG0DS2 0MZBQXZCDoJO4UIiIOZmdsYUFREHH/mMBwX9uCQev+xpAQjMoc8OKRB/2ZxrHN7nEY94 dNQDJICoZGRrKnhmnHOnkDym9+6QW0OdkxTQ53SFn1CYy1DrjGCrMR3R09xASRO5q/zL E5XpLG3yBu/3RKhUtsl1+0wI2rb0vl6luUf6vToAubXAxtkZua09ljeaOaWF7jmfs7Ze rGe8UrHiilCnKh2+2NXFQvcV2BhRlyjGsTvEuXmtcTlLTRjprlSIoP0J1E7e1pduxROk XGgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NIWYSMW7; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4cGiKRfw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hz24si18360144ejc.119.2021.09.20.20.44.55; Mon, 20 Sep 2021 20:45:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NIWYSMW7; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=4cGiKRfw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239693AbhITXfG (ORCPT + 99 others); Mon, 20 Sep 2021 19:35:06 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:45376 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238939AbhITXdG (ORCPT ); Mon, 20 Sep 2021 19:33:06 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACD2E2209E; Mon, 20 Sep 2021 23:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632180697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+xWJ0YkatGIKOHgIGcojVmd5miNxn0VeGIwFFaZE0g=; b=NIWYSMW7/xcDx9iujTBP2ZVH/ylAswRbkhrJNa8S6dq0m0/Hk6cwP0EwSbMYWJuwHLP4tR G16gMLywCWg9GxCUeEflCtWs8uiA7TmRRJj9RrU5OVxyQ3zdc2bK2lBBRGok0RBfHPXPje SbwcGzL5TN+fQks5SFlkTWZtQK+KCLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632180697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+xWJ0YkatGIKOHgIGcojVmd5miNxn0VeGIwFFaZE0g=; b=4cGiKRfw6Tdv5gQ50a591jAd2tWJ2v5dWHV/wjFpwW93rfTOpjhhaklqRASgPIhRywUWOl hR4tNr8Pv290q7Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C640613B2E; Mon, 20 Sep 2021 23:31:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4IkQIdUZSWGjaQAAMHmgww (envelope-from ); Mon, 20 Sep 2021 23:31:33 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Mel Gorman" Cc: "Linux-MM" , "Theodore Ts'o" , "Andreas Dilger" , "Darrick J . Wong" , "Matthew Wilcox" , "Michal Hocko" , "Dave Chinner" , "Rik van Riel" , "Vlastimil Babka" , "Johannes Weiner" , "Jonathan Corbet" , "Linux-fsdevel" , "LKML" , "Mel Gorman" Subject: Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made In-reply-to: <20210920085436.20939-4-mgorman@techsingularity.net> References: <20210920085436.20939-1-mgorman@techsingularity.net>, <20210920085436.20939-4-mgorman@techsingularity.net> Date: Tue, 21 Sep 2021 09:31:30 +1000 Message-id: <163218069080.3992.14261132300912173043@noble.neil.brown.name> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Sep 2021, Mel Gorman wrote: > + > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS, HZ/10); We always seem to pass "HZ/10" to reclaim_throttle(). Should we just hard-code that in the one place inside reclaim_throttle() itself? NeilBrown