Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2379121pxb; Mon, 20 Sep 2021 20:45:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRWUGACB7cYGeFKN+/ZAXvFfspYGufTBkQPEq7f/5ot2T1Qp9WBDZAHcDlwAGL+8v5VUSU X-Received: by 2002:a17:906:32cf:: with SMTP id k15mr32735421ejk.68.1632195956050; Mon, 20 Sep 2021 20:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632195956; cv=none; d=google.com; s=arc-20160816; b=XCdrjcXe7/qyBB27FIa5fuv2nTbHd82JIxQbvIrAFH/GxPceuZxB2MauJT+/HFq4+X GOq+FF8G3n+21a7CUXGqgT3tfLiFUzmH+UlCua8ZjllTbXjaxdZOB2P7pw7Mk233fcff x3z7vDGW6GKHWH2iEWD1wT5lSksApAw2atSAQvi4sPPJjFqek8rtjjXT09RCaGcrr5az qtZDYjJrbjtJru8yDDznOanSHR+RDwofKo8uCA1Wy+hKm/U6IVVVrstV3LN1k40ywf+e FdbThOBvOJdWfMQTxZm47qkloNNlxnTSLIcTvf9vS1Drt8UKVRi270d2LaI7aITNMDOS Xi/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:references:in-reply-to:subject :cc:to:from:mime-version:content-transfer-encoding:dkim-signature :dkim-signature; bh=/C6da5eeUa7YP9LdZVBTb91w0ysI+DwHwEBCgSWwGeo=; b=ylH7YrxgDFQg5+tHpGTBM8aPMwWXImrdMmPCoX7z8zJQmSR3ks6VWN1PM3pNCAR9yN VlE9Ja2N7ELzMN2yrY7pZ+PFr/30Mho5nnCoSZCezImcTMU6VV00DWldp5TxRsL5JzS3 2mkPV6IB6ETMYlKUyy8mR2ADiRC4t6kxXfv5og35fMwE3Mb39soFfaPXLTzAro6iVdh0 Kpa//xwfEmvHwz++5TVBv/FfxnSBhWB2QmrVckggMP3kV1w7RAlMqAglmf+VBNEB5Gxz xcfdndGTDah6sXB2FaS3PUvzII9UfS9gjaTueWfIlVFh0u8czTEFo9lZgAUOhv+kLUqY 4nzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zSrUNUVF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=QZHlnr+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd7si16760853ejc.41.2021.09.20.20.45.32; Mon, 20 Sep 2021 20:45:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zSrUNUVF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=QZHlnr+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232852AbhITXbc (ORCPT + 99 others); Mon, 20 Sep 2021 19:31:32 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:37828 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbhITX3b (ORCPT ); Mon, 20 Sep 2021 19:29:31 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 349961FE8A; Mon, 20 Sep 2021 23:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632180483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/C6da5eeUa7YP9LdZVBTb91w0ysI+DwHwEBCgSWwGeo=; b=zSrUNUVFh2Z82i65SHp6/Tr/GGuMWAWfv+emDJ6RNohece0x+m4QE3BBQjaVqhMeefxG3x 7z3i2SsuGYmhneWI/W6pyYTZtblb8Fhmaehkr3T+aHa5QIZyUGTRzgiQOMcrQSrhgutude iuwYti/nOPu2k48JIl6AIXVtwAmVX34= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632180483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/C6da5eeUa7YP9LdZVBTb91w0ysI+DwHwEBCgSWwGeo=; b=QZHlnr+c9Ur+GAXN3V+zMCNqnBkOLw3ACTa0Mz311Jau3aKxgdTwAAtuwc68ZMKsaFOBTJ ZBuAdQCWRRwIc4Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4795A13B38; Mon, 20 Sep 2021 23:27:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TDWWAf8YSWFiaAAAMHmgww (envelope-from ); Mon, 20 Sep 2021 23:27:59 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: "NeilBrown" To: "Mel Gorman" Cc: "Linux-MM" , "Theodore Ts'o" , "Andreas Dilger" , "Darrick J . Wong" , "Matthew Wilcox" , "Michal Hocko" , "Dave Chinner" , "Rik van Riel" , "Vlastimil Babka" , "Johannes Weiner" , "Jonathan Corbet" , "Linux-fsdevel" , "LKML" , "Mel Gorman" Subject: Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated In-reply-to: <20210920085436.20939-3-mgorman@techsingularity.net> References: <20210920085436.20939-1-mgorman@techsingularity.net>, <20210920085436.20939-3-mgorman@techsingularity.net> Date: Tue, 21 Sep 2021 09:27:56 +1000 Message-id: <163218047640.3992.16597395100064789255@noble.neil.brown.name> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Sep 2021, Mel Gorman wrote: > @@ -2291,8 +2302,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct= lruvec *lruvec, > return 0; > =20 > /* wait a bit for the reclaimer. */ > - msleep(100); > - stalled =3D true; > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_ISOLATED, HZ/10); Why drop the assignment to "stalled"? Doing that changes the character of the loop - and makes the 'stalled' variable always 'false'. NeilBrown