Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210919211129.4364-1-linux.amoon@gmail.com> <7dcee097-9119-1987-9bb5-777d541cc9f7@baylibre.com>
In-Reply-To: <7dcee097-9119-1987-9bb5-777d541cc9f7@baylibre.com>
From:   Anand Moon <linux.amoon@gmail.com>
Date:   Mon, 20 Sep 2021 23:35:18 +0530
Message-ID: <CANAwSgRtChYZWogwSVggqT1491oWx-eAf8d95dGvPkLy3=1DwQ@mail.gmail.com>
Subject: Re: [PATCH] regulator: pwm-regulator: Make use of the helper function dev_err_probe()
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic@lists.infradead.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jon Hunter <jonathanh@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Neil,

On Mon, 20 Sept 2021 at 13:56, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 19/09/2021 23:11, Anand Moon wrote:
> > devm_regulator_register can return -EPROBE_DEFER if the
> > regulator is not ready yet. Use dev_err_probe() for
> > pwm regulator resources to indicate the deferral reason
> > when waiting for the resource to come up.
> >
> > Fixes: 0cd71b9a43ad ("regulator: pwm: Don't warn on probe deferral")
> >
> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  drivers/regulator/pwm-regulator.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
> > index 7629476d94ae..451e57a739f8 100644
> > --- a/drivers/regulator/pwm-regulator.c
> > +++ b/drivers/regulator/pwm-regulator.c
> > @@ -382,9 +382,9 @@ static int pwm_regulator_probe(struct platform_device *pdev)
> >                                           &drvdata->desc, &config);
> >       if (IS_ERR(regulator)) {
> >               ret = PTR_ERR(regulator);
> > -             dev_err(&pdev->dev, "Failed to register regulator %s: %d\n",
> > -                     drvdata->desc.name, ret);
> > -             return ret;
> > +             return dev_err_probe(&pdev->dev, ret,
> > +                                  "Failed to register regulator %s: %d\n",
> > +                                  drvdata->desc.name, ret);
>
> No need to keep ret and print it since it will be printed by dev_err_probe, pass directly PTR_ERR(regulator) and drop the ": %d" from the error string.
>
> Neil
>

Thanks for the input but it's a wrong fix I meant to fix another probe
defer with *devm_pwm_get*
I will correct this in the next version..

Thanks
-Anand

>
> >       }
> >
> >       return 0;
> >
>