Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: subbaram=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org EED12C4338F
Subject: Re: [PATCH] spmi: pmic-arb: Add sid and address to error messages
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Stephen Boyd <sboyd@kernel.org>, linux-kernel@vger.kernel.org,
        satya priya <skakit@codeaurora.org>,
        David Collins <quic_collinsd@quicinc.com>
References: <20210920234849.3614036-1-swboyd@chromium.org>
From:   Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Message-ID: <f03e37bd-0639-9548-fced-a4cb1c1a202f@codeaurora.org>
Date:   Mon, 20 Sep 2021 18:45:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210920234849.3614036-1-swboyd@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 9/20/21 4:48 PM, Stephen Boyd wrote:
> It's useful to know what particular device/component is having trouble
> accessing the bus. Add the sid and address to error messages here so
> that debugging is a little simpler.
>
> Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> Cc: satya priya <skakit@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>

> ---
>  drivers/spmi/spmi-pmic-arb.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index bbbd311eda03..e397c2532c8d 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
>  
>  		if (status & PMIC_ARB_STATUS_DONE) {
>  			if (status & PMIC_ARB_STATUS_DENIED) {
> -				dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n",
> -					__func__, status);
> +				dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n",
> +					__func__, sid, addr, status);
>  				return -EPERM;
>  			}
>  
>  			if (status & PMIC_ARB_STATUS_FAILURE) {
> -				dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n",
> -					__func__, status);
> +				dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n",
> +					__func__, sid, addr, status);
> +				WARN_ON(1);
>  				return -EIO;
>  			}
>  
>  			if (status & PMIC_ARB_STATUS_DROPPED) {
> -				dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n",
> -					__func__, status);
> +				dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n",
> +					__func__, sid, addr, status);
>  				return -EIO;
>  			}
>  
> @@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
>  		udelay(1);
>  	}
>  
> -	dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n",
> -		__func__, status);
> +	dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n",
> +		__func__, sid, addr, status);
>  	return -ETIMEDOUT;
>  }
>  


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project