Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210918102058.v5.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid>
 <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid> <YUZMNIYbT7KL3qJR@ravnborg.org>
In-Reply-To: <YUZMNIYbT7KL3qJR@ravnborg.org>
From:   Philip Chen <philipchen@chromium.org>
Date:   Mon, 20 Sep 2021 14:37:53 -0700
Message-ID: <CA+cxXh=OixYPzE_ui=22seumFpKigTcK3hvNtrfN4oa0SFdtOw@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sam,

On Sat, Sep 18, 2021 at 1:29 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Philip,
> On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote:
> > Implement the first version of AUX support, which will be useful as
> > we expand the driver to support varied use cases.
> >
> > Signed-off-by: Philip Chen <philipchen@chromium.org>
>
> Patch is:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> please consider a few follow-up patches:
> 1) Replace deprecated drm_bridge_funcs with the _atomic_ variants.
> 2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic
>    variant.
> 3) Use pr_() and dev_() logging in favour of DRM_ logging.
>    DRM_ logging is deprecated these days and do not belong in bridge
>    drivers anyway.
>
> Maxime has a few patches pending for this driver - it would be great if
> you could look them up and review them.
> Maybe you can get some review in feedback.

Yes, I'll do.
Thanks for reviewing.

>
>         Sam
>