Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   Steve French <smfrench@gmail.com>
Date:   Mon, 20 Sep 2021 19:43:45 -0500
Message-ID: <CAH2r5mv84yZk=FEmSZwNRNXncPs22Fgf6zKLBozgWXbMSJkGMA@mail.gmail.com>
Subject: [PATCH][ksmbd] log that module is experimental at load time
To:     CIFS <linux-cifs@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        ronnie sahlberg <ronniesahlberg@gmail.com>,
        Namjae Jeon <linkinjeon@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

    While we are working through detailed security reviews
    of ksmbd server code we should remind users that it is an
    experimental module by adding a warning when the module
    loads.  Currently the module shows as experimental
    in Kconfig and is disabled by default, but we don't want
    to confuse users.

    Although ksmbd passes a wide variety of the
    important functional tests (since initial focus had
    been largely on functional testing such as smbtorture,
    xfstests etc.), and ksmbd has added key security
    features (e.g. GCM256 encryption, Kerberos support),
    there are ongoing detailed reviews of the code base
    for path processing and network buffer decoding, and
    this patch reminds users that the module should be
    considered "experimental."

    Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
    Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
index e6a9f6aa47eb..2a2b2135bfde 100644
--- a/fs/ksmbd/server.c
+++ b/fs/ksmbd/server.c
@@ -584,6 +584,9 @@ static int __init ksmbd_server_init(void)
        ret = ksmbd_workqueue_init();
        if (ret)
                goto err_crypto_destroy;
+
+       pr_warn_once("The ksmbd server is experimental, use at your
own risk.\n");
+
        return 0;

 err_crypto_destroy:

-- 
Thanks,

Steve