Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Sep 2021 09:17:27 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     linux-kernel@vger.kernel.org
Cc:     linux-tip-commits@vger.kernel.org,
        Yafang Shao <laoar.shao@gmail.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Mel Gorman <mgorman@suse.de>, x86@kernel.org
Subject: Re: [tip: sched/core] sched: Make struct sched_statistics
 independent of fair sched class
Message-ID: <20210921061727.GA24828@kili>
References: <20210905143547.4668-3-laoar.shao@gmail.com>
 <163179357090.25758.13267982301302997472.tip-bot2@tip-bot2>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <163179357090.25758.13267982301302997472.tip-bot2@tip-bot2>
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FX47fAI37MDuN/rWMWGempkhr1w9zEjq3PfkQ0rdbZWFpZd3s1CEbNKXLsC4?=
 =?us-ascii?Q?4HHyI9wdckkpwJ5B25cs+V5B6nWPF1RaHGdl9KGjxeZ8BX/d5kdZe/B9ePFE?=
 =?us-ascii?Q?+WL4eeW6524sClW3kmk0Y7mk6MbJU+J1Q5SbyP8J9HVr0A1Fyk2/Q2K82j49?=
 =?us-ascii?Q?YI0ByRCP3Lnl081O9UnAGQ/BtxMVVdpiUtp0+lqjR2jI8Z46Ly+rs6GUnGW2?=
 =?us-ascii?Q?acOPULFGFWo6ITMVpJJKh7w+e/3dXUIQMJD6S2/DWQM+5UQjGgX2gEICfQMB?=
 =?us-ascii?Q?8zkWHw82RWYhSEClaDl/R14S5oNWIgmbspngw7fB51JHtiLv+i+ksXKe4sTV?=
 =?us-ascii?Q?8QcxC7fto0zRi+4UmMAL21f31ZwQfSN+A4ouQO39KoLYq9sXTed/lbRmAJ2f?=
 =?us-ascii?Q?i7ZHLFlntHacHljeb4PO/Cgt9oet9BYyBBLBozPCeq6QbT8ELON38oLSqBcf?=
 =?us-ascii?Q?GHC8kz6IrbJvcc6lxLANruvTXxkJQ6vZjwtaQ3kkrdKzUIcqQzKzI+04CLUu?=
 =?us-ascii?Q?x+ITOcNvbZ3X7cSdjShPuvBIL72kWCn14uayFHvhYodyjWphGBELFNzqZ2pg?=
 =?us-ascii?Q?F5kmOCHBz8iKDAdjUyMN3amBaG/ITmtlxTCamHPVFGGxH89oG6UKkZHgmXta?=
 =?us-ascii?Q?CX4iQxzfRYbWWmCziCM6CMVqcOZ8OVMmj3ka71iMf95+OrrMn5C9in1CjzIy?=
 =?us-ascii?Q?gUHyhp+5V0VcJ4REDeVS6U5kaePUXa6J/7RrlLviNAjvRPyP19aO7iaoNysY?=
 =?us-ascii?Q?PPe42nuk4y2z4LtJDody7cCzfXXgq2P6LdhST4kmNeSnHa4Z5HY9MLAaspmB?=
 =?us-ascii?Q?4t5xTP6MvBsLVYESwiVMC2Klv40AxLcZb5xwnOluQxP96gmaCMYjHdVo4snl?=
 =?us-ascii?Q?ZA7+PgnEWJSuZjt2OdXruiyVB0cArLUsB+XBI3gGXpJZwissn8trpr+6oLDW?=
 =?us-ascii?Q?Irmw2NIVPb3wTLy3tf5wAYSj3q1lKlQ6fmCOL9SXiZrCQmbra9oodYYi275+?=
 =?us-ascii?Q?nx/96FQcJiWrudeA/fzIEzwo1kTG3Bj/8+6jnnotyay/E3WTbTuw6jMqrzGA?=
 =?us-ascii?Q?MF2Rxyv7oa/DPiYDFXd2uJE2MHhiu0cvnasX8gNsdHGuoZBfX+mtQ72u7uyx?=
 =?us-ascii?Q?kQZ9+Ltcd4Hs2CkqLBI/+mDF9fT4khfVb5t7bcp/lXCVKRoHjVBPECzDy0ve?=
 =?us-ascii?Q?TDkdtIjhGMlg8fOgqU2MiDlB9H2gDvmHIFCvcnXSImO+Yovf4rmA3+RywWN9?=
 =?us-ascii?Q?jVEjQCIEm6Df2rjXLM8osQOal8iLTn0liAUTLULa3Mr4yZYmuqjec06QyraO?=
 =?us-ascii?Q?0Twt2+sQeVk3iqWS+99zSo8x?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7295e442-3c57-4307-725f-08d97cc7830c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 06:17:39.0821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: grJyV6MA3PhcgM+jWR5LboE+VbUk1U8UKHAQ4cFmnpO4TpCm0J27eIO8XBboZqcEwnCI+tyjRComFBNHkcVI55EYRPQzoGFmE+yVKz40bzc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1727
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10113 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109210040
X-Proofpoint-GUID: MuRYNQgNUldcIbWY7gcsvaE8gXnZfEdc
X-Proofpoint-ORIG-GUID: MuRYNQgNUldcIbWY7gcsvaE8gXnZfEdc
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 16, 2021 at 11:59:30AM -0000, tip-bot2 for Yafang Shao wrote:
> @@ -11424,7 +11441,7 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
>  		if (!cfs_rq)
>  			goto err;
>  
> -		se = kzalloc_node(sizeof(struct sched_entity),
> +		se = kzalloc_node(sizeof(struct sched_entity_stats),

This wasn't there in the original patch and it causes a Smatch warning
because "se" is declared as a "sched_entity" but it's allocating a
larger "sched_entity_stats" which contains a sched_entity.

To me, ideally, we would update the type of se.

>  				  GFP_KERNEL, cpu_to_node(i));
>  		if (!se)
>  			goto err_free_rq;

regards,
dan carpenter