Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Sep 2021 09:17:07 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
        Yafang Shao <laoar.shao@gmail.com>,
        Mel Gorman <mgorman@suse.de>, x86@kernel.org
Subject: Re: [tip: sched/core] sched: Make struct sched_statistics
 independent of fair sched class
Message-ID: <YUmG8+96zgScrfqm@hirez.programming.kicks-ass.net>
References: <20210905143547.4668-3-laoar.shao@gmail.com>
 <163179357090.25758.13267982301302997472.tip-bot2@tip-bot2>
 <20210921061727.GA24828@kili>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210921061727.GA24828@kili>
Precedence: bulk

On Tue, Sep 21, 2021 at 09:17:27AM +0300, Dan Carpenter wrote:
> On Thu, Sep 16, 2021 at 11:59:30AM -0000, tip-bot2 for Yafang Shao wrote:
> > @@ -11424,7 +11441,7 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
> >  		if (!cfs_rq)
> >  			goto err;
> >  
> > -		se = kzalloc_node(sizeof(struct sched_entity),
> > +		se = kzalloc_node(sizeof(struct sched_entity_stats),
> 
> This wasn't there in the original patch and it causes a Smatch warning

What original patch? It's part of the v4 posting.

> because "se" is declared as a "sched_entity" but it's allocating a
> larger "sched_entity_stats" which contains a sched_entity.

Yep, on purpose.

> To me, ideally, we would update the type of se.

That's a lot of churn for very little gain. I can rewrite it like:

	struct sched_entity_stats *ses = kzalloc_node(sizeof(*ses),...);
	se = &ses->se;

If that makes smatch happy. It's the exact same thing tho because we
force ses->se to be at 0 offset.