Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Sep 2021 10:40:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
        Yafang Shao <laoar.shao@gmail.com>,
        Mel Gorman <mgorman@suse.de>, x86@kernel.org
Subject: Re: [tip: sched/core] sched: Make struct sched_statistics
 independent of fair sched class
Message-ID: <20210921074042.GU2116@kadam>
References: <20210905143547.4668-3-laoar.shao@gmail.com>
 <163179357090.25758.13267982301302997472.tip-bot2@tip-bot2>
 <20210921061727.GA24828@kili>
 <YUmG8+96zgScrfqm@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YUmG8+96zgScrfqm@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z2NNAr7x+0SmvkccWR2S9gCe76pERWcJJEVw7CR1asjFL/o6vhY+pmyidlGF?=
 =?us-ascii?Q?i9k6/lBUMP2hb3f8iQ0P/jzJ5aFBzgMEeLyIFa/jF9d8K8X75bJkjAHwMl/P?=
 =?us-ascii?Q?k0FlrgBBAFSWx4Es96IjO8x5AsdogLGL6WrmisUn4hYZGCJY8G6/ScEZUvhH?=
 =?us-ascii?Q?gNu5zqyxs0FvuNJ2vSCzF6fUo6Yyh6haPe+zD9X8oRdXUUJs9ok2hAcj5Vfh?=
 =?us-ascii?Q?zckAdmLMqYIYeUWSaRZhP/CA55EvBCGsuW31vdELVJqtTBWNPyCDCBOZi189?=
 =?us-ascii?Q?4rhetMOz1+yT+vUP6zA5HeampVs7wqzRd81EODYkfO1+H6elP9t1QZkWehUp?=
 =?us-ascii?Q?hSyQarg8F87YhtLgvd6Ayz9a1NvwvQ8KVmoFqkHcLFLH8dWg4SugQYqk1+GY?=
 =?us-ascii?Q?ynoD5Z7s4EbwEiv2hZKeM3rSHhETLjjHHDHMrQpBrbCg2HsAcTX8qlpXtDtq?=
 =?us-ascii?Q?HZjXR397Lvhq5tGnAI7DTr6Snk2o/LePICiFBuZCQ+5Ww86NW9Omv2jT7dim?=
 =?us-ascii?Q?kULgarXGQclSku2xsbVomigBZCdr8/5tJDuQ8RQXvYcLBCcDvpfA8sLUmbof?=
 =?us-ascii?Q?koGhzG1JoBJfJYv+exrsQelfB/zCxOSrF1U0J/+UkGZh6pjX2tq8wj5sQ1Xj?=
 =?us-ascii?Q?7WUvzVozB4qMWG3Q91wS+sL5NlWwWJ6XR6+RiVK94xXxAuZwlSTt7hP3BviO?=
 =?us-ascii?Q?mZscXsH4f8A1pD+L9HzfXBwmOYB+qFjgKxnrCmI9kI2QZbq4jS1Ed5ub0dBR?=
 =?us-ascii?Q?gaZ36Z7WhqnH+rOZ92gKW4PlpcAtCmGJcUefnqTvsNYSnE2lmoNrdlmgUduZ?=
 =?us-ascii?Q?f/xc+8/8ikBESb8VHtFH8/Gagw0B2RBSFuAvmjhp2cmh8U2VH0q1MZOk4lZU?=
 =?us-ascii?Q?hRo7nLLvLNU+6DVcZ4n1ruxH/VRQi+RqKIvTt9TwlBrx+FEtNeJEevgUYhEI?=
 =?us-ascii?Q?PDQaXmebm5V5BA+anbY4jXcvIkh/eubmNMV7TgHxKUf8PhEvi1zE/a11rOg8?=
 =?us-ascii?Q?0/9zZED1RywL0WxA7cEHkNO9LUJ/GhrupK/KBq+7brEqQrMNEzb0IdEz2m/V?=
 =?us-ascii?Q?C2QbfBb26xjyv5NwL1dyUppJX5uFHuuJaS9RetICL3eMc5kybChTJtbTydXs?=
 =?us-ascii?Q?ZWlFtpTb4irrZWpURoH+ayt3i3CP+YAYKNdgPFjLFcr7cMxcV7ra7vtp1Qgk?=
 =?us-ascii?Q?z+XOZcSjK5+ZiBCxFSZPG9A9MRxR7glaCU9XxWVFz4o/P55V5MpkbfpiYwaJ?=
 =?us-ascii?Q?DL4wrizQ7Z37k19htFDBzC2PaWcWSEvHKHBycOnIZFIgJsYa1i/fU1Ybcydw?=
 =?us-ascii?Q?fmOoEWc9gzOPTJ/Nyurp6blW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 559348b4-9c10-47ca-8990-08d97cd327be
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 07:41:00.0685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U1UfByCmgumsZgBCVy2JLx5KCv2bksuUnkqm9+ZMYVZ0WREFfT5DyPu0oHyYfqAcAgzKNSUORJvlutekGAMdl9dcYjt7aAH872od4RGW+0o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5411
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10113 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0
 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109210049
X-Proofpoint-GUID: y-_qR0sx73yV1Q4W076-NFXMCLK1cm7t
X-Proofpoint-ORIG-GUID: y-_qR0sx73yV1Q4W076-NFXMCLK1cm7t
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 21, 2021 at 09:17:07AM +0200, Peter Zijlstra wrote:
> On Tue, Sep 21, 2021 at 09:17:27AM +0300, Dan Carpenter wrote:
> > On Thu, Sep 16, 2021 at 11:59:30AM -0000, tip-bot2 for Yafang Shao wrote:
> > > @@ -11424,7 +11441,7 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
> > >  		if (!cfs_rq)
> > >  			goto err;
> > >  
> > > -		se = kzalloc_node(sizeof(struct sched_entity),
> > > +		se = kzalloc_node(sizeof(struct sched_entity_stats),
> > 
> > This wasn't there in the original patch and it causes a Smatch warning
> 
> What original patch? It's part of the v4 posting.
> 
> > because "se" is declared as a "sched_entity" but it's allocating a
> > larger "sched_entity_stats" which contains a sched_entity.
> 
> Yep, on purpose.
> 
> > To me, ideally, we would update the type of se.
> 
> That's a lot of churn for very little gain. I can rewrite it like:
> 
> 	struct sched_entity_stats *ses = kzalloc_node(sizeof(*ses),...);
> 	se = &ses->se;
> 
> If that makes smatch happy. It's the exact same thing tho because we
> force ses->se to be at 0 offset.

I mean, I understood what the allocation was doing and that this was a
way to avoid churn.  But it's pretty confusing, because every "se" is
really an "ses" now right?

Anyway, just leave it.  It's fine.

regards,
dan carpenter