Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ondrej Zary <linux@zary.sk>
To:     linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/core] x86/iopl: Fake iopl(3) CLI/STI usage
Date:   Tue, 21 Sep 2021 13:09:26 +0200
User-Agent: KMail/1.9.10
Cc:     linux-tip-commits@vger.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
References: <20210918090641.GD5106@worktop.programming.kicks-ass.net> <163220928593.25758.16098239507716851071.tip-bot2@tip-bot2>
In-Reply-To: <163220928593.25758.16098239507716851071.tip-bot2@tip-bot2>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <202109211309.26518.linux@zary.sk>
Precedence: bulk

On Tuesday 21 September 2021, tip-bot2 for Peter Zijlstra wrote:
> The following commit has been merged into the x86/core branch of tip:
> 
> Commit-ID:     32e1ae626f295152d1fc9a3375214133cbe62878
> Gitweb:        https://git.kernel.org/tip/32e1ae626f295152d1fc9a3375214133cbe62878
> Author:        Peter Zijlstra <peterz@infradead.org>
> AuthorDate:    Fri, 17 Sep 2021 11:20:04 +02:00
> Committer:     Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Sat, 18 Sep 2021 12:18:32 +02:00
> 
> x86/iopl: Fake iopl(3) CLI/STI usage
> 
> Since commit c8137ace5638 ("x86/iopl: Restrict iopl() permission
> scope") it's possible to emulate iopl(3) using ioperm(), except for
> the CLI/STI usage.
> 
> Userspace CLI/STI usage is very dubious (read broken), since any
> exception taken during that window can lead to rescheduling anyway (or
> worse). The IOPL(2) manpage even states that usage of CLI/STI is highly
> discouraged and might even crash the system.
> 
> Of course, that won't stop people and HP has the dubious honour of
> being the first vendor to be found using this in their hp-health
> package.
> 
> In order to enable this 'software' to still 'work', have the #GP treat
> the CLI/STI instructions as NOPs when iopl(3). Warn the user that
> their program is doing dubious things.
> 
> Fixes: a24ca9976843 ("x86/iopl: Remove legacy IOPL option")
> Reported-by: Ondrej Zary <linux@zary.sk>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lkml.kernel.org/r/20210918090641.GD5106@worktop.programming.kicks-ass.net

Could this be backported to 5.10 kernel so it can get into the recently released Debian 11?

-- 
Ondrej Zary