Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Sep 2021 06:24:07 -0700
From:   Kees Cook <keescook@chromium.org>
To:     sxwjean@me.com, x86@kernel.org, linux-mm@kvack.org
CC:     Xiongwei Song <sxwjean@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Gabriel Krisman Bertazi <krisman@collabora.com>,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Balbir Singh <sblbir@amazon.com>, Jens Axboe <axboe@kernel.dk>,
        Lai Jiangshan <laijs@linux.alibaba.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Kim Phillips <kim.phillips@amd.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Stefan Metzmacher <metze@samba.org>,
        Marco Elver <elver@google.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_0/2=5D_Use_generic_code_for_v?= =?US-ASCII?Q?irtual_address_of_randomization_of_x86?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20210921110252.2593542-1-sxwjean@me.com>
References: <20210921110252.2593542-1-sxwjean@me.com>
Message-ID: <4EB3D825-264D-447A-8C55-FA0CE8BC31F6@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On September 21, 2021 4:02:50 AM PDT, sxwjean@me=2Ecom wrote:
>From: Xiongwei Song <sxwjean@gmail=2Ecom>
>
>Hello,
>
>The two patches are to use generic code for randomization of virtual
>address of x86=2E Since the basic code logic of x86 is same as generic
>code, so no need to implement these functions on x86, please see the
>details in comments of patch 2=2E

Hi!

The other patches do not seem to have arrived; I only see 0/2=2E

-Kees

>
>Please review it=2E
>
>Cc: Thomas Gleixner <tglx@linutronix=2Ede>
>Cc: Ingo Molnar <mingo@redhat=2Ecom>
>Cc: Borislav Petkov <bp@alien8=2Ede>
>Cc: "H=2E Peter Anvin" <hpa@zytor=2Ecom>
>Cc: Andy Lutomirski <luto@kernel=2Eorg>
>Cc: Gabriel Krisman Bertazi <krisman@collabora=2Ecom>
>Cc: "Chang S=2E Bae" <chang=2Eseok=2Ebae@intel=2Ecom>
>Cc: Al Viro <viro@zeniv=2Elinux=2Eorg=2Euk>
>Cc: Arvind Sankar <nivedita@alum=2Emit=2Eedu>
>Cc: Alexey Dobriyan <adobriyan@gmail=2Ecom>
>Cc: Oleg Nesterov <oleg@redhat=2Ecom>
>Cc: Balbir Singh <sblbir@amazon=2Ecom>
>Cc: Jens Axboe <axboe@kernel=2Edk>
>Cc: Lai Jiangshan <laijs@linux=2Ealibaba=2Ecom>
>Cc: Dave Hansen <dave=2Ehansen@linux=2Eintel=2Ecom>
>Cc: Peter Zijlstra <peterz@infradead=2Eorg>
>Cc: Andrew Morton <akpm@linux-foundation=2Eorg>
>Cc: Arnd Bergmann <arnd@arndb=2Ede>
>Cc: "David S=2E Miller" <davem@davemloft=2Enet>
>Cc: Kees Cook <keescook@chromium=2Eorg>
>Cc: Kim Phillips <kim=2Ephillips@amd=2Ecom>
>Cc: Yazen Ghannam <yazen=2Eghannam@amd=2Ecom>
>Cc: Davidlohr Bueso <dave@stgolabs=2Enet>
>Cc: Stefan Metzmacher <metze@samba=2Eorg>
>Cc: Marco Elver <elver@google=2Ecom>
>Cc: "Eric W=2E Biederman" <ebiederm@xmission=2Ecom>
>Cc: Christophe Leroy <christophe=2Eleroy@csgroup=2Eeu>
>Cc: linux-kernel@vger=2Ekernel=2Eorg
>
>Xiongwei Song (2):
>  x86: Rename TIF_ADDR32 to TIF_32BIT
>  x86/mm: Randomize va with generic arch_pick_mmap_layout()
>
> arch/x86/Kconfig                     |   2 +-
> arch/x86/include/asm/compat=2Eh        |   7 +-
> arch/x86/include/asm/elf=2Eh           |   2 +-
> arch/x86/include/asm/page_64_types=2Eh |   6 +-
> arch/x86/include/asm/processor=2Eh     |   4 +-
> arch/x86/include/asm/thread_info=2Eh   |   4 +-
> arch/x86/kernel/process=2Ec            |   5 --
> arch/x86/kernel/process_64=2Ec         |   4 +-
> arch/x86/mm/mmap=2Ec                   | 112 ---------------------------
> include/linux/compat=2Eh               |   4 +
> mm/util=2Ec                            |  18 ++++-
> 11 files changed, 37 insertions(+), 131 deletions(-)
>