Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2848841pxb; Tue, 21 Sep 2021 08:58:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbYh7wP2+o3x9Fz1qt1RtuhqKZTSKlOGWgh0WS9KzotVSfToHZGOD/ubd8/I3OVEu8iXbL X-Received: by 2002:a17:906:348b:: with SMTP id g11mr6075750ejb.202.1632239907023; Tue, 21 Sep 2021 08:58:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632239907; cv=none; d=google.com; s=arc-20160816; b=CZMOpmU1DeeDT5oedOFZwh+yr0Heglr6zVO2XxWUA4KdX3D+0xZvpChhvGwdlsryok lD+XSNphpmNx6AgOA3V19W5Vjx+JKy3KXzdLd5Zn8FH71EK3I+HL/Aiax24pMhLAvRwa ng/UE7kQi9YBhmo0pFNUKH9Cm7sqQEDTFjifyjN0d4M6FDP76T/6H9OEJw9IUUC2fKNp orWAgXtleDbtJZQYeU6joyKD2wFM/9cCxLoEPiBRnJY+6r5QlLJysVs1nPnkulkvoOso comL4eGjKb+VAazUELaYTsUkO9fiGB0Gtq34KdyIOt4CIw/IXbfH/OEV5tNszocr075X 8QXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ixn89/zmTFvn2VsAxySlcwZmxQZw9ZAaKMmNbLdGHd0=; b=fAULDSOg6AMZUJJ5ep5D86gr32l8fqD8g5zJ9Kfw4IiJuwqPt0T0ngFPs4+MEAIyYv mSWbx8urXgWqOQA1e5V6bFa0zvvYegkFI1jdUoVQPA/F3uRRqifsKPYzqjxdOMg8NqwI +m2sh+vZKB4pUjD5UnqNRYRFJ7wtFE1TCfakWSg3b/s2y3Xxh+DVVOL0YvUlXfRG0j/4 B2yxDA2HyiloYAKRbXOTmOYdHknMTHAAgOKer5P/1WQgKIxSG/a6RVak7FUaPX7xog6g YMZfmlNZInKgMaawsr1toMtgKIKxIh/oG+gdNdDUChpzAlPnewz+Bz5/khYEDL7RZgeK Xs5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qUg8+mph; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s4si8067674eds.584.2021.09.21.08.58.02; Tue, 21 Sep 2021 08:58:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qUg8+mph; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234259AbhIUPzJ (ORCPT + 99 others); Tue, 21 Sep 2021 11:55:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:41224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234299AbhIUPyl (ORCPT ); Tue, 21 Sep 2021 11:54:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86C21611EF; Tue, 21 Sep 2021 15:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632239593; bh=RAm2TBCw5TxiLV9IkIE8lJLorq9H5ORzpSdJSH0VVMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qUg8+mphxk8z+noePav16pSzYFFOMNmzS+mQUaKlcLpbGHK6p5WtGBHBlI4HZJTxn Vql2jry1zP03ruf2RdOOIloJodYdSc4Nv+ccT9Q+1Teu9mdIzVllvjI8b+AQ+LKLp9 b5ZkavNVKI87SisZLhBN+FwyykvBSzazrAIbKhOA= Date: Tue, 21 Sep 2021 17:53:10 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Chan , Jakub Kicinski , Sasha Levin Subject: Re: [PATCH 5.10 116/122] bnxt_en: Convert to use netif_level() helpers. Message-ID: References: <20210920163915.757887582@linuxfoundation.org> <20210920163919.617145875@linuxfoundation.org> <5662a5175932e46febd024cadc4bece443aa92c0.camel@perches.com> <0a25e9c5ff70899369134be4fdd609d2ee21baed.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a25e9c5ff70899369134be4fdd609d2ee21baed.camel@perches.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 08:49:52AM -0700, Joe Perches wrote: > On Tue, 2021-09-21 at 17:04 +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 21, 2021 at 07:30:42AM -0700, Joe Perches wrote: > > > On Mon, 2021-09-20 at 18:44 +0200, Greg Kroah-Hartman wrote: > > > > From: Michael Chan > > > > > > > > [ Upstream commit 871127e6ab0d6abb904cec81fc022baf6953be1f ] > > > > > > > > Use the various netif_level() helpers to simplify the C code. This was > > > > suggested by Joe Perches. > > > > > > There isn't an actual change here. > > > > > > Unless this is a precursor to another patch, this isn't anything > > > that should go into stable. > > > > > It is a dependancy for other fixes. > > Then it's useful/necessary to mark it as such when applying it. > That's hard/difficult/messy to do :)