Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iommu/arm-smmu-v3: poll cmdq until it has space
To:     Fernand Sieber <sieberf@amazon.com>, <will@kernel.org>,
        <robin.murphy@arm.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
References: <20210921114338.1144521-1-sieberf@amazon.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <c1c10203-ffd3-25f9-f2c6-9cee3458aac9@huawei.com>
Date:   Tue, 21 Sep 2021 17:22:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20210921114338.1144521-1-sieberf@amazon.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/09/2021 12:43, Fernand Sieber wrote:
>   	do {

I didn't follow the full logic of this change yet ...

>   		llq->val = READ_ONCE(cmdq->q.llq.val);
> -		if (!queue_full(llq))
> +		if (!queue_has_space(llq, n))

But is the polarity really correct? That is, if we don't have space, 
then exit with success (the function to check for space).

>   			break;
> 
> +		/*
> +		 * We must return here even if there's no space, because the producer
> +		 * having moved forward could mean that the last thread observing the
> +		 * SMMU progress has allocated space in the cmdq and moved on, leaving
> +		 * us in this waiting loop with no other thread updating
> +		 * llq->state->val.

what is llq->state->val?

> +		 */
> +		if (llq->prod != prod)
> +			return -EAGAIN;
> +
>   		ret = queue_poll(&qp);

Thanks,
John