Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2907783pxb; Tue, 21 Sep 2021 10:07:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/jMyXI6JdgiYWcFFiAAtTEk6kYFhA+1TYStrnqjMEykmsWg29PHG0sdhglyXDSZb+PdwI X-Received: by 2002:a17:906:8981:: with SMTP id gg1mr36109499ejc.95.1632244050886; Tue, 21 Sep 2021 10:07:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632244050; cv=none; d=google.com; s=arc-20160816; b=QNt6TCwnE9OyrGjEky5ouF1O1IamzBAW7cQkNjO30KBwDPCUfjktTjKtxIh5BuiPkO DneTLebabrSJ0XVsanxsFRaOclgapKGsxER2Zdx+ErATgqSKArxP2b1RA2RcjVUTLZWG FWe4JYAo1S9Ni8AN6Xpka4+U7yDdSgSu0aNDDYhvnLygbHXXwMRwQ/epgBL8XdwxswDM 7XFzX2os3/frq/+1wG/HNjJyZJ5PpnYnx186xcLKJFVikecdq2uvkdhHB+GxjRpQaS5T KlNdWQpGMNuoufr4DD9ghpmOzyEByx1nFHl9rzP4Iktthh7vrkfAWDUEwGQWfug8gHLf OWSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=juKqj0x89/7AEHVIBGTcizx1Pw0HtMY67ztSXDRypxU=; b=MhGvonmUTJl4DrerFc/YXiQhtaA58+4EEKXlHveqOhX81rrjeqzZq9NDP3DF6O9nR2 E6io7eZr3DMBOspdIg4b58DNg7sKR5O0BORSpzjz4Y0+SURVuw06k6h1/4xAlgTR2BNe JZwGKVzWjdTpC5BNxHW/iPZa/DnhfY73DRnGek3iqKsEVwFoF7jwXAmqDp8hoAgLaD4j Lj1LAI/5earEivWrjuqx655kFAfGU/yiYEsMI2PqomVAlmFupgZyR9J8JGvtgdCGJKVY 7IsP9YcBdUTy1rsFXrrnDLEhEedCoSCQLESIV4sWa8jAb0OTGWjndfYyxW8faxMG5Hcu J54A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt12si17773067ejb.538.2021.09.21.10.07.02; Tue, 21 Sep 2021 10:07:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhIURDs (ORCPT + 99 others); Tue, 21 Sep 2021 13:03:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:58174 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbhIURDj (ORCPT ); Tue, 21 Sep 2021 13:03:39 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="202911756" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="202911756" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 10:01:36 -0700 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="435946559" Received: from adkuncha-mobl2.amr.corp.intel.com (HELO [10.251.2.103]) ([10.251.2.103]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 10:01:36 -0700 Subject: Re: [PATCH 1/2] mm/migrate: optimize hotplug-time demotion order updates To: "Huang, Ying" Cc: Dave Hansen , linux-kernel@vger.kernel.org, oliver.sang@intel.com, mhocko@suse.com, weixugc@google.com, osalvador@suse.de, rientjes@google.com, dan.j.williams@intel.com, david@redhat.com, gthelen@google.com, yang.shi@linux.alibaba.com, akpm@linux-foundation.org References: <20210917223504.C140445A@davehans-spike.ostc.intel.com> <20210917223505.F817CB6B@davehans-spike.ostc.intel.com> <87k0jeog7r.fsf@yhuang6-desk2.ccr.corp.intel.com> <2d7e4078-f9c0-7511-0bab-de5dab25b45d@intel.com> <87a6k66lnd.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Tue, 21 Sep 2021 10:01:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87a6k66lnd.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/21/21 7:36 AM, Huang, Ying wrote: >> This removes the need for the demotion code to track *any* state. I've >> attached a totally untested patch to do this. > Yes. This sounds good. I will try to test this patch on my side. > >>From another point of view, we still need to update demotion order upon > CPU hotplug too, because whether a node has CPU may be changed there. > And we need a solution for that too. Just to recap... The reason I sent this series is that there's a known, detectable regression in a memory hotplug "benchmark". This affects the 5.15 series. While I agree that we should look into the impact on CPU hotplug, I think we should probably focus on the *known* memory hotplug issue for 5.15.