Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Sean Christopherson <seanjc@google.com>, tcs.kernel@gmail.com
Cc:     vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        jarkko@kernel.org, Haimin Zhang <tcs_kernel@tencent.com>
References: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com>
 <YTJK4aACtboaPAF8@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] KVM: x86: Handle SRCU initialization failure during
 page track init
Message-ID: <af562685-673a-489d-6a00-5e77329dc2a4@redhat.com>
Date:   Tue, 21 Sep 2021 19:47:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YTJK4aACtboaPAF8@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 03/09/21 18:18, Sean Christopherson wrote:
> Before moving forward with a fix, I'd like to get Paolo's input on dropping
> track_srcu in favor of kvm->srcu and avoiding this altogheter.  Note, Paolo is on
> vacation at the moment, so this won't get attention for a week or more.

The reason for track_srcu's existence is to avoid complications in 
kvm_arch_flush_shadow_memslot, which is called from the _write_ side of 
kvm->srcu but is on the _read_ side of track_srcu.

I think this should be fixed easily by taking slots_lock in 
kvm_page_track_register_notifier and kvm_page_track_unregister_notifier, 
however it's a bit more complicated from the point of view of the lock 
hierarchy and possible deadlocks.

So I'm open to patches that drop track_srcu, but for now I applied this 
patch.

Paolo