Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com>
Date:   Tue, 21 Sep 2021 11:00:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to
 migrate_reason_names
Content-Language: en-US
To:     "Huang, Ying" <ying.huang@intel.com>,
        Weizhao Ouyang <o451686892@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        Michal Hocko <mhocko@suse.com>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        Yang Shi <yang.shi@linux.alibaba.com>, Zi Yan <ziy@nvidia.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Minchan Kim <minchan@kernel.org>,
        Mina Almasry <almasrymina@google.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Oscar Salvador <osalvador@suse.de>, Wei Xu <weixugc@google.com>
References: <20210921064553.293905-1-o451686892@gmail.com>
 <20210921064553.293905-3-o451686892@gmail.com>
 <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <d57aaff2-b154-4462-1a7d-3d288ebabb6a@gmail.com>
 <87ee9i6n1w.fsf@yhuang6-desk2.ccr.corp.intel.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <87ee9i6n1w.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFBNSExMMktEZUpnMmJzdTRZSzhINWxTZlR1QnI2ZFJBemhCQmdUOWRDdERB?=
 =?utf-8?B?cnJKTmZqaEFYa2E3RFFpK00xNGlOWFNLNjZvdzFHNWxYNHptYzB0YTNWV3pU?=
 =?utf-8?B?V2ZEYlVONUFtYUdaOW5LaXluSVhXOVRBY1RrRFgzSDFyS3NhTXN6L0hUcGwx?=
 =?utf-8?B?ZDdBRlk0blVZUTVpSTg0S0E5SkxyUm5ieDIvMmxoOXJTbVdYZ1Nxbi8rSVhB?=
 =?utf-8?B?ZkN6YTJEVnJ0SCt5UVFTWERSWlhHY1o3djRSdkpPVjl1aG9mRlAvN0VZT2Fh?=
 =?utf-8?B?Smt4eGMzR3REcTByMHZHMVBqZGR5Nkk4cksvV2E2ZFZoMVJtSjErVkVCaDlZ?=
 =?utf-8?B?NlNGMDRFbXZRZWpZVE5XeVlTeWtvZlhCUkFOdWNZUnJOZ3dEUUV3M1hMVzRP?=
 =?utf-8?B?UXJFZGlSRTRTNDJsQmp6OUVIOUJEcjlFZW9BOVdWZ3QvbFRVWHU3Y2FRTlpo?=
 =?utf-8?B?ajU5UHh6U2FoOFJ2MGw1VTdnbkZxWGFndDZEMU9YM1l3TEE0K3VGemlEbXZk?=
 =?utf-8?B?cGFDMjUxZ2FCTi81aHhjWEpzMGxaWUtKM2lkaU9tRHpOeTNNUU93dkVEbXpY?=
 =?utf-8?B?WFJzbzAxLzQ2ekFZazNYRU1LYzdQYjZ6M21UTngwOGZxRnNuNVh4YlpQMlRp?=
 =?utf-8?B?SkpSVVRCeVRQWEcrSFJGM01SWnhNa1RQMXd0UEZzMmdCdDdHMDZNbHdXTjVG?=
 =?utf-8?B?aG9IUTU5aDN0S3NyNHQ0eFFSMlpHT3NUb1hTOVIzN2ZKWVQ3M2NHdE8zSkw2?=
 =?utf-8?B?UmVGSWphQ1BEcGtmbFlHcmpiYWd1Ri9UMG5zaGFuZXI0NzgwNW1lbjQ3d3No?=
 =?utf-8?B?VC9ZdFNHa1lFd0orQ3NtalRrQTd5dFNuVThoWTZzTXpsSWdZaFZnUHg2eVVz?=
 =?utf-8?B?a29qRWJ2b1ozbzhibk1wNkJBSW9abHN1bVQweGhtMHVsSmFPS2wyUmo1cGpq?=
 =?utf-8?B?OExlZFJNNEdNS3dRdnBJUnBwWCttS3BhMlNob3Z4SnB6SisrbmpnN2gvWXY4?=
 =?utf-8?B?YURsN3hQTVR1SG9aNWxQdTlQd3ZXK1AxL2xsVm1Mc25vcllDZ3I1Sm9nTzdT?=
 =?utf-8?B?SnYxUEZhWkpkQVd6dWZoREp5V0N1WHpDL0JHMCtNVEExaG9RMGdaY3ZHTkVD?=
 =?utf-8?B?eTE5NjRxWU1FLzBBNkJrNW9SNEsrV2tBOUt0Y2Nmd0xnK0JYUThBSkJDaG1u?=
 =?utf-8?B?N2luRVBSMGVXblJtQkFoWENEcFA1ZXdUTU5PdUNCU2VOOFNpTC9NR0ZBVUtx?=
 =?utf-8?B?NDQwOG41MmdjSnlPaFE4SGZETERxOGdUbkxPeXlyRGExcEhaY3dDczdYbUE0?=
 =?utf-8?B?cHpmUG1LYjBMNnk0eWVDOGovM3FOeG9qMFhOYzZhM0NTSXhYRlMyN2NZWUkz?=
 =?utf-8?B?R3FpQ3gwVGJBcTlNVnFjUW1Ebys1UHgwTUdKQm5vbWFVUlBLUzdMeWVlYXR2?=
 =?utf-8?B?M0FkbUJuaFNKa3dtTlJJNS8vdE5RWTZXbkZzbHE4NTFNZS8zT3ZGRzJWc0ls?=
 =?utf-8?B?VGM2U2ZnVURPdWNpYXNWdEl4TU13aWRFZ3QraFAycUllTk5uZDY4UmNidXhR?=
 =?utf-8?B?ckhHa1lCS3pWelowR2pYRkx1MmE4ZzFiSElsMmM4dlRXV0ZVR29COThxRVBM?=
 =?utf-8?B?akt3STJBc3VMRjBoMGJ2Q3BDQU9pUUhsOVc4Y21UZERmYlZuM3hNQ2lUUkZr?=
 =?utf-8?B?NDBydmdPQkFFZk1FVDh5c09CbHR6Nkw4eEdIb0VVVE9ZUmQvMTJIQXlIY3pH?=
 =?utf-8?Q?2NcOVmiolB0/ZvpB3wd1qnJlRyURA0N3VAGIJBV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0915cbec-e724-4831-ffdf-08d97d29a4d0
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 18:00:06.8787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rjTuQ3jJ9220NzNUIyZVPZCkGAsm82ipseMD5WrwmZ+mVLOaZgQu+PkikYDIN/6Sr+kIEG8UAgl9e/zGonT8RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2680
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/21/21 07:06, Huang, Ying wrote:
...
>>> Can we add BUILD_BUG_ON() somewhere to capture at least some
>>> synchronization issue?
>>
>> Hi Huang, we discussed this in the v1 thread with you and John, seems you
>> missed it. Now we just add a comment to do the synchronization, and we can
>> figure out a more general way to use strings which in trace_events straight.
> 
> Got it!  And I think we can add the BUILD_BUG_ON() now and delete it
> when we have a better solution to deal with that.  But if you can work
> out a better solution quickly, that's fine to ignore this.
> 

I have a solution now, it's basically what I sent earlier. There appears to be
some confusion about it. I'll send it out as a patch that builds on top of
these two, hopefully in a few hours, if no problems pop up during testing.

thanks,
-- 
John Hubbard
NVIDIA