Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3011081pxb; Tue, 21 Sep 2021 12:26:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdlnqDXPTQi6K8z8VfhtrqQfpMAh4ywgQPRxBX8iaPm4oc9Tp4vNvTFiTC2oNQlqPl+WED X-Received: by 2002:a05:6e02:1bc3:: with SMTP id x3mr23420701ilv.113.1632252410523; Tue, 21 Sep 2021 12:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632252410; cv=none; d=google.com; s=arc-20160816; b=uGW7P7kLviGEtcPJalFaD6WYzFoRPQDzOaj4wWCvdKiOQ7H/BalcGH6la42SrnA9oW IsEpfQ9PdZbEfW08qN8dQZ6LVWIv3nz44EUP5689r+z+pRn5RsUZDytQ3u1BnZr9XcM2 j0clmCEf0vspJZMlL2pILRAVhsqE2NH9Ev62o8mi8bfywP2dTXyKrSGp35wb39ndEHxK MSfH/n4m1tkGHcIKAi4Kb2kuYORjWAeGVxdSHgoOsDk8VRHQgzSabIEnPmEwZf0xZXfG G0qbSirk9igZ4L4tY38ZQlvb4mICU3NPVgK+ZRfR4XrIAiRQyLFYNGrjnds48o0Yzv71 /4iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=o2gyCGlUrboNcIiNieqE+IfjFr7udGGsuUiWMYUkrwc=; b=uYeSz+ZwZcN/+siMBsG3xS8YTPeXcblLPoo0CYZdxkTQBMg08VZVU3xVZEehUO+pTq Fh1c2lHq+45WQCghi9eNVJUIQW7cANCcv8cR49s4oAmJVgM4FXXBwLAZm4finAGpJtzR TK3+daan9ZuUB3MznahMtE01yfSZTHfB9G355As9qz1pXDMCUZl2JgFMgKmXdcwZ+Qig BHWUIbVc3Fz4C7lxpQ5oud9hYp5hkYbbGgaYo1irXVvSWGIZU825Mh5+u+tjF+pO24xe P1cL4u2oM17vECwcHulVPA8ILOBQhX6hXQH6m/Dtpy1E5awO/HGoQvEmF0aPaJEoiKFY HvKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqNExlIm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 129si6783141iob.34.2021.09.21.12.26.39; Tue, 21 Sep 2021 12:26:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqNExlIm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbhIUSFC (ORCPT + 99 others); Tue, 21 Sep 2021 14:05:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56533 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbhIUSFB (ORCPT ); Tue, 21 Sep 2021 14:05:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632247413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o2gyCGlUrboNcIiNieqE+IfjFr7udGGsuUiWMYUkrwc=; b=eqNExlImFOC7IvaOy4NfMdGeXMAax1qJO5Y/Z4cZjlg6iEda0JLDB5K7Foa076rlgCFSMY VOSDxEwbsXcRbbm3zCLBg5jAnC9e+MSboXGTNmi03Nsn+ncsTNCPwHpO0Q2ppW37tYmIyZ IStyvjjGSr8eH4j5IlDgTBAo6n6fc6Q= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-L4Q_xUlmM0meW48EXsaOug-1; Tue, 21 Sep 2021 14:03:31 -0400 X-MC-Unique: L4Q_xUlmM0meW48EXsaOug-1 Received: by mail-qv1-f72.google.com with SMTP id b17-20020a056214135100b0037eaf39cb1fso2473736qvw.11 for ; Tue, 21 Sep 2021 11:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o2gyCGlUrboNcIiNieqE+IfjFr7udGGsuUiWMYUkrwc=; b=s62gb5HLKZEcCk5gJdCJ3j5sWENx9R8E/kx01ogiYTs7u2pSrPP5FinxJ6OAL5ACTi wrwpIgvMd7eznG4Erdbd1jDWQf+UhDovOd0WvToi1jpWIefQoxm8zu3fq20DlBF6yF5o uER+kxXQGQbBEWRzEQPKKRbHoBkegAENF3hqR8Likw+KuYvA+H+SOompQ5442JTWLGim 2xd4VxTaUu3iB9+wsmR1L6MGccTgt5Cv1DC9KTCWvcAkTnHlj8Gv2RvQlC6J08FCCgQy pX4fXxSZnJRNSFJ0yFawhKv2PzZFD0oTYk1j8nTwO6y45nq5x399CL/+AIk4Bv23yuOZ X5Og== X-Gm-Message-State: AOAM5303e3xfkIRV0k0+3yvzMIt5KeKnvsdL4MIt4fRvLZIG0edjqFfJ LBDjSq6Xrk1X3sG4asl2xR+pcgjecOkrMMCH2ZqEfT8SXHF5YgiOZV9NgoTulYO18DwmUCv7QCL ewbr8O8gh1fqpTjlEoGzxfDhk X-Received: by 2002:ac8:4e11:: with SMTP id c17mr15690794qtw.400.1632247411185; Tue, 21 Sep 2021 11:03:31 -0700 (PDT) X-Received: by 2002:ac8:4e11:: with SMTP id c17mr15690771qtw.400.1632247410936; Tue, 21 Sep 2021 11:03:30 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::d3ec]) by smtp.gmail.com with ESMTPSA id d5sm3792039qtr.61.2021.09.21.11.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 11:03:30 -0700 (PDT) Date: Tue, 21 Sep 2021 14:03:29 -0400 From: Peter Xu To: Axel Rasmussen Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] userfaultfd/selftests: don't rely on GNU extensions for random numbers Message-ID: References: <20210921163323.944352-1-axelrasmussen@google.com> <20210921163323.944352-3-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210921163323.944352-3-axelrasmussen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 09:33:23AM -0700, Axel Rasmussen wrote: > Two arguments for doing this: > > First, and maybe most importantly, the resulting code is significantly > shorter / simpler. > > Then, we avoid using GNU libc extensions. Why does this matter? It makes > testing userfaultfd with the selftest easier e.g. on distros which use > something other than glibc (e.g., Alpine, which uses musl); basically, > it makes the test more portable. > > Signed-off-by: Axel Rasmussen Reviewed-by: Peter Xu -- Peter Xu