Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Sep 2021 15:04:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Liu Yi L <yi.l.liu@intel.com>
Cc:     alex.williamson@redhat.com, hch@lst.de, jasowang@redhat.com,
        joro@8bytes.org, jean-philippe@linaro.org, kevin.tian@intel.com,
        parav@mellanox.com, lkml@metux.net, pbonzini@redhat.com,
        lushenming@huawei.com, eric.auger@redhat.com, corbet@lwn.net,
        ashok.raj@intel.com, yi.l.liu@linux.intel.com,
        jun.j.tian@intel.com, hao.wu@intel.com, dave.jiang@intel.com,
        jacob.jun.pan@linux.intel.com, kwankhede@nvidia.com,
        robin.murphy@arm.com, kvm@vger.kernel.org,
        iommu@lists.linux-foundation.org, dwmw2@infradead.org,
        linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com,
        david@gibson.dropbear.id.au, nicolinc@nvidia.com
Subject: Re: [RFC 15/20] vfio/pci: Add VFIO_DEVICE_[DE]ATTACH_IOASID
Message-ID: <20210921180417.GZ327412@nvidia.com>
References: <20210919063848.1476776-1-yi.l.liu@intel.com>
 <20210919063848.1476776-16-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210919063848.1476776-16-yi.l.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oLzMr4fJnwf5cjPhJ98PSzbm4ftyraQAJ+NabmQOvbLNkr14YPtIyeigThG7?=
 =?us-ascii?Q?j8IB2aLLfyq4X0zBGh26Zcg4kSDz9fUR5VFHa62pwrMNSO7fn2km+pfCr3Ie?=
 =?us-ascii?Q?tNWPU0oXZW9ctt8+a76pi/MCqRtJRyxC8fkhzCW+Vy2WUkFiUI0KF9GKXqv2?=
 =?us-ascii?Q?uaLkALn6BryoUDQaxn1zx1XeQ/nbkY0VIYborXuTZEW/joiO7mKuWyc8NXZJ?=
 =?us-ascii?Q?4n+qhQXRX6NpTMfgXVBqiMJE/t9j0AYVfU0E6KQDwCuyJzXBC8hdBFvhGjGm?=
 =?us-ascii?Q?quj2waTN3lvuxIPvgDJiqc8iXAuypiYuB7oSu0/JEZ/SE+HGCHD0fX09dqDC?=
 =?us-ascii?Q?ytSEgIPwrKrgEb5Vn01fnvtlhKBPMCxXv9dECbOwE8nYzJ8AUA2Lt01Th454?=
 =?us-ascii?Q?LKEEU+2btPb8KEFLc+tVZQ8p30lkDABSRjfxcWfMjVvfZIrielxRlg7xXyuO?=
 =?us-ascii?Q?fwBTZmTfOme4+xmZKST7jMnnE8KYMBZl1l1l8TrT5L6Nys3U2Q66LO8kyWyX?=
 =?us-ascii?Q?5GUwnP7Z8spjEbGf/GJ301o33xZpQamfqXmK1ZZcm4hD6w9sig8EWjeEjkK/?=
 =?us-ascii?Q?t3rvbTGrVrnsrFgKiQOfcZw94be8nLdaCq2ex7E0t4ifTGYsUYj01ws4osfe?=
 =?us-ascii?Q?ZW3OdX3WkXoio2TaV+TrBrfXBoey1VuO0qLr6nhfeGti5AHZGW/zJ8ef0eO5?=
 =?us-ascii?Q?B8WjoqMTNAI/ZhsluWoXfJkZeGma7GvEQnlEysk/tv2duxwbkEQ/LkEEVbkG?=
 =?us-ascii?Q?e3VKxMZ++1tlOMs/HA23WJDurfAvGHdjiW2FgQmwvD1JqBTq4lRKKG2CboWD?=
 =?us-ascii?Q?XHb94/tXgZPTzVMoaVBKIVWV6/CliuaBYvVCrOpaZ3EXbxScllJ1gQKq7YRO?=
 =?us-ascii?Q?s9iFi2X0s7sBZdpd3v2fynIxTHZVmxEjbnHNZOB2uMfnVn1FY9EuHDa8fvsP?=
 =?us-ascii?Q?hdpbjK7bnbyf4my6CQp136H9b+ZQzmjGHWjofOVogTHdJu21NiDXkezuJOyv?=
 =?us-ascii?Q?Trz05iuJ1O60UQOC7XCSMbn+UyjhzgbKjSxCtY+keSBQfVYBpXcg8SXgAJQ5?=
 =?us-ascii?Q?tyNTtg4r9T6h6geu648xyRZbog2lSQgon+2NsOHhdMY/qHUDyrKOI6Js+PdY?=
 =?us-ascii?Q?GMmD4O+FHPEnuoTu+Fh6WCBbwvCtnFBtQdFZQnlo+ljuytCaChWsngk5R3fs?=
 =?us-ascii?Q?9lFeEKAmM24YqK49xwHecwfBg9WmTVzY4d9B4q0t7IZGbpNRaX3oT0GcPO94?=
 =?us-ascii?Q?oBE4b+pM9Lak3QM61vO+yYn6B1yd5tx2OSMfDqs8ypSyjPrWgQZS/a83C4qa?=
 =?us-ascii?Q?CxHPxWA5sN/P99qRJwcv+og6?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86b754d0-f2b7-493d-3013-08d97d2a3b02
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 18:04:18.4670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4A9jl4po/dS2QZf+jd07Pr4KM0xZcgXzZ9GkjpOkEFtz81J7WpPmQvJ8d+1XmaNl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5239
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 19, 2021 at 02:38:43PM +0800, Liu Yi L wrote:
> This patch adds interface for userspace to attach device to specified
> IOASID.
> 
> Note:
> One device can only be attached to one IOASID in this version. This is
> on par with what vfio provides today. In the future this restriction can
> be relaxed when multiple I/O address spaces are supported per device

?? In VFIO the container is the IOS and the container can be shared
with multiple devices. This needs to start at about the same
functionality.

> +	} else if (cmd == VFIO_DEVICE_ATTACH_IOASID) {

This should be in the core code, right? There is nothing PCI specific
here.

Jason