Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3015849pxb; Tue, 21 Sep 2021 12:33:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxepAkVtYhqsGulvnM5yNtU+EC5IBT65OghEXimhhoWWr+XQotu/sjo/2jEpJ5j4424M7+t X-Received: by 2002:a6b:6704:: with SMTP id b4mr1421538ioc.121.1632252839600; Tue, 21 Sep 2021 12:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632252839; cv=none; d=google.com; s=arc-20160816; b=GgKFhWgo4KG40EPdw5ToT0xi9/BYv/i0N6g0MYnDFGXDTL+QCRcAiOOVj0aBXvpqwh 6ud+g8sIF5qzpmLhBEYd/dJuCoDoWWJZMXqQIZv15qU/GljEOkr5zp15NS1wtNuY/6TK wXjcE6DF79tqb3DgOpaetU0G+IGbVLxywYn1hBp8LeCLSMt7IadwK3aRSBoiCTpupzNH /H2+HIw9eBkCx9cUPnpw7JortlC2L7LNty4Ev/nTeooGnAkNMufYOl4/jd1oKgGsQBsV PthizvCf5M0WuXSQcc3CIwIKrHe0rcDYBi+Lsl5dDYTfRbedryEzhODLV5EqHeBEq5PD 63gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=H8Wo2U3fZZPbINkKPHgF5f7NF214eZln9lkI6++RKwQ=; b=m3bR4u6UcXH8abcJaq9z6XFqMYAszl0BJNqJeaDHasLRMkgBkmPQq6OIj/HvLj9oro L8P96YL+Ou3qmLvCsz4jsvH9f7EVL3/nW7qvI6Qq4N4L3F//Fe9hkD7FwheshnpHsbDo PaRFpssNcWZv0qvqrO7OO19yJDk4A2YjhbS7UCOsd6HqAFgiJJfMk4bQtrSNU8cMFzQF HbBEuaMqARaujrY8LQPwnqE4kuPpxZ/DbvyK4kNQ0/00IgeKO244Qq0P5Jjt4X4cuHt1 ZOB1yN9mpWu3JW1pwjkg8MFsbYiePgg2TNSOrpI8LKWYHKqvLwBPGWm0dyG8wOOyqwYE sclA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EIj/r7YA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si6850170jaf.87.2021.09.21.12.33.46; Tue, 21 Sep 2021 12:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EIj/r7YA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233090AbhIUSbA (ORCPT + 99 others); Tue, 21 Sep 2021 14:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233020AbhIUSa7 (ORCPT ); Tue, 21 Sep 2021 14:30:59 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEAE2C061574 for ; Tue, 21 Sep 2021 11:29:30 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id g41so1353929lfv.1 for ; Tue, 21 Sep 2021 11:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H8Wo2U3fZZPbINkKPHgF5f7NF214eZln9lkI6++RKwQ=; b=EIj/r7YAOR4TxSFqtc0XezwotcPykhRbz8ISMtniL5l072qU1Z+ERmN3lveAjpoBK0 vSgcUkbcqqBXAZCFZNe3AVHSJwdMknvcYAjd2iAijfzGnKDG2GUJZZjDgZg9jD4mpEB0 lNvDtdHeZPcdYBwgF++ZjBvmBuxqm3SANvk/lvAZ4/NpGHCaGQ3eFo4x181/HgQUJEs5 FIzysxC6YjCspxjPwnernK1SypdP416uUtU369zSvSiJsTFYVGFGJYCXxHYX9OBbfCVd nZt7hJD7RE6HLgXfXiVRneeBxZQ7Afw06UDaMBDrmRvi1cQz2SLpZg28DdCBRgO+mE3Y 1cZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H8Wo2U3fZZPbINkKPHgF5f7NF214eZln9lkI6++RKwQ=; b=tDj3jf0QjYC31L8W3AYw+S+mCEwGvo0NO6387meYOs2KzT5lZxbDCLBOiROJAim4rq fMuTefc/SsYPxKUZCG4aEOO8JIUSVTbmmy4R3GWIUiHZb8tqYrRHdCQaregHTbZDKax7 LLyyQ+2NRVi5PCZl+T0hFNeyYaqU3sfiu+wbbGiSUiyh03iMGHGPfVAh/afBPyc634aA Ce1MnJN3sS/d0G5QL2xp5oVsHIklLYEmN1JUSQB5G07TOl2sQhRRQ4Lie3iskCsHYfn3 BVuDKyAks8IgZ+DE9KchqTOzDJHrioTiSGnMlIAhNrzm9j1yNN7K5+9JOjVXfN+H93AV hCJw== X-Gm-Message-State: AOAM530GXESsBcjarfZEBPl2ZZ/77MhhcU5kQU+4Lq+dBuB2ZtZGeBRk qFleYH7DCSuZLo0O42cbVxZqjKZ5ZcyC+i/jIj8HJovk4KI= X-Received: by 2002:a05:6512:3c92:: with SMTP id h18mr23624483lfv.656.1632248969067; Tue, 21 Sep 2021 11:29:29 -0700 (PDT) MIME-Version: 1.0 References: <20210920103335.243-1-caihuoqing@baidu.com> In-Reply-To: <20210920103335.243-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 21 Sep 2021 20:29:18 +0200 Message-ID: Subject: Re: [PATCH v2] Input: cyttsp - Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Dmitry Torokhov , Linux Input , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 12:33 PM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Reviewed-by: Linus Walleij Yours, Linus Walleij