Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     hdanton@sina.com, hch@infradead.org, stefanha@redhat.com,
        jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Subject: [PATCH V2 0/9] Use copy_process/create_io_thread in vhost layer
Date:   Tue, 21 Sep 2021 16:52:09 -0500
Message-Id: <20210921215218.89844-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yfiAiR8f/vCw+RUcM0KuY4LfiwAnsoSQv6wMRqR02zVMgkUF6JlOmANRt7Pi?=
 =?us-ascii?Q?8pJEgTnCWYEPodQpBAe1HJX0pQTdptkmjVXfo1h12lXoMZZLeg2lENg+cy9a?=
 =?us-ascii?Q?5QiL7iNuya7AFNKy++n2PQhmSjWFKlsRIyygkZg199wy1LgvCPcIrntA4J5p?=
 =?us-ascii?Q?l/f0k0wKK+DpnkWw2xKTtv9w858cM+XYnfh+vXREZh0Nza4WQ4Ozt481drX2?=
 =?us-ascii?Q?aRo9svO37bz25YIr5d1w275D/WGVVHP+KcryiXfh+q/caCfQr1wPgn4eSfRo?=
 =?us-ascii?Q?GCZjMlV0iU+qQ/y3A274eJ8a5nC5Oo5fUQJk56/QPbf5AEQzyZ0omiFRCV3f?=
 =?us-ascii?Q?/hDDIrYPYEae0tIxQ5VozUTYPQmM6BC/QEQwijvJYCexkj4dnxcpI2fq0GhQ?=
 =?us-ascii?Q?SfcCjqJUFG2/OJBlZgtXANMk5m4zYfU60h8KI0ANnL/fbVhwbUXD/nV3n4mc?=
 =?us-ascii?Q?yQd85DXJSNXGY8LTGgeiR0KoYY2xooc9Q1ASRWNE4hWy5Ra6iSfBBx3boysK?=
 =?us-ascii?Q?UmeNI0zTiM7jLvrj7vVNEz+2ok2WqAg3oOXEgMr+t9bkhPBsROdjAyk+HA5c?=
 =?us-ascii?Q?GFQ61YYLxGBsom7xjmggz9gZqK7rwq4qYDGmYol1Ccr2pdC96br78nfkeXRh?=
 =?us-ascii?Q?+YmooP2UM/9RLyuOS67Bmkxp0oR+DHMz93th8St0prpc/w31PluxgNO4GACs?=
 =?us-ascii?Q?ZiZThOPzoux7FSENUTewD+JCSZhRi6C8pYKL5w9G99zNQnY8oPGiRr9RUWju?=
 =?us-ascii?Q?OOGS3kae+yrcgtQlbZZ0Or0WEflOt2gZmhtdsUvUzTjzYvVGeriF41gBPinV?=
 =?us-ascii?Q?gfpfT5gmlQw2e+hoV59ynPEHlJSfG5v9cjlkMiJkIIRmKBwzaXnYVNaRJKAR?=
 =?us-ascii?Q?EJQxulQm2xMKuweaZTfNcPqNHt0Xs2VwpvVDTsF94mK6GJ/b3HaFtKbElp2+?=
 =?us-ascii?Q?gtTY+Ok5ivXCa7ydryG71Xpg5deo0q1CZ+DiwDgmFRsX7qJiuGFf2o4VsKwS?=
 =?us-ascii?Q?9+rpviuAR4iiY8Vyq06djhN+nMpEqu08A2iUN1HRObtKnKi5w5Is4JLXGY6l?=
 =?us-ascii?Q?FHTuNlukHobKo6G6wAUztlQwj0cjTHBgABCXmZBHae8hIiBwz7zkWZPJemBJ?=
 =?us-ascii?Q?qb+1VLtriaG2QIo+ZG00HwVYr4zFP/AbVSt7iyhdibRAjHW2fa/kmUCm66fk?=
 =?us-ascii?Q?5E727VYfheL3Qx6cAmVOTFL0jkubG2x1xSxMz+OnRlJ6xLneckfgFE9BoEgO?=
 =?us-ascii?Q?tRtoVF+JhqB3LZbIxDsNBuBVss/+MqwCVgCRzXo7c+hsdI9t16H4xmbF90iz?=
 =?us-ascii?Q?DaICEQD5li7HNLdqtxhPVTD5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d397040-bd26-4ce1-36ab-08d97d4a1a7e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3573.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 21:52:27.8844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vk5gcy0fmwDxL/wk42KaXPhbY3Zrfvg7fyZB7TzmOFLMd0g+N4Chgd9z6QQ+9gAJRsEZHDVEayTRsOCjkHuPMBeJ9mYQNGx73bxveelnjxE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3892
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109200000
 definitions=main-2109210130
X-Proofpoint-GUID: pjOVjY-SmmBfgjk2gvmMmPVWclCC3rC4
X-Proofpoint-ORIG-GUID: pjOVjY-SmmBfgjk2gvmMmPVWclCC3rC4
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The following patches were made over Linus's tree but also apply over
Jens's 5.16 io_uring branch and Michaels' vhost/next branch.

This is version 2 of the patchset and should handle all the review
comments posted in V1 here:

https://lore.kernel.org/all/20210916212051.6918-1-michael.christie@oracle.com/

If I missed a comment, please let me know.

This patchset allows the vhost layer to do a copy_process on the thread
that does the VHOST_SET_OWNER ioctl like how io_uring does a copy_process
against its userspace app (Jens, the patches make create_io_thread more
generic so that's why you are cc'd). This allows the vhost layer's worker
threads to inherit cgroups, namespaces, address space, etc and this worker
thread will also be accounted for against that owner/parent process's
RLIMIT_NPROC limit.

If you are not familiar with qemu and vhost here is more detailed
problem description:

Qemu will create vhost devices in the kernel which perform network, SCSI,
etc IO and management operations from worker threads created by the
kthread API. Because the kthread API does a copy_process on the kthreadd
thread, the vhost layer has to use kthread_use_mm to access the Qemu
thread's memory and cgroup_attach_task_all to add itself to the Qemu
thread's cgroups.

The problem with this approach is that we then have to add new functions/
args/functionality for every thing we want to inherit. I started doing
that here:

https://lkml.org/lkml/2021/6/23/1233

for the RLIMIT_NPROC check, but it seems it might be easier to just
inherit everything from the beginning, becuase I'd need to do something
like that patch several times. For example, the current approach does not
support cgroups v2 so commands like virsh emulatorpin do not work. The
qemu process can go over its RLIMIT_NPROC. And for future vhost interfaces
where we export the vhost thread pid we will want the namespace info.

V2:
- Rename kernel_copy_process to kernel_worker.
- Instead of exporting functions, make kernel_worker() a proper
  function/API that does common work for the caller.
- Instead of adding new fields to kernel_clone_args for each option
  make it flag based similar to CLONE_*.
- Drop unused completion struct in vhost.
- Fix compile warnings by merging vhost cgroup cleanup patch and
  vhost conversion patch.