Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932901AbWLNUkr (ORCPT ); Thu, 14 Dec 2006 15:40:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932898AbWLNUkr (ORCPT ); Thu, 14 Dec 2006 15:40:47 -0500 Received: from codepoet.org ([166.70.99.138]:39385 "EHLO codepoet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932901AbWLNUkq (ORCPT ); Thu, 14 Dec 2006 15:40:46 -0500 Date: Thu, 14 Dec 2006 13:40:46 -0700 From: Erik Andersen To: Jeff Garzik Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] support HDIO_GET_IDENTITY in libata Message-ID: <20061214204046.GA2607@codepoet.org> Reply-To: andersen@codepoet.org Mail-Followup-To: andersen@codepoet.org, Jeff Garzik , linux-kernel@vger.kernel.org References: <200612141930.19797.s0348365@sms.ed.ac.uk> <4581AEA0.3040708@garzik.org> <20061214202608.GA2313@codepoet.org> <4581B4A2.8070006@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4581B4A2.8070006@garzik.org> X-No-Junk-Mail: I do not want to get *any* junk mail. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 20 On Thu Dec 14, 2006 at 03:31:30PM -0500, Jeff Garzik wrote: > Erik Andersen wrote: > >+ if (!atapi_enabled && dev->class == ATA_DEV_ATAPI) { > > This seems like an impossible condition? Hmm, suppose so. Do you think that simply doing: if (dev->class == ATA_DEV_ATAPI) { here would be sufficient? -Erik -- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/