Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp13991pxb; Tue, 21 Sep 2021 17:20:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDdBTW+XB+6K+7Sa1tfHq4FLJBNGJhOLLfjW/jJLo4w/SYZlxMrp4rEBPCJeqEb4GnW9fe X-Received: by 2002:a17:907:7e8f:: with SMTP id qb15mr13284492ejc.249.1632270057422; Tue, 21 Sep 2021 17:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632270057; cv=none; d=google.com; s=arc-20160816; b=r7j9DGk1M2nicnnDWOnKIk8YRAtakt8d2Fi6gMMbBGuYYf4mqGb8J0Lte6DZDi18QX iOodkM3IWATChOTtM76Dc+a2xAajg7mogx0stdDAH+U9W0gaOVMqOEUFOBoXQHng/2jT wj0Nj4xLTpgABtKjfS2D8hw8HO2xlSD4B9xJ93TxwTlCspS4YppDZdeq29nIOWEIFqjU LruhMX05PFB8TOxOjUdwJavOo8666aUg+ZqPtoR4aiGc86RQ7AFaxgIEUipR3Bq+oSnC D7F3RmaoxZRg4QqLMtV+hXGrV2rremChB6V4d7RevPeH7nWn2SFnCE8SJEwCCJaiiSdN ehkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NF/erRb1xvPiKeuz4vBloWnkjZnF25C64FmvspbwiEo=; b=wNtDb07s88bh0nbokQlO06vbmYc7z3cwZUnsFo1NuEp6w/v3kg4sgNdQmVvr36N068 oVZbuNKnbx9Jy2ZQxl3KTVameEznjjOOh4XpdnAcNwXhhD7DdZUj9NU2ipRrbQ/Ia/Fe f2IEjIyV6PrdnA2RwQGlsPfYNmE+5unQRYEds6Jjjx6ODMMOgi0BGct5khXc3JcFpZti CQG1VZF5bXX83O3lgoQLqYMnc3A4zlGrpCtZtexcZc+DJ6nWRRTUoUnRgqJ8mz2JANde wgtHozSUrmV4trBdik3uuHlsrCAA/29O1QkNa9cxgISxu6C9XNhEaMMze62eNKtrMC3k v64A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JYjh8ATX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si596903ejs.386.2021.09.21.17.20.26; Tue, 21 Sep 2021 17:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JYjh8ATX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232925AbhIUWjH (ORCPT + 99 others); Tue, 21 Sep 2021 18:39:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233725AbhIUWjG (ORCPT ); Tue, 21 Sep 2021 18:39:06 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8231CC061575 for ; Tue, 21 Sep 2021 15:37:34 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id w29so1064086wra.8 for ; Tue, 21 Sep 2021 15:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NF/erRb1xvPiKeuz4vBloWnkjZnF25C64FmvspbwiEo=; b=JYjh8ATXm2rsrUDRYndqccmq6DGYrm5G5oFK0PZXiGJoNKohaS1/MHXzIgY7DdAXpw bL4LKJHOwlXzBZjI4gZmIAtxO4OxYq2Su5L8Di4QO7DjVkyyBL9ArU39slEuMQnHItjY d9fqTTl6hRWixuueYxiVGwJm4aZg7d79t694owtoAdVY8UdbwDTw3HKt2+GerXIv9Vfc IM9z1BHJHHud/yTUA/IZBbib8s7DIEM7z8e74ulK65VduDRs3HHTlbat7RGYmBIkfJXc gvf4Bk+dyL2yC3udwwiFlF899jZ3k7UFinfilIFMRsx9yzoq0QFvbKqgeFjjteG+uAmv FLEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NF/erRb1xvPiKeuz4vBloWnkjZnF25C64FmvspbwiEo=; b=lNvhrwr+xKscExfI4t0jSLLif/ApzIICP8+bCJH/8RkfRiGq+7iVQQH+pVgi6jjnR7 as4LBweP4BfijuJ6DNd0ogNTeiZuxcmdv4tWUfK6Io7pMUvCUWbhMwsv0SUPJ3spnBl1 0zeLHFDXQ2oA0Q2P9L5EJrPk/jq4+qb5lycZdssGeHxrubYKJpuf4z2j1SQmccaJN3Pl JaeJj2yS1D39Z4EAYAc6cLwRbRpn6klMN9ZRSmlG0lw6YA9M6MFFkmxlQkpTSlWdAR1M IHkjkmoFHt2UQuJOEOVbt5hjq/1SaOTJGfys/PqEn0gR5WbkFhp+UTmjkHOycYrmvSRG ZkKQ== X-Gm-Message-State: AOAM531PBVGWjQB5+hNcadVcSFDVn78AIequf8d0v6wSkbLC6pmaM+D8 F8humiOZbz6Add0WtlK7f6rvJ96hcivYcpC9sNg= X-Received: by 2002:a05:600c:1d16:: with SMTP id l22mr5431621wms.101.1632263852964; Tue, 21 Sep 2021 15:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> In-Reply-To: From: Rob Clark Date: Tue, 21 Sep 2021 15:42:05 -0700 Message-ID: Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Doug Anderson , Laurent Pinchart , Maxime Ripard Cc: dri-devel , freedreno , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 3:20 PM Doug Anderson wrote: > > Hi, > > On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I don't see an obvious better way. > > > > v2: Remove error return with NO_CONNECTOR flag > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 39 ++++++++++++++++++++------- > > 1 file changed, 29 insertions(+), 10 deletions(-) > > This seems fine to me: > > Reviewed-by: Douglas Anderson > > ...if you would like me to apply patch #2 / #3 to drm-misc-next then > please yell. Thanks.. I think we can give it a few days for Laurent to have a look. This will conflict some with Maxime's bridge vs dsi-host ordering series.. not sure how close that one is to the finish line, but I can rebase either patch on top of the other depending on which order they are applied BR, -R