Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     hdanton@sina.com, hch@infradead.org, stefanha@redhat.com,
        jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V2 4/9] fork: add option to not clone or dup files
Date:   Tue, 21 Sep 2021 16:52:13 -0500
Message-Id: <20210921215218.89844-5-michael.christie@oracle.com>
In-Reply-To: <20210921215218.89844-1-michael.christie@oracle.com>
References: <20210921215218.89844-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/HHjmEW4e6QMHl0tfu0ScS7ASz+saGWsbFMVcQlpRtTy3r/v4h0V4vo9FZzX?=
 =?us-ascii?Q?T56zG+qmgDBC9Wj/SWXXxEg4KSYlHUO+pRA8sWRrZhl/wfK+6in6STbRSo+y?=
 =?us-ascii?Q?wiKzJ5JAfRgwz38wayS8OWNTqFbbwDvBsrgVnY6cJ8fCicC2/01y6sI0qWXT?=
 =?us-ascii?Q?fNnJZiDv5hGu6Pdt6HCrzb6S4RgbutaqHrPB7SmCK3eonW/fHofilZ6dr7Po?=
 =?us-ascii?Q?UPC2V8x+ut6WUqrracgV/HAl/3QoMhQ6EAISjJj7megHpGKPfu3PqeYrj6V8?=
 =?us-ascii?Q?n0yvTGQrpQizZxgXyCXM3Ll0ywrb2TgLj6C1T7xl3/PVG2nJqxlV3tGwV/xZ?=
 =?us-ascii?Q?T0fUeh6dz4oWSmrRcQmNNomfFQHYw6bCvb5D1qzb2hl75WJbUNE6jgHovLaQ?=
 =?us-ascii?Q?GFtSgnekzmrab+amHoapUh8N6sG3+8V/A+CikShWIqW1lmYsPWxgVW+EkhQT?=
 =?us-ascii?Q?VHniUFxWqT0Jq1qV3i7dAxcOsjiXpY4acg08uNsF1MNMuR+ykqZmmRRSVjeq?=
 =?us-ascii?Q?RZJaW4puATb0SYnAvrorLeod8SNYwQy++wphZGdMkfY+hc1aD5unlt74Tqry?=
 =?us-ascii?Q?jU2JgHCL3SXRqFlme5cndFZreVGKLhYs2eLFPv2HUXbtFRjt4woFhnyFBukB?=
 =?us-ascii?Q?g0bMpzI7U4km2sq6yoBEbcpvZLCgxuAjTjZyRACNBVZBharTv2aDujW0xTE4?=
 =?us-ascii?Q?OL4IPao5I7rqKUYP3JrJf4U7Z2kpvWcnkpLJv4mzJVG7YLEyQM6b+pXi9LWg?=
 =?us-ascii?Q?vIPXcxr1Y1AZHyftsVYKbUm67cLz03OVmKuj8xaAM9KGtdTuJsdce2Hpy+8t?=
 =?us-ascii?Q?/CE950xuvGe/MdI3yrVNzFxzdZxuI/rJkCOXXDz/Wu16rRTh125Wdg6b5kU1?=
 =?us-ascii?Q?MImkByWDSV5sBIS/rfgV/wPgJAr/vUlo4J709oFJz4M3VrAFL/MD3icEW3hk?=
 =?us-ascii?Q?cexmvOfsJK6iedrC8eg5Lgoh3ots+nVaBL9JPMNetBK4pINDzPIoGwynJRIL?=
 =?us-ascii?Q?4mmZt0FjTaaSvQfHXZWjhvLy1BYeZ2cKqvofiIp/llRkoKY3NL5V+ZEQa8Yg?=
 =?us-ascii?Q?oqWEEo53aedlb1Ci8jd5Q6x6ttkWu57N30VGos8a4NMwLAtevlydFAKvnCdZ?=
 =?us-ascii?Q?vQzjb38fwYpFwqUeMuk6VclQ12t/D/iXHoPea5gHbvUItii0VaPR9WAJAcIA?=
 =?us-ascii?Q?meKoITrPLFNsGbq/WAfUXPscbL7VzowTvlDDveLRJvuPJOFhAW7nzZdQ2A2Q?=
 =?us-ascii?Q?H22Q6bshPdKIh7DuIsumbio61UwdH5EfYpBPMmCqsIAKYjbA5SxkXlzlKH5c?=
 =?us-ascii?Q?ygXdb641is6ZAORwH6HgIz5+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 522ab1ab-8f8b-4131-662d-08d97d4a1dc0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3573.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 21:52:33.1525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tmCIvL0nysQSH7Mc9Yuwp+XTMXac8gMMoI1Y5jgtpo/QKWP04hpChtCSseKFucSvri1FFMnyjzaNxwtaorjDiInhpIMS+VYpN3YQbsWcQXo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3892
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109200000 definitions=main-2109210130
X-Proofpoint-GUID: sjf9ewVuIzLs4ohUMjrlSPh_dOHpDvgp
X-Proofpoint-ORIG-GUID: sjf9ewVuIzLs4ohUMjrlSPh_dOHpDvgp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it calls the kernel_worker() function added in
the next patch we can't dup or clone the parent's files/FDS because it would
do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index cf7c9fffc839..e165cc67fd3c 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
+#define KERN_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 4b0e8257993b..98264cf1d6a6 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1532,7 +1532,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1544,6 +1545,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2179,7 +2185,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & KERN_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1