Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     hdanton@sina.com, hch@infradead.org, stefanha@redhat.com,
        jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V2 7/9] fork: Add worker flag to ignore signals
Date:   Tue, 21 Sep 2021 16:52:16 -0500
Message-Id: <20210921215218.89844-8-michael.christie@oracle.com>
In-Reply-To: <20210921215218.89844-1-michael.christie@oracle.com>
References: <20210921215218.89844-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2q0o6LRmwFRnNC4Plpi8e/waG5p1SGHVCjEvVhUL39aRj7jCgZF5x3JEJuX5?=
 =?us-ascii?Q?UUviUMlo7Z/rOER1Q1TQZJmRludlF9gEMw4WV2ATBmqq49gbxjKH6CM6J8v2?=
 =?us-ascii?Q?yqDLsC5GAXCoqyWSQ25hCqi9Xh2E5aaX5jeGLUbNnm7gsJ8Ww7Sayvt88rZH?=
 =?us-ascii?Q?6yIap+sRGp9P9N5Ni8Lf0hlRJK5U52URMXfP/KRLB6fgNHymoR3kl+hdWIjL?=
 =?us-ascii?Q?ZS2d0BqCvob7VJasNoXec+H4Lq9GpjBYM34Fbd7YdCMegN+2qBeVOHsgDbPp?=
 =?us-ascii?Q?YVU9QkgBkf6T1/6PKvV86LYlmCCttrsVAkwqQtlXHlS20NsNcvmPWl+xwTXX?=
 =?us-ascii?Q?x+/Q+zpcb5Tr1UEVxpk3mlcNbzUsGXdDysQBvbz4QEXjom4xKmfEL+NAPZz3?=
 =?us-ascii?Q?v9Wo+Zo3JUgyc3/pJkYAgXLm8vZF7blojNoBPeh5ilmUvF+PWQhcpB5NG1Ol?=
 =?us-ascii?Q?ESYw5cTm1X8tYdqQlcWPTLHCs/GdKi7FilwO2fvAOk/PHmqfhJrZ5m5OQbDZ?=
 =?us-ascii?Q?xwc0ld6jsz9dKeNgbE37TMeRMG3m8HxQkVNv6/2CvRFZVvAZNWi+Vro9JAU1?=
 =?us-ascii?Q?mI+faUEkpmtf8lq+jeg3HEzYvNXMEdfhld3w+UVli1krN/8wrgJ3uueiJuY9?=
 =?us-ascii?Q?AAMRUVgCbcLmPkfRd9okLnY0OnFkrmbYlFMdzwJV95wkv3Gd3hhF9aBqJlKo?=
 =?us-ascii?Q?mfMQLBwztDeDVOo3uu0AFYel2UZCNbHmXDPRS+O+9l1A2trYVZDON28upabE?=
 =?us-ascii?Q?IosCekWCUb2X2x+fHyWhgdptcmXHzK4oq4qyj56pLCTzroLI+zkeno2/YYwU?=
 =?us-ascii?Q?D6rtvEbf8c4WKEsezwR5qe0h/ERL5L0/mIOGGVC9P6d5/qYrZk02f3avJb/u?=
 =?us-ascii?Q?OxZjdxRCMEX0lCoQCQuJZqizfT4xHhpGt9N8l43BAAVrZNwjh581rAXkP2Sq?=
 =?us-ascii?Q?23VHLUAQ/IX6ZaPBtQIQ/KNoYGbohyk7lO3j1HR3IGZLwsQhj4ykE1YwqOgr?=
 =?us-ascii?Q?CRKiuzdHI/We5Zib4Tp+jO/t4tNVPve3z2JFpptL6uBXK/x8ZhtrA7ZgIiKp?=
 =?us-ascii?Q?iSUQQfWnx/qBfvxlTzi4SxLdyH5AbGUR6RUq2UMBZnqs5S16ffWvRDSyUU38?=
 =?us-ascii?Q?GpgOsTIufbUuvANM/bWc8AXceMVEjo2iEeQwkfAVfnMjUiUOGP9rYNokZekZ?=
 =?us-ascii?Q?t81/XKz657VGB+Y2xVvjh/j9sf66KQuvIspvVmh9SEmyCkbh15Gy4SgfYTMa?=
 =?us-ascii?Q?l0kj3pzZGI5RphePKtFzLJBWIXt5gkMKc2mjYk4z+Z6uibd9J3cWngKBDcDK?=
 =?us-ascii?Q?MmCneg3zL0XspuO7RCGP0NX/?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab9fa80-bcd3-459c-92e1-08d97d4a1fec
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3573.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 21:52:36.9193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hknvO3w9Ef9ncloGkp4LnDbWoSRb7YOr0J7T5CzxFvzkgilCTm6URpa1Q5F96y9KlgOv9ceFflO3ndoTCEqtrUUQJhgfFVh/Qafwy10Z+s4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3892
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109200000 definitions=main-2109210130
X-Proofpoint-GUID: ScSa0IasIgTPEicWTT23PUXIOOqT232b
X-Proofpoint-ORIG-GUID: ScSa0IasIgTPEicWTT23PUXIOOqT232b
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The kthread API creates threads that ignore all signals by default so
modules like vhost that will move from that API to kernel_worker will
not be expecting them. This patch adds a worker flag that tells
kernel_worker to setup the task to ignore signals.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 781abbc1c288..aefa0d221b57 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -21,6 +21,7 @@ struct css_set;
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
 #define KERN_WORKER_NO_FILES	BIT(2)
+#define KERN_WORKER_NO_SIGS	BIT(3)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 3f3fcabffa5f..34d3dca70cfb 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2555,6 +2555,8 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
 struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
 				  unsigned long clone_flags, u32 worker_flags)
 {
+	struct task_struct *tsk;
+
 	struct kernel_clone_args args = {
 		.flags		= ((lower_32_bits(clone_flags) | CLONE_VM |
 				   CLONE_UNTRACED) & ~CSIGNAL),
@@ -2564,7 +2566,14 @@ struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node,
 		.worker_flags	= KERN_WORKER_USER | worker_flags,
 	};
 
-	return copy_process(NULL, 0, node, &args);
+	tsk = copy_process(NULL, 0, node, &args);
+	if (IS_ERR(tsk))
+		return tsk;
+
+	if (worker_flags & KERN_WORKER_NO_SIGS)
+		ignore_signals(tsk);
+
+	return tsk;
 }
 EXPORT_SYMBOL_GPL(kernel_worker);
 
-- 
2.25.1