Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp75641pxb; Tue, 21 Sep 2021 19:13:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk3XrSy2yXj7HEiwv2GMHSawpl6QvzpaTKS9jriWGEt7oO2652D+9we4+y85E0J8qXRFWA X-Received: by 2002:a05:6e02:1aa2:: with SMTP id l2mr22387791ilv.179.1632276782825; Tue, 21 Sep 2021 19:13:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632276782; cv=none; d=google.com; s=arc-20160816; b=vH9e3oB6mYucRXiJEtuL7OPmWjhRzWWPIf1WH7UiM+Gx7lsmpXxsM+4jAMvUKb51pw 6agtSlvDUfokeKVrsdlo4hwC75R+s6S6OL3sXhjAKNd+a05i4xYlPin2bEuNl3z9HGiy f+U8MFo2K445C87+ys6PvGUyrC1iksB08pJ/74EYgV8pwU25UNm/EcGELm4ZOl9Ip57z FKwRnjgidKp8F+Iceof3HZGFQI03Cq7fydSM1VlNn83xz+jh8RueoKYVvXZoEMGWkj6o gKMQ7bTU/BjhBP7MVdhdacfCoThPaOlpRGJXuTCzwfTjX/rvqPxmQexd5pZOgWw+wgCu VUPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from; bh=GP6yRnjRDGNOBKo1SoxWUV9a8fUbWes5bZ7cw6YKfEo=; b=PvylDldcgWEyCQpZCxfRBkOpTN6wQAQz92E/eQRBI3ihYbFHArC3xyG37tlp3ziLxk X7u6hW5sSJ7/gMTYxu6VK8Y5PsQwIjbt8jVkSY/88rpZrHStK2g+9DzBKF8krnurqJuX H9Tzj9iaryf+tTSQhRiuMAcC+KGg5Xf2O4gkza5zzjNeBNMbYHfpwIOKokz4iNknWZcO miap5KYdpwyGxZZ1XP6peV66G+u5q3TfsWslGknGrb9CkWH1ti2CX9DbAgw7qTzRo7DE zC7xZZ8DUzKjU+nq5TDfYrTy3ehMe2Xt3YmNnAf85Cl7jlf8i/5u1QSSh9YWJQfhfdGH rlkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 205si800446ioc.95.2021.09.21.19.12.50; Tue, 21 Sep 2021 19:13:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbhIVCIp (ORCPT + 99 others); Tue, 21 Sep 2021 22:08:45 -0400 Received: from mga04.intel.com ([192.55.52.120]:17863 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbhIVCIo (ORCPT ); Tue, 21 Sep 2021 22:08:44 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="221613768" X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="221613768" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 19:07:15 -0700 X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="474388035" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 19:07:12 -0700 From: "Huang, Ying" To: John Hubbard Cc: Weizhao Ouyang , Andrew Morton , , , Anshuman Khandual , Michal Hocko , Pavel Tatashin , Yang Shi , Zi Yan , Dave Hansen , Minchan Kim , Mina Almasry , "Matthew Wilcox (Oracle)" , Oscar Salvador , Wei Xu Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names References: <20210921064553.293905-1-o451686892@gmail.com> <20210921064553.293905-3-o451686892@gmail.com> <87mto676fq.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ee9i6n1w.fsf@yhuang6-desk2.ccr.corp.intel.com> <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com> Date: Wed, 22 Sep 2021 10:07:10 +0800 In-Reply-To: <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com> (John Hubbard's message of "Tue, 21 Sep 2021 11:00:04 -0700") Message-ID: <87y27p5po1.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org John Hubbard writes: > On 9/21/21 07:06, Huang, Ying wrote: > ... >>>> Can we add BUILD_BUG_ON() somewhere to capture at least some >>>> synchronization issue? >>> >>> Hi Huang, we discussed this in the v1 thread with you and John, seems you >>> missed it. Now we just add a comment to do the synchronization, and we can >>> figure out a more general way to use strings which in trace_events straight. >> Got it! And I think we can add the BUILD_BUG_ON() now and delete it >> when we have a better solution to deal with that. But if you can work >> out a better solution quickly, that's fine to ignore this. >> > > I have a solution now, it's basically what I sent earlier. There appears to be > some confusion about it. I'll send it out as a patch that builds on top of > these two, hopefully in a few hours, if no problems pop up during testing. Sorry, I didn't read your latest email. The solution looks good! Thanks! Best Regards, Huang, Ying