Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>, "Liu, Yi L" <yi.l.liu@intel.com>
CC:     "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "hch@lst.de" <hch@lst.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "parav@mellanox.com" <parav@mellanox.com>,
        "lkml@metux.net" <lkml@metux.net>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "lushenming@huawei.com" <lushenming@huawei.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "yi.l.liu@linux.intel.com" <yi.l.liu@linux.intel.com>,
        "Tian, Jun J" <jun.j.tian@intel.com>, "Wu, Hao" <hao.wu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>
Subject: RE: [RFC 10/20] iommu/iommufd: Add IOMMU_DEVICE_GET_INFO
Thread-Topic: [RFC 10/20] iommu/iommufd: Add IOMMU_DEVICE_GET_INFO
Thread-Index: AQHXrSGNbNtRgavabUSKJjvt8l12BauuxV6AgACjuTA=
Date:   Wed, 22 Sep 2021 03:30:09 +0000
Message-ID: <BN9PR11MB5433D26EFA94F59756AF91838CA29@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <20210919063848.1476776-1-yi.l.liu@intel.com>
 <20210919063848.1476776-11-yi.l.liu@intel.com>
 <20210921174049.GV327412@nvidia.com>
In-Reply-To: <20210921174049.GV327412@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bIWx2Fj+vJq4uHtU+XMkYzJcZwipjwqqd3+gkYeZCk+Ct6X8I7LYvaayJ8IL?=
 =?us-ascii?Q?6naTFp0CYFnSHWDZnBUNa7wC1/+EWaWtjnooSIO8GOp5tA7McBeJAHaLloA9?=
 =?us-ascii?Q?IMlJqa/qkQYFdwOqHR0C15PDkJBLPhOklklG7YtlpOuPCP9KlgGBtfaatimC?=
 =?us-ascii?Q?FKK2MYTKrG02rEO18EoNGcpfQlRBC7Hnu6+SclHV51KL8Sed02r6yqKB2YV0?=
 =?us-ascii?Q?mqW3Yfg8xfaht/XHtYDzRJF+87mgnFEor0+U7wpt3DgpgoCiGUeWOoPq2r6C?=
 =?us-ascii?Q?qh3xGnl4QNvrQwvvhwwB+hFb55ds/5Ea6IGIsQwzElOAc9lLoCsswD5dHNQF?=
 =?us-ascii?Q?7JA2GOm/6sBFaN9zrloMJ6wVsOiE8okX/sqLYqL+asVafa2T3IpmpbfN3Irm?=
 =?us-ascii?Q?4KiaZQrgfTJ9W6oyjKk0thUw7JN1zDP2GaEY81VmJjSkRpMev3TgguVNDMjb?=
 =?us-ascii?Q?6Up+CaEY+ZV+NATt8pw330M47NrgTAmgI+bRD8uBUn8hecelSNaUnXv6mm1+?=
 =?us-ascii?Q?RuLfr5bz6YlEXMjJmN2uG9SqWka5RVMNSygggF1QMtr2uVXiGLpvTP7iV7xA?=
 =?us-ascii?Q?HvkZQtNIxSL65KG9YfAXx3wT9VXJywyq/8XsLzlp03IAhVi7Z3LOPWptjuNf?=
 =?us-ascii?Q?lTRuOTW2A/bWIH25hj8uK9qY4vzWTehg6QT0TTnQX0ugxVDTP4cRjbfqhcXy?=
 =?us-ascii?Q?CpQVZpsJUAAiywm56M6xSNymGsYcNfdHNQg37Ysr3pOVFRohecd2ABp/5oG1?=
 =?us-ascii?Q?qw4+9Jzvl3622Te+EN02AMuZVQbiBhhYety2Zg08h7eqBKswygsZgFA9x1I0?=
 =?us-ascii?Q?dYfJHYozZfcP6d8orqvyln4sMIZZk+Cqa2yogsOxW/RDX/h90VEkzzOP3j/V?=
 =?us-ascii?Q?D/Zpz+wUaS/fulbtrvIlKSPz7In0VRhWFR5guKTyY+95LwPVJnT9Dyck4sS3?=
 =?us-ascii?Q?v94qU6SvktVGVO1mLnxr8b28G0GGKUiKOQn9ZT+NYP+S+xbVvuZRsuvfc+a+?=
 =?us-ascii?Q?C5m2S5iNUjGGNzAloUc62oA6LyQYyFXfZuWJJjq3vfDdu07vMsXzGiYoO/FO?=
 =?us-ascii?Q?ntBzKpAtzT/AVsEi2DcJr+XvMgRgVy3AXNRUx5+4FiDK+3s4nfB19E3K/ZG2?=
 =?us-ascii?Q?Kvf5Zg5uqXeKjiXNkrv7aqwPF3UcMMZThQ83a1WbuTNMeaJqNQnoWyxsRxHy?=
 =?us-ascii?Q?g9JqXBAkCQOdsPrtyb3BG7Ay9jQuWs0MIWPqUDMynK2l5w9VTv3cyd24zoIR?=
 =?us-ascii?Q?6DEePVF4iw3+or14BsHNh/e4PHsZbiRbNpKU5A/tyw3phG4nLl6Xu4cAQQxw?=
 =?us-ascii?Q?GLgmG+WHQnju6Syfe6O8Tzfe?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be18adb7-855f-461b-eff8-08d97d7947c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 03:30:09.6605
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y1tvT+ISiHwyeSlZSMnDCvF2SVuBCQGvErenYZFsjCWIXDbZGrBwauvqDb6nje7bPqxtw/GndhvKvtG2aHgPwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5757
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, September 22, 2021 1:41 AM
>=20
> On Sun, Sep 19, 2021 at 02:38:38PM +0800, Liu Yi L wrote:
> > After a device is bound to the iommufd, userspace can use this interfac=
e
> > to query the underlying iommu capability and format info for this devic=
e.
> > Based on this information the user then creates I/O address space in a
> > compatible format with the to-be-attached devices.
> >
> > Device cookie which is registered at binding time is used to mark the
> > device which is being queried here.
> >
> > Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
> >  drivers/iommu/iommufd/iommufd.c | 68
> +++++++++++++++++++++++++++++++++
> >  include/uapi/linux/iommu.h      | 49 ++++++++++++++++++++++++
> >  2 files changed, 117 insertions(+)
> >
> > diff --git a/drivers/iommu/iommufd/iommufd.c
> b/drivers/iommu/iommufd/iommufd.c
> > index e16ca21e4534..641f199f2d41 100644
> > +++ b/drivers/iommu/iommufd/iommufd.c
> > @@ -117,6 +117,71 @@ static int iommufd_fops_release(struct inode
> *inode, struct file *filep)
> >  	return 0;
> >  }
> >
> > +static struct device *
> > +iommu_find_device_from_cookie(struct iommufd_ctx *ictx, u64
> dev_cookie)
> > +{
>=20
> We have an xarray ID for the device, why are we allowing userspace to
> use the dev_cookie as input?
>=20
> Userspace should always pass in the ID. The only place dev_cookie
> should appear is if the kernel generates an event back to
> userspace. Then the kernel should return both the ID and the
> dev_cookie in the event to allow userspace to correlate it.
>=20

A little background.

In earlier design proposal we discussed two options. One is to return
an kernel-allocated ID (label) to userspace. The other is to have user
register a cookie and use it in iommufd uAPI. At that time the two
options were discussed exclusively and the cookie one is preferred.

Now you instead recommended a mixed option. We can follow it for
sure if nobody objects.

Thanks
Kevin