Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
        suzuki.poulose@arm.com, Will Deacon <will@kernel.org>,
        linux-kernel@vger.kernel.org
References: <1632130171-472-1-git-send-email-anshuman.khandual@arm.com>
 <YUirurhvmBPCOsS+@arm.com>
From:   Anshuman Khandual <anshuman.khandual@arm.com>
Message-ID: <127b2334-5c40-1b71-e510-ac837c3ac614@arm.com>
Date:   Wed, 22 Sep 2021 10:14:42 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YUirurhvmBPCOsS+@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/20/21 9:11 PM, Catalin Marinas wrote:
> On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
>> Section mapping at PUD level is supported only on 4K pages and currently it
>> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
>> new helper pud_sect_supported() for this purpose, which particularly cleans
>> up the HugeTLB code path. It updates relevant switch statements with checks
>> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
>> identical switch case values in those code blocks.
>>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Suggested-by: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> 
> Assuming that you tested the corresponding configurations,

Right, I did test this on all page size and VA bits configurations
, including the specific ones which were problematic.

> 
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
>