Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     michael.christie@oracle.com, lduncan@suse.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ding Hui <dinghui@sangfor.com.cn>, jejb@linux.ibm.com,
        open-iscsi@googlegroups.com, cleech@redhat.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session_setup()
Date:   Wed, 22 Sep 2021 00:45:16 -0400
Message-Id: <163228527477.25516.7622823180692115909.b4-ty@oracle.com>
In-Reply-To: <20210911135159.20543-1-dinghui@sangfor.com.cn>
References: <20210911135159.20543-1-dinghui@sangfor.com.cn>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nmt6RXB6RDB0NHpiNkd1c1VHQjU4Vzh1MldhL0pxeXk2MlBTT1pmSmRUMU1i?=
 =?utf-8?B?OXliNVN6S2JtWUFvTjhtUzF0dDhabndrNjBlVzd5TzAzY2dYU2lKZ3cva2lh?=
 =?utf-8?B?d3hxb2hUOWp5MUM3cXZQTWp4K0N5UVpXVmlnRld4bnNLcUxsTTFCQm9xSGda?=
 =?utf-8?B?R29jNllaVExqZGx2T2NrRGRDdm5JWUdDMjl1aWE4OW1GbTdyc25RdzNqZjVI?=
 =?utf-8?B?bWFUTHBzb3drMG1Rc1diWWJseEQrUXdXOEdiWHpNYk1ESGd2Z3VNa01Bdy9t?=
 =?utf-8?B?K1R4ZHBxc2ZoUGhDdHMzQVZKbTgrbzFpV2NQd2RXeldsK0k4Nk54d0dBSW9N?=
 =?utf-8?B?UlBvVmZ6bUtDb29MWXJoK2grYXhpanh0OWo5S2p0aDVrckdKdjhiSmQvNE8y?=
 =?utf-8?B?d0k2cXJISU5NUXJmYUNnWVNzL3AvU0p2T3Vrc0lOaHF5czRFMUhWWXdyTmxZ?=
 =?utf-8?B?ZWMrdnpRdHRCRkdzTlhwWG9MblpGaFU3eGl3dk50emVUOFdQNFk1WGJkOXBB?=
 =?utf-8?B?Y1R6eUUvWkhKRzJLOE5DK1M5MG91aFdHSlY2NTVYYU40WUdOakZiVWhXL21J?=
 =?utf-8?B?SUxFN000d2s5bmE0ajUxeDlmTlp3cW5ZRkxLMWtnQXZsUThVNnhjTGR1SW8w?=
 =?utf-8?B?WTlXSzR5VEtBUkdtRTJHRU0yUUJURjhSOUZNc3JHTC9BSVJ6N1gzc3ZqUml5?=
 =?utf-8?B?ZTJUTWtvMm1hU3ZKNVFNNVBtTTA1SEdBZkNLOERHREFZLy81bFVSaVIwN2pR?=
 =?utf-8?B?VWZuYXorWlhUTklqd2hEbzBlU2lob2ZwYXFob3FyenlmcGo5YmpwbkNHcllo?=
 =?utf-8?B?VmRkb0JyelVHVks2U2VMa28wdHFQY3lpVXIvMkNzby9zcDU2dW8reVhrMVp0?=
 =?utf-8?B?VkxZSXVvTVlwbkNCN0p1bXlmaUpNc0hLajA0NDNiTEM3NWVISERacVdsVWZW?=
 =?utf-8?B?dlNtTitLVEdYWkJ0Y1NVWStaTm1XLzNFRDFuTG1KeFkvakxQSThpY2JWckU2?=
 =?utf-8?B?Z0VyV3o4Wlhpelp4c3NtbUJpWFJYL0dOUVdOL2pXS3VocjUreDRxUEplazdT?=
 =?utf-8?B?czVZNmxvR291NmRXcHM3cVIwM1FUYWxRNGxnWlJrM2lEZ2ZTbHl2TW1SNWxn?=
 =?utf-8?B?Uko1SEJOZVZ4SkpxcUY3a2d1K1ErczZPckQ1cmI3Y3pHZkZoOC9mR0ErNndr?=
 =?utf-8?B?V2dESFpvREVVakhjNlc3QTVaRERwa3lVK0pNVDdhYWFBMHN4SGg4cTE1b0Vq?=
 =?utf-8?B?MUJ6RXpLTUtXNFBlZm51SGMycy9EOENrbmx3ZWlyd2RrRlJld0lCYnhrdmpv?=
 =?utf-8?B?eG9GMkY3cW01L3JFTVFrUzlGU1l6R1B1THZWRXNDa051WDFLYmQyNTdrRmZG?=
 =?utf-8?B?eGdFcWd6cTkrVUtyNGhnN1FiZ3hZOEF1cmhjNVRSZHFJNlV6TXA2UFdMV3Ri?=
 =?utf-8?B?VjFKT2RMREpRQ2VINEdMSEEwWWhLZFVXMEowT0ttMDFwVHl1SkxUOTE2by9D?=
 =?utf-8?B?V0Y5ZmcvamEzamVYVzdrcWp2Z1kycnJobFFHaXVGcFRuREsxOEdObDVQS2tl?=
 =?utf-8?B?bWdhb1pRYnd0YzVKWTRYQy9lZnZSVEdMZ2NJNVlOL29UQWFTbVREVnE5QTJ3?=
 =?utf-8?B?QTJoK2d6d25pc1RhemR2YzJER3ZqNVordUpvM25aZXQzWmxYNnpYcHBlbmww?=
 =?utf-8?B?RWtzYjI5aUJ6QzhoOENXNHZkSEdLRjBxeVhTS2JGaEdROVBobXFHNkZwK1dl?=
 =?utf-8?Q?ax4jLFxCamK6YNt0TtRRgkgb44SGqV6HRc/W9Jo?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6671952-573a-4e8c-20e8-08d97d83cef8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 04:45:32.0831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5KYxnPouf8HThtyVePGJL+QMs3cqKYV+BpdXI3BrXq+T3IaQS/9dO1YK4cPO2B6Y3jXTf1sqwCN3E0i81DFSNKjomOiPh0ZjDGIOgoZpJlc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4456
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109200000 definitions=main-2109220030
X-Proofpoint-GUID: XqUki1mhjEZaTSubAMjBbZmVMNbDPLVf
X-Proofpoint-ORIG-GUID: XqUki1mhjEZaTSubAMjBbZmVMNbDPLVf
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 11 Sep 2021 21:51:59 +0800, Ding Hui wrote:

> The commit ec29d0ac29be ("scsi: iscsi: Fix conn use after free during
> resets") move member ehwait from conn to session, but left init ehwait
> in iscsi_conn_setup().
> 
> Although a session can only have 1 conn currently, it is better to
> do init ehwait in iscsi_session_setup() to prevent reinit by mistake,
> also in case we can handle multiple conns in the future.
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: libiscsi: move init ehwait to iscsi_session_setup()
      https://git.kernel.org/mkp/scsi/c/e018f03d6ccb

-- 
Martin K. Petersen	Oracle Linux Engineering