Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <35ba1b41-507a-a178-b81f-9d7305726b9f@nvidia.com>
Date:   Tue, 21 Sep 2021 21:49:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to
 migrate_reason_names
Content-Language: en-US
To:     Weizhao Ouyang <o451686892@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        Michal Hocko <mhocko@suse.com>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        Yang Shi <yang.shi@linux.alibaba.com>, Zi Yan <ziy@nvidia.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Minchan Kim <minchan@kernel.org>,
        Mina Almasry <almasrymina@google.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        "Huang, Ying" <ying.huang@intel.com>,
        Oscar Salvador <osalvador@suse.de>, Wei Xu <weixugc@google.com>
References: <20210921064553.293905-1-o451686892@gmail.com>
 <20210921064553.293905-3-o451686892@gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20210921064553.293905-3-o451686892@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDhHZVgyTWNNV2FOejVPYm55V2dHaThtUUdjTURVYjFXSXNUbks5VjVSSUVL?=
 =?utf-8?B?ZmkrcHhJUFVjM2Jpd3ZHbDJTdTdiSDh6a0JWQ2tmVGJxZTAvRGN6bVVpZW9B?=
 =?utf-8?B?VWtKRzVqQW1XWWNPVGJrRFdIMy9XS2Jvc0QvVWxWVnhKQ0FWWXNtaWVDeW1K?=
 =?utf-8?B?bC9WTVJweXpvRzcram5yZkltUE1rc2lNVEtIRkxGU0xCdWZCdmIyMVB3ZzlE?=
 =?utf-8?B?TWJaUWFJY25ta0RFc2l0K2JFeHhmb05IMm4yc0JFZVdheG4xUkd4d1F5dGVv?=
 =?utf-8?B?a2oxeElsYzR2UkVoaTl1OEtSSUdlWUhIM2FvU0ZENjR2VWRXVVkwZE9MRnZK?=
 =?utf-8?B?bGFtQm5OdHZnZERubHNqVVNaR2VKVEdOWHU4TUlSRWh3aVhvKzZGdXNpVVFQ?=
 =?utf-8?B?dlRJSEo3OTc5RHZVVU8vY09SeUpHZ3lwVWsyc3FJVm95ZU5yK3ZoaGF2czBZ?=
 =?utf-8?B?Y0pzQ0RWM2J3am84U0lwMHp3aVVCclU2akhna3I1U0xlZFVwUWROTUJxczFj?=
 =?utf-8?B?T0t0UjY2NEtTczNJTjI4aUFWTjBldFNlUllEQXljblh5ZkdZcjBLY1JLcGxy?=
 =?utf-8?B?SVFsSCtteFNJL1gzNVB3Z05TdVdIaFNMZEJOUGUvYldkWEhDMWVySmNxSEtx?=
 =?utf-8?B?dHJZaHphQ05FeHdnSkZrcENXOGoxUE5NMDg0ZHZSSmNzV2RvbEJ4VmlwMXZX?=
 =?utf-8?B?eXVSMHo0UEMvWkhiU2xlMHB1UVdTdFpmTnFZSGdDY3FzS2p1OEdZK3dzTjk3?=
 =?utf-8?B?WTNXUlBTZE5YNFA1dHZuTGxXWDF6VmJFREg0VjR5Ukwya1E5ZTc5ZVZlNjRX?=
 =?utf-8?B?QU9kTXlqRk0yZGZSV3RrbnQxZ0kva3BqaW52YjhKUjRCMEZxTVdsMml3Y3Rj?=
 =?utf-8?B?ekJ0MWlHTEJjY2lBd1hxdEYvd1BGbjlac0VDelFaM09TMDhVNWxCc3Y4RlEy?=
 =?utf-8?B?T0ZySGNuTHFhbGNNRXR3alVuSGRYMVFZTkd0ZE96OEozRFgvZSt4UWpmL2Uy?=
 =?utf-8?B?SDk2eXhWVkh6NUpnWms0MVd3ZDJXTXpJUDZucE4yTWtOaTdNY2Z6OHdFZDBC?=
 =?utf-8?B?bmlTakpaVkwzK2twdDBLak5iS2orcW1DRUFOS0tIdjE3UVpTdllSVHdIdE1o?=
 =?utf-8?B?Z0VDaENvd0JIUE8vd2taVDF2eFoyZitSRDUvSFM1QmZESEwzR0xrN09MY1JS?=
 =?utf-8?B?VUZ6ZHgyL3JOeDBjODhkYlJUaXRWVG90cDZjcHFWRjBBTHgrOXNYMEs1UjNZ?=
 =?utf-8?B?Y0Y2cHg1cDEvMEhJVFEvZUJmMGNSdGZwaGhGbnFOdloxYUFaZU9BT1RkZExy?=
 =?utf-8?B?WGo3KzhoQ1ZGVUVyUHlpaE84M0piK1VjYUovMjJwcHN4UjJrM2VjVFlvdXQ0?=
 =?utf-8?B?STZUYm1JZlZzMCtRc1lSa3Qzd0lsdzJ5dWFDS0d4MHFXcVAvVEJ4cVBFeVU4?=
 =?utf-8?B?MWpKNnErT2VQYTVFeVEzYzBlYTU1V3UrbUhZYjhaUTgrN05nZVBsRWtJd2FU?=
 =?utf-8?B?RnRkRzRHc21Wck54MzJGMTg1a1VJUFpDeTQxMnRBK3kxZG9saEp1eVdrdFNS?=
 =?utf-8?B?cFRFcmRmNFlXNnQ4QVQwSGJzUjR6QVpMRXUwby9ZTERCNXZGYXRoUlNJeC8y?=
 =?utf-8?B?ZDVnVlkwc3A0Q091UzNjMzFoS3RvQmVQVHZoK1dTUzQ0SmxmZFlyRzJXb3lM?=
 =?utf-8?B?VWlRRVdJem5ycDFqT0crR0srWjhnK2pZc0R1OVN0Tzd4N2tySFNUdXAzUnlO?=
 =?utf-8?Q?oHLr2eeA8KR55LoqC/HEXnlBFkgoeWeXMeidAbV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99d782ba-e560-4011-eb55-08d97d844f1b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 04:49:06.7334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q77PhCoSBKupBHEKm5xSzHaAAeU0Hz2rvnGdAqVnXdUcB3YoRb0FL+k1TSNNoS+s0i7ctbwHCXd28iPJpGbYYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3192
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/20/21 23:45, Weizhao Ouyang wrote:
> Sync up MR_DEMOTION to migrate_reason_names and add a synch prompt.
> 
> Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim")
> Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
> ---
>   include/linux/migrate.h | 6 +++++-
>   mm/debug.c              | 1 +
>   2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index 326250996b4e..c8077e936691 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -19,6 +19,11 @@ struct migration_target_control;
>    */
>   #define MIGRATEPAGE_SUCCESS		0
>   
> +/*
> + * Keep sync with:
> + * - macro MIGRATE_REASON in include/trace/events/migrate.h
> + * - migrate_reason_names[MR_TYPES] in mm/debug.c
> + */
>   enum migrate_reason {
>   	MR_COMPACTION,
>   	MR_MEMORY_FAILURE,
> @@ -32,7 +37,6 @@ enum migrate_reason {
>   	MR_TYPES
>   };
>   
> -/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */
>   extern const char *migrate_reason_names[MR_TYPES];
>   
>   #ifdef CONFIG_MIGRATION
> diff --git a/mm/debug.c b/mm/debug.c
> index e61037cded98..fae0f81ad831 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -26,6 +26,7 @@ const char *migrate_reason_names[MR_TYPES] = {
>   	"numa_misplaced",
>   	"contig_range",
>   	"longterm_pin",
> +	"demotion",
>   };
>   
>   const struct trace_print_flags pageflag_names[] = {
> 

Looks good.

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA