Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1632130171-472-1-git-send-email-anshuman.khandual@arm.com>
 <YUirurhvmBPCOsS+@arm.com> <127b2334-5c40-1b71-e510-ac837c3ac614@arm.com>
In-Reply-To: <127b2334-5c40-1b71-e510-ac837c3ac614@arm.com>
From:   Itaru Kitayama <itaru.kitayama@gmail.com>
Date:   Wed, 22 Sep 2021 13:52:21 +0900
Message-ID: <CANW9uyveSs-+DgGr87jYtruYcS7_FMxS=VD7mM4-G8NNcqBqNQ@mail.gmail.com>
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

How did you test the 16K page size configurations? In QEMU? I wasn't
aware of hardware that's capable 16KB page size.

On Wed, Sep 22, 2021 at 1:47 PM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
>
>
> On 9/20/21 9:11 PM, Catalin Marinas wrote:
> > On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
> >> Section mapping at PUD level is supported only on 4K pages and currently it
> >> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
> >> new helper pud_sect_supported() for this purpose, which particularly cleans
> >> up the HugeTLB code path. It updates relevant switch statements with checks
> >> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
> >> identical switch case values in those code blocks.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@arm.com>
> >> Cc: Will Deacon <will@kernel.org>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> >
> > Assuming that you tested the corresponding configurations,
>
> Right, I did test this on all page size and VA bits configurations
> , including the specific ones which were problematic.
>
> >
> > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel