Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e0dff2e1bb7db0ededfa5a66826225e1358ed77f.camel@kernel.org>
Subject: Re: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC
 pages
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     "Luck, Tony" <tony.luck@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Hansen, Dave" <dave.hansen@intel.com>
Cc:     "Zhang, Cathy" <cathy.zhang@intel.com>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Wed, 22 Sep 2021 08:17:53 +0300
In-Reply-To: <4c7351bcd03b4161b78a7dc01c795b43@intel.com>
References: <20210827195543.1667168-1-tony.luck@intel.com>
         <20210917213836.175138-1-tony.luck@intel.com>
         <20210917213836.175138-2-tony.luck@intel.com>
         <bba7e537fd9197a92358640ebb0aef365984cebc.camel@kernel.org>
         <4c7351bcd03b4161b78a7dc01c795b43@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2021-09-21 at 21:34 +0000, Luck, Tony wrote:
> > > Since there are multiple uses of the "owner" field with different typ=
es
> > > change the sgx_epc_page structure to define an anonymous union with
> > > each of the uses explicitly called out.
> >=20
> > But it's still always a pointer.
> >=20
> > And not only that, but two alternative fields in that union have *exact=
ly* the
> > same type, so it's kind of artifically representing the problem more co=
mplex
> > than it really is.
>=20
> Bother! I seem to have jumbled some old bits of v4 into this series.
>=20
> I agree that we just want "void *owner; here.  I even made the changes.
> Then managed to lose them while updating.
>=20
> I'll find the bits I lost and re-merge them in.
>=20
> -Tony

Yeah, ok, cool, thank you. Just reporting what I was observing :-)

/Jarkko