Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] mm/migrate: de-duplicate migrate_reason strings
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     akpm@linux-foundation.org, almasrymina@google.com,
        dave.hansen@linux.intel.com, khandual@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com,
        minchan@kernel.org, osalvador@suse.de, pasha.tatashin@soleen.com,
        weixugc@google.com, willy@infradead.org,
        yang.shi@linux.alibaba.com, ying.huang@intel.com, ziy@nvidia.com
References: <20210922041755.141817-1-jhubbard@nvidia.com>
 <20210922041755.141817-2-jhubbard@nvidia.com>
From:   Weizhao Ouyang <o451686892@gmail.com>
Message-ID: <90e7cefd-5ca0-f284-8c96-743e0f5ef8f4@gmail.com>
Date:   Wed, 22 Sep 2021 13:53:40 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210922041755.141817-2-jhubbard@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2021/9/22 12:17, John Hubbard wrote:
> In order to remove the need to manually keep three different files in
> synch, provide a common definition of the mapping between enum
> migrate_reason, and the associated strings for each enum item.
>
> 1. Use the tracing system's mapping of enums to strings, by redefining
> and reusing the MIGRATE_REASON and supporting macros, and using that to
> populate the string array in mm/debug.c.
>
> 2. Move enum migrate_reason to migrate_mode.h. This is not strictly
> necessary for this patch, but migrate mode and migrate reason go
> together, so this will slightly clarify things.
>
> Cc: Weizhao Ouyang <o451686892@gmail.com>
> Cc: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
>  include/linux/migrate.h      | 19 +------------------
>  include/linux/migrate_mode.h | 13 +++++++++++++
>  mm/debug.c                   | 20 +++++++++++---------
>  3 files changed, 25 insertions(+), 27 deletions(-)

LGTM.
And, maybe rename the migrate_mode.h?

Reviewed-by: Weizhao Ouyang <o451686892@gmail.com>

Thanks,
Weizhao