Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ad62ee8c-c5c1-e02c-9225-3883f03aa0e1@nvidia.com>
Date:   Tue, 21 Sep 2021 23:00:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH 1/1] mm/migrate: de-duplicate migrate_reason strings
Content-Language: en-US
To:     Weizhao Ouyang <o451686892@gmail.com>
Cc:     akpm@linux-foundation.org, almasrymina@google.com,
        dave.hansen@linux.intel.com, khandual@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com,
        minchan@kernel.org, osalvador@suse.de, pasha.tatashin@soleen.com,
        weixugc@google.com, willy@infradead.org,
        yang.shi@linux.alibaba.com, ying.huang@intel.com, ziy@nvidia.com
References: <20210922041755.141817-1-jhubbard@nvidia.com>
 <20210922041755.141817-2-jhubbard@nvidia.com>
 <90e7cefd-5ca0-f284-8c96-743e0f5ef8f4@gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <90e7cefd-5ca0-f284-8c96-743e0f5ef8f4@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2V5SVJIWGJOZEt3NkRHR2RMdkZ4RnROVzdkeVV1Qmw5cUE3aU1xeTlOaXFG?=
 =?utf-8?B?TW5mR1VSYWJrWk1zUTdzL0NTdG83aCs4K1U2RHd6eGovc1EwWVhkcnVhUEZI?=
 =?utf-8?B?OXBKcVhOR0hiRVNKWWZCL1VMVzY0RUl1b2ZpNFN2YXh3eHBoYVJuQ2ZTMVp4?=
 =?utf-8?B?aFNQVUpMZDNjRUNqWDhYeWk2M0t6QXpwcDBkT2dJeWpPdXZSbDJpNHpUY3RE?=
 =?utf-8?B?d0tOV1Bpb3UrK2dhVEQ5eTJnRyszQm1sSHJveFFyV1p4Y2NwTTBFd2w2Z0pP?=
 =?utf-8?B?NlJIaVNJbnZnS0V6NGYxQWgwZFYzNFhmRTZDWkxPNk9keXhGWDFDcm9zdkRh?=
 =?utf-8?B?em9iaENHU25WRm83UHhocitreXVLTm9rYWl4VUs0RjBsWjBZNThjS3R5QW81?=
 =?utf-8?B?eHF2UU5vS0I2dnk1NkVJQjExNXE4NHRtMHEzR0N5amRLVnhLbXRtV0h5N2RM?=
 =?utf-8?B?bmRFU3hXWnZYWGZWZXc5QjJUMm1oMnRvZGMxVVV4bWxFaDJPZDRNcVUxUWN0?=
 =?utf-8?B?QjIwaXI3TmlkVllJR2hVallObmZqOG5DMVNqRzRPdEUvdUlSak9HdVpGZWU1?=
 =?utf-8?B?cTYybS9hKytuZ21OajdjcXRSVFNuOSsrc1ZzeHk5aE1tSEF4WWtXZWp5Q21j?=
 =?utf-8?B?OTZyWE5ZK0U2dHdjbVljRjN4TmVPczRtR3QwYlBNQUhXY3ZyQlNBdkQrSjlD?=
 =?utf-8?B?OWtjUnFBbEtubWc2UWxQd215b0dRemJqc0twcjBHTUN0RnJVU2lNU0dsaHRH?=
 =?utf-8?B?SDNncENuc2hmY3cyaUVGMjg5cGJOc2lvazhJdzREUE45MDRTbCtPU2QxNFdo?=
 =?utf-8?B?bmxlemNidnpSMU51clpSZFpqdjFrS2owYmxybjQ1TGpla3pkNU5ocVhvbUVH?=
 =?utf-8?B?WXUvMzUrUkZPY1ZkQTE1ZmZtenZrVnBFaE5XUUh1VkpZSmswVGVVVGtVYncw?=
 =?utf-8?B?Q25ZU1RWNVY2VThlUGxZNWJNMG8vSXQrczVXeGtFVk95enZ0V0pZVUo3Y09L?=
 =?utf-8?B?MXNLSG82eWtvUk1ySXFZR3VVSFA4TjFCdmttS1pYckRoSnIwaDZCY05pY2Fm?=
 =?utf-8?B?dnJud1krNVhWRUxLMFVteitaK1Ztb3p2L0VhL2tNbVVWc08va0lEVTBUYTdZ?=
 =?utf-8?B?RUduVldSa1BYbGpraGVQdXF1V0pDNEJiZ3pXMTdIRUsxMW1KelB2ZnFjYWZu?=
 =?utf-8?B?TlQ0anRtN2hFM29TS1hybUluTFhtTWdtK3lQam5iRWZCcTJlK1VwK0x6OWhi?=
 =?utf-8?B?UHQzNXRETkZJUkQwaXJVcmxPeVdDWXpGc0d5T1djN1J2Nks0U1NXWFBvbWda?=
 =?utf-8?B?TnZQZGNrNGFqaGFTUkFsTFBMcC9XRU1tZFR2UkZzUVRPUis0SEloNFNIL0JV?=
 =?utf-8?B?N1hNUjk2OGpnUjhOa3FVcllHVEd3cHVPWXBSSy9tNEVQdjVBalpjZ0FDWjJK?=
 =?utf-8?B?Y251SCtLbHZiZnc5N0IrOVZ1VkxleDkycjVmd3AvYXMyWC9YSzZ1OHNQV2NW?=
 =?utf-8?B?aXVoQzNJc3JOR3IvK2Y5TWgyNG5ZRGUwVHRSVnBDUmptTWFWM0ZGVlpYRDUx?=
 =?utf-8?B?V0gzWHY0WmNmL3crTHh3VGlwYU9TdFJBbGg5TDhMaktIdG9PdisrSEdzQk9R?=
 =?utf-8?B?aEIrWTFuMUd4ZUNYRE5PMkt3TnE5R1Z2cU11ZGZyRUxQVFZTSFZnQTJaU2kz?=
 =?utf-8?B?REU4RFJld3NkMVJpSzVGYVNHR2VnRC9NdCsyY1RRZENHZEkwTExadzJNam5m?=
 =?utf-8?Q?43igfZwSznGeCkoLQ0VFJVcsxARpuiysCuTAigK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fad05cef-a6cd-40f8-8b6b-08d97d8e39fa
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 06:00:06.3166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VSTuElutNoaAEjYtrMrdSJZcxSd/H3IAvZxue/9WuTHWPCXP5B4Wfr0bA5rpEPoj6LnAbLTcFWKAg5UsKNEMDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2792
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/21/21 22:53, Weizhao Ouyang wrote:
> 
> On 2021/9/22 12:17, John Hubbard wrote:
>> In order to remove the need to manually keep three different files in
>> synch, provide a common definition of the mapping between enum
>> migrate_reason, and the associated strings for each enum item.
>>
>> 1. Use the tracing system's mapping of enums to strings, by redefining
>> and reusing the MIGRATE_REASON and supporting macros, and using that to
>> populate the string array in mm/debug.c.
>>
>> 2. Move enum migrate_reason to migrate_mode.h. This is not strictly
>> necessary for this patch, but migrate mode and migrate reason go
>> together, so this will slightly clarify things.
>>
>> Cc: Weizhao Ouyang <o451686892@gmail.com>
>> Cc: "Huang, Ying" <ying.huang@intel.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>>   include/linux/migrate.h      | 19 +------------------
>>   include/linux/migrate_mode.h | 13 +++++++++++++
>>   mm/debug.c                   | 20 +++++++++++---------
>>   3 files changed, 25 insertions(+), 27 deletions(-)
> 
> LGTM.
> And, maybe rename the migrate_mode.h?
> 

I thought about this, and after failing to dream up a better
filename, just figured I'd leave it alone. But I'm open to suggestion
there. And it is easy to change, since it's only included from two
places.

> Reviewed-by: Weizhao Ouyang <o451686892@gmail.com>

Thanks for the review!


thanks,
-- 
John Hubbard
NVIDIA