Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE_PLTS
 support
To:     Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
References: <20210922023947.59636-1-f.fainelli@gmail.com>
 <20210922023947.59636-4-f.fainelli@gmail.com>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
Message-ID: <d374a9ae-2dd0-3b11-d5f8-211ef3a6f991@nokia.com>
Date:   Wed, 22 Sep 2021 08:53:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210922023947.59636-4-f.fainelli@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXhuU2U2RzljVVdSck1ZV0JaSHVvSDkraXdFUXAzWnVXdk9ITDJIdVlaczE4?=
 =?utf-8?B?K2pMRkNUbXZkUDdHdUQ4ekxJaDhlUUZzVFVMVkVLcDZOSE1kdGxNVkZ1cmkr?=
 =?utf-8?B?WnB0Z3JFdkhwSm5TeFdaK0VaOEVYZFlvTzV5ZkczUnQ0QW13WHdaL2c2TkNB?=
 =?utf-8?B?TWZaMDFxd2E2NkhVbVNIZ3VwMDZDRFZlL1IzZzRqZFBubWNNSDhlMXJsV3Az?=
 =?utf-8?B?RlA1bVdoakhqTXF1bUtoOUlLZHZJQ1d2bFo1cHJNamRtVjVCbHZHZnNLaE5R?=
 =?utf-8?B?WDBVaU12d2xhbnQ0Slp3b3B5WUx5cDgveXM4TUFtcGtaTlhwY0ZlMVRRY1p4?=
 =?utf-8?B?T1FZY0dKNlFCM0hxa1pwMVpyalFzdEpPcjlFeXZZSXVhSGlUT2dLTklzU2F0?=
 =?utf-8?B?RmFjWmJXT0JtMzczMVBjUFhzelovT1M3dThiQWpwRFhsZnljY0Fuajh5c2N5?=
 =?utf-8?B?RThDMFQ3M24zYjRkYlhGOFBjRmU1eit1bEU2Q3FQYlE5UGExUHZkZDI4Q2xY?=
 =?utf-8?B?MEk1K0o3cjRNZGw0bU1BUHJJZklzaWl0cGxuTHkxWmZmNTRUTUQ4bitmMjJn?=
 =?utf-8?B?WmM3S29DVGFVYU4yS2pOUDFrVndBVFZPZEU0c21IMEVBU1Q5TzlaMlUwVTMy?=
 =?utf-8?B?NlYrb0NQM1BWem9DWmU0MG04dTBaUWJPckdlY294bHBqaTBJOEZOcXcyQ2xM?=
 =?utf-8?B?MG5iaVFaQS85aEhTSmpaZjFZazJkSUFNam5mNitxczROTlowdXZrNHJrV1ZY?=
 =?utf-8?B?SUpmaVlIMmRSaENlSzF1blFjY2E5Uk9SYmJIcGxvQVR3UUVnTGZ4bzU2R04x?=
 =?utf-8?B?emhXQ3dhcCt6M29EcVlqQU1IY1g3ZGVxWDFuWUFxQ2xydXBlcHowakFLVTVT?=
 =?utf-8?B?SkFRWkIyTng5V0s5UVI1OWEvbER3emN2SUg4SnE3bXZ6TkllcGNUYk9ETXZN?=
 =?utf-8?B?WEttbHF3T2tsTjdNa1F1bUUxWnFEQVdyVUdUMXdSMHdEeVVHUWovMFpibXo1?=
 =?utf-8?B?ckxmQ2VtWENJd29leFlGUGZkSGZkS3AxZzN1N0FMc1ZDTnNYK2FLOU9YTEZj?=
 =?utf-8?B?RXBhRHVBNW0zRmV1bmJmMmJLTnNhcXVSYnYvbHRMWjM0QU9RWUFlZDE1cHFt?=
 =?utf-8?B?WERSNmZVNmFjRUJKa0NvTVlkSGpqVEt6cFV1UW5RbGxWa2hENDV5cHo2S3l5?=
 =?utf-8?B?NEludzFIOUlVS0NhY1dlajQ2V2VUdHVJUWYzYUVzNDNqcU5NWWZWcjRDQWtL?=
 =?utf-8?B?cDAwOXZXNXNjMkphSXRqZEE3WDFKRGZERTcyMFhwQnhCQm1jdlpQOS90Tk1L?=
 =?utf-8?B?K3U4Q3V6TVcyS3FPT0RSTmZBZldQVjY0MUM5RXl6TUhJL0NLUHY4b2tjQWtY?=
 =?utf-8?B?cjBHRFMzKzdMTzU0VjViWmJvVEtTS3QzbjRKWERYOHhpRUQ0Nm81UjQwcWFP?=
 =?utf-8?B?aC9LMnJVbzFsY1VydkIyZlY1K1hpZmFzNzRoKy8vU3ZlZklPWFV3Tlh0TTFa?=
 =?utf-8?B?ank3ZmY2VVpvencyTjkveGNSa3dxUmpqTFhpUTlBVTl6c0hXWkhsNDlLempx?=
 =?utf-8?B?UXB3N0psTnY0aVIwdlVTWTBKSmtjamRCWWJVdlQ3T01VSHh0MXFScEdxRHgz?=
 =?utf-8?B?NVh0VW9iNHhoSE1CZ255S3BKTWkwRnVUQ3Y1dnZDM3YzOWUrTys1NFVFcUdz?=
 =?utf-8?B?bkgxWUpRUlF2anFCOGp4RFM5Z0tHT3FTWVdCZm5ZWis0K3c5Y2Z1Y043M1BT?=
 =?utf-8?Q?6FUIN51MbIFz+cQeZYqn6m+ZBzNfTyUt6wjWdyx?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcfcbcd4-1fef-40ca-00eb-08d97d95b854
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB4542.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 06:53:44.6877
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hIMOQ2Wlen5s0gMYSObx7aDkfZNjEFdL5x9mRzoiO8Ga+gmklOH+b8V9K7iJbkYPfAYpC4xLCvtIyd6eHnd7S8/reEcSl4D6NWpcMuIuMQo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Florian,

On 22/09/2021 04:39, Florian Fainelli wrote:
> From: Alex Sverdlin <alexander.sverdlin@nokia.com>
> 
> commit 79f32b221b18c15a98507b101ef4beb52444cc6f upstream
> 
> Teach ftrace_make_call() and ftrace_make_nop() about PLTs.
> Teach PLT code about FTRACE and all its callbacks.

sorry for inconvenience, but I'd propose to add 6fa630bf473827ae
"ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE"
to all series on this topic, because of the below chunk which might
lead to build issues on some exotic configurations.

Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZUVCQBHDMFVR7CCB7JPESLJEWERZDJ3T/

> --- a/arch/arm/kernel/module-plts.c
> +++ b/arch/arm/kernel/module-plts.c
> @@ -20,19 +21,52 @@
>  						    (PLT_ENT_STRIDE - 8))
>  #endif
>  
> +static const u32 fixed_plts[] = {
> +#ifdef CONFIG_FUNCTION_TRACER
> +	FTRACE_ADDR,
> +	MCOUNT_ADDR,
> +#endif
> +};
> +
>  static bool in_init(const struct module *mod, unsigned long loc)
>  {
>  	return loc - (u32)mod->init_layout.base < mod->init_layout.size;

-- 
Best regards,
Alexander Sverdlin.