Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp221346pxb; Wed, 22 Sep 2021 00:08:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxpexVAAXQQIQLfOx/3nRhc6AahRb+HzvLc44S8e9n7g0H33AUhmC5fTVpo2WKixzTVMDc X-Received: by 2002:a05:6602:2bd4:: with SMTP id s20mr3281314iov.63.1632294494318; Wed, 22 Sep 2021 00:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632294494; cv=none; d=google.com; s=arc-20160816; b=XCsn10wo1ei7fdvxUJlVErYAvqRrS5Gjh5LM1vQj5IdfkQoec0jfR2sHjPSzLXM9iv C6snc3BoAfK9wCk1aEKqsigstGSJsnPMOYOc/4p9/SMj1MR5I0N8JkBAuxW9hJpGIAag A7L9ZASW5fEAPBH5qhXYIzpC6dmrMR1k9cXbr/il42eEVzUqE0etY/xq+NQCxNeW8vwh M9T5YgbMk95zRIxM4NZLmtQzTwu+aZ2eeSFwzGiM1Je+XSJirlqii4EbmL9eh2hd8gh8 FiH1+uCn41zRsKY3lAWT20jwKdQwRsNE6MR75/Oi5akhP1HYdIWKUpL4EyTGxw+CVVw3 6Rxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZCzdOSs7pUuuoke9OdVvh+DPPvOxJcInBvQOumUOKbQ=; b=XJYN1sDjyxLpkEdMOENu2uJ1/gKkZPefGPSbbTPkCY6/J8vomQ8eFRfzvt+cF2M7VK LpHzfsXIffkS4Ae40tPaDckY/b84SwTsN6/D1X/oQUupGLePLvrFqYIPLoFrEmQ2EJsS W2KPLiDjRgFZeXcW0Ixyc6lN6dByf/PFcMnFkXMFLXsWydfwhtM81DG/oGg3FF3NzELR KAbsgQqF/eeaO34C2WQl3zz7Hsbcsj18O1Jaxr5tO/JnBt2OGPRyv/NqTcfcVEIYDTgD un4LMB0agsPq/OKsfHz/H4h93w9VY02bUJupIJHHEk6Rfse8Fje8CmUluOuD45fDlmQ8 LwrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x11si1604464iom.45.2021.09.22.00.07.53; Wed, 22 Sep 2021 00:08:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233058AbhIVHIT (ORCPT + 99 others); Wed, 22 Sep 2021 03:08:19 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:46995 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233036AbhIVHIS (ORCPT ); Wed, 22 Sep 2021 03:08:18 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UpCSO0C_1632294405; Received: from localhost.localdomain(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0UpCSO0C_1632294405) by smtp.aliyun-inc.com(127.0.0.1); Wed, 22 Sep 2021 15:06:46 +0800 From: Rongwei Wang To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, cfijalkovich@google.com, willy@infradead.org, song@kernel.org, william.kucharski@oracle.com, hughd@google.com Subject: [PATCH v2 0/2] mm, thp: fix file-backed THP race in collapse_file and truncate pagecache Date: Wed, 22 Sep 2021 15:06:43 +0800 Message-Id: <20210922070645.47345-1-rongwei.wang@linux.alibaba.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210906121200.57905-1-rongwei.wang@linux.alibaba.com> References: <20210906121200.57905-1-rongwei.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, We found two bugs related to file-backed THP in our cases, recently. The two bugs rough description as following: 1) in truncate_inode_pages_range, subpage(s) of file-backed THP can be revealed by find_get_entry. 2) 'collapse_file' miss the pages which in writeback but no private. This situation will be triggered in XFS when block size is set to PAGESIZE. These two patchs mainly fix the above mentioned bugs, and have been tested in latest branch. v1 -> v2: - Patch "mm, thp: check page mapping when truncating page cache" move the check of page mapping to behind lock_page - Patch "mm, thp: bail out early in collapse_file for writeback page" check the writeback flag before taking page lock. v1 link: https://patchwork.kernel.org/project/linux-mm/cover/20210906121200.57905-1-rongwei.wang@linux.alibaba.com/ Rongwei Wang (2): mm, thp: check page mapping when truncating page cache mm, thp: bail out early in collapse_file for writeback page mm/filemap.c | 7 ++++++- mm/khugepaged.c | 7 ++++++- mm/truncate.c | 17 ++++++++++++++++- 3 files changed, 28 insertions(+), 3 deletions(-) -- 1.8.3.1