Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Rob Herring <robh+dt@kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
References: <20210920071540.38337-1-krzysztof.kozlowski@canonical.com>
 <20210920071753.38560-1-krzysztof.kozlowski@canonical.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
Message-ID: <83206dd4-c779-1090-9394-2519d4747206@gmail.com>
Date:   Wed, 22 Sep 2021 16:55:37 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210920071753.38560-1-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Krzysztof,

On 21. 9. 20. 오후 4:17, Krzysztof Kozlowski wrote:
> Devicetree naming convention requires device node names to use hyphens
> instead of underscore, so Exynos5422 devfreq event name
> "ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
> dtschema enforces this, however the driver still expects old name with
> an underscore.
> 
> Add new events for Exynos5422 while still accepting old name for
> backwards compatibility.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   drivers/devfreq/event/exynos-ppmu.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 17ed980d9099..541bd13ab61d 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -94,11 +94,16 @@ static struct __exynos_ppmu_events {
>   	PPMU_EVENT(d1-general),
>   	PPMU_EVENT(d1-rt),
>   
> -	/* For Exynos5422 SoC */
> +	/* For Exynos5422 SoC, deprecated (backwards compatible) */
>   	PPMU_EVENT(dmc0_0),
>   	PPMU_EVENT(dmc0_1),
>   	PPMU_EVENT(dmc1_0),
>   	PPMU_EVENT(dmc1_1),
> +	/* For Exynos5422 SoC */
> +	PPMU_EVENT(dmc0-0),
> +	PPMU_EVENT(dmc0-1),
> +	PPMU_EVENT(dmc1-0),
> +	PPMU_EVENT(dmc1-1),
>   };
>   
>   static int __exynos_ppmu_find_ppmu_id(const char *edev_name)
> 

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi