Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp261896pxb; Wed, 22 Sep 2021 01:19:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVN78FRVes51P6WL2e1ARAX1PmRZ+mjqa5/rZboe79zzd2rc3N/ciRgcDYRIFNYDvBcpl6 X-Received: by 2002:a17:906:2bd0:: with SMTP id n16mr39564965ejg.132.1632298795238; Wed, 22 Sep 2021 01:19:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632298795; cv=none; d=google.com; s=arc-20160816; b=SxGdS04y6EqAewxhp8fFjoOzpYD07XWqUWpGQAAiYwLtGOw435SHQa1AgDh5F3ETKw QQni+lgXkmY1Fc88Dj8/tv9GhezSnbTuHMckK3o5LM9bB4GKeEXnLyCg/QIXUbpYFMad zUmbKwn0td+xAamicR4lTfZ1y0NzreW+bSpjY2TXTR7a9YGpSfHR2shn4bNQo+6Th3Yy tHJotMA97l7S1ew3BSFFzkjdtRupDnTK4LLgF/CEaM/xYKVoc7b49eBqPJtQPVW+bdmt aEBQbUJokOP0x3PPgNzwRRipKjEaZXFYDuo8wq89t0KFHMcIoLPtnm2Ijq+ttuvTUfjs 96Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bPjPf/hBO6JhqQY8sa5zK9YZkt712m5NLu/wBeQHyUg=; b=y3zCQACLdZjg1E1xTMCqzTkp2c9BOflTxv3ncTE/mJsTL8y+VGgkE7O1a5u/l/LNPv 90/DKFu7GTeuDjMd9DDYH9QICgLEN26V+S8G54w4AtdJOG16jlX1CQklnWrjcpw80RXF SVPVQCcvbfTfrA0DO7jf0tZHropnSUtzmr3olT8MVeIajqsQKIQQyCWpBfw7cuHTHCIE OK++5xJL8M1axYxH3Ax6MYMrbfvNGxV5I8pVI5jBVy/csvI5vzYLW6LT9VwDudM+A5+n 0omhRl9IueT9gEZyCLx9DohF/jGu4HAUuUoAsVivzXIU2fnrNU3ORaO0Wc5lPNcKAdUP tZbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 13si1739542ejr.434.2021.09.22.01.19.31; Wed, 22 Sep 2021 01:19:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233722AbhIVISQ (ORCPT + 99 others); Wed, 22 Sep 2021 04:18:16 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:57776 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233427AbhIVISO (ORCPT ); Wed, 22 Sep 2021 04:18:14 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 18M7sbIp099782; Wed, 22 Sep 2021 15:54:37 +0800 (GMT-8) (envelope-from billy_tsai@aspeedtech.com) Received: from BillyTsai-pc.aspeed.com (192.168.2.149) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Sep 2021 16:14:55 +0800 From: Billy Tsai To: , , , , , , , , , , , , , CC: Subject: [v7 02/11] iio: adc: aspeed: Restructure the model data Date: Wed, 22 Sep 2021 16:15:11 +0800 Message-ID: <20210922081520.30580-3-billy_tsai@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210922081520.30580-1-billy_tsai@aspeedtech.com> References: <20210922081520.30580-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.2.149] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 18M7sbIp099782 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch refactors the model data structure to distinguish the function form different versions of aspeed ADC. - Rename the vref_voltage to vref_fixed_mv and add vref_mv driver data When driver probe will check vref_fixed_mv value and store it to vref_mv which isn't const value. - Add num_channels Make num_channles of iio device can be changed by different model_data - Add need_prescaler flag and scaler_bit_width The need_prescaler flag is used to tell the driver the clock divider needs another Prescaler and the scaler_bit_width to set the clock divider bitfield width. Signed-off-by: Billy Tsai --- drivers/iio/adc/aspeed_adc.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c index 76ae1c3f584b..cc808ec89a0f 100644 --- a/drivers/iio/adc/aspeed_adc.c +++ b/drivers/iio/adc/aspeed_adc.c @@ -71,8 +71,11 @@ struct aspeed_adc_model_data { const char *model_name; unsigned int min_sampling_rate; // Hz unsigned int max_sampling_rate; // Hz - unsigned int vref_voltage; // mV + unsigned int vref_fixed_mv; bool wait_init_sequence; + bool need_prescaler; + u8 scaler_bit_width; + unsigned int num_channels; }; struct aspeed_adc_data { @@ -83,6 +86,7 @@ struct aspeed_adc_data { struct clk_hw *clk_prescaler; struct clk_hw *clk_scaler; struct reset_control *rst; + int vref_mv; }; #define ASPEED_CHAN(_idx, _data_reg_addr) { \ @@ -126,7 +130,7 @@ static int aspeed_adc_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - *val = data->model_data->vref_voltage; + *val = data->model_data->vref_fixed_mv; *val2 = ASPEED_RESOLUTION_BITS; return IIO_VAL_FRACTIONAL_LOG2; @@ -280,7 +284,7 @@ static int aspeed_adc_probe(struct platform_device *pdev) indio_dev->info = &aspeed_adc_iio_info; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = aspeed_adc_iio_channels; - indio_dev->num_channels = ARRAY_SIZE(aspeed_adc_iio_channels); + indio_dev->num_channels = data->model_data->num_channels; ret = iio_device_register(indio_dev); if (ret) @@ -320,17 +324,23 @@ static int aspeed_adc_remove(struct platform_device *pdev) static const struct aspeed_adc_model_data ast2400_model_data = { .model_name = "ast2400-adc", - .vref_voltage = 2500, // mV + .vref_fixed_mv = 2500, .min_sampling_rate = 10000, .max_sampling_rate = 500000, + .need_prescaler = true, + .scaler_bit_width = 10, + .num_channels = 16, }; static const struct aspeed_adc_model_data ast2500_model_data = { .model_name = "ast2500-adc", - .vref_voltage = 1800, // mV + .vref_fixed_mv = 1800, .min_sampling_rate = 1, .max_sampling_rate = 1000000, .wait_init_sequence = true, + .need_prescaler = true, + .scaler_bit_width = 10, + .num_channels = 16, }; static const struct of_device_id aspeed_adc_matches[] = { -- 2.25.1