Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "kishon@ti.com" <kishon@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "galak@kernel.crashing.org" <galak@kernel.crashing.org>
Subject: RE: [PATCH 2/4] dt-bindings: phy: add imx8 pcie phy driver support
Thread-Topic: [PATCH 2/4] dt-bindings: phy: add imx8 pcie phy driver support
Thread-Index: AQHXq29WYi5TvLUXCEy2ibvpD6GB8auoozgAgAcWY/A=
Date:   Wed, 22 Sep 2021 08:24:12 +0000
Message-ID: <AS8PR04MB867606786A72563C6A6746508CA29@AS8PR04MB8676.eurprd04.prod.outlook.com>
References: <1631845863-24249-1-git-send-email-hongxing.zhu@nxp.com>
 <1631845863-24249-3-git-send-email-hongxing.zhu@nxp.com>
 <1631908134.299718.2025325.nullmailer@robh.at.kernel.org>
In-Reply-To: <1631908134.299718.2025325.nullmailer@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4kEcWQ4djeEP8QPJ4x/Ys2pGIKJotDwKwHS6D+sKfYOR7UPfduFVEIed76OQ?=
 =?us-ascii?Q?44cfH4caSG/UzgpZE/wCljjuvI8dKpiRaF50pQnfrbCSlWU8QShi73GBUn7M?=
 =?us-ascii?Q?TqUgaLlT0b7OaQjxJb+LRil16itOto5dorPktW8/Cl0UvkYHZSwjWKDFJA3d?=
 =?us-ascii?Q?IrxNw8UKxK4/KAB32IQ63j5g6bSRn8YNS7q7vlSdB86QZIXbj/nwPF5VZqRP?=
 =?us-ascii?Q?IwuBLnsn0nr3LQJqrgZKtqseDkWhXRB+SSZrM4oWWafcq6krZCRLxdIJxb64?=
 =?us-ascii?Q?iXMV6BD7XifbVRYAbUbQHDAc/ayYLzBnb8zytZ3gsL+eg1tHHwvU1cvpCGIH?=
 =?us-ascii?Q?W5GO+eHPlY2PbfwSbw5hC6aBsuCllAp9amo3OnYOnP52E1E8LG9v8wjMNwIP?=
 =?us-ascii?Q?YifNN4m+rorNFGaos3dfCto7ggOf5dO6hJlsAsHK+bF1Yiqxd1A6X41llf8s?=
 =?us-ascii?Q?pV7RJr6B697yIDVa/zh/MxzzQqHXWZWz/G7A+wj4ynDn/pe9OwjwsbTFUnoB?=
 =?us-ascii?Q?Vp1T91VMXS0Lc7vw7+33h2e5DORbJnatAvvKbYOK3RO7woHZPSbdo4smo3Js?=
 =?us-ascii?Q?eFF6YMv4jP9W0jn/38kPBpYICnDZlZIW8LlOLc6ZRc8mwYgF7A18eh56YNOq?=
 =?us-ascii?Q?dpJPeeEAYpV3IX3OKhQ+/w8aJRdXl4HxZgvO0NLZkU6kokrotQIxNjOpvY5a?=
 =?us-ascii?Q?u1NY0CheZ6sABhS1DSnDS5cfn3OTXszDiAhJpLCSs8iMYcFMBPYB8UYIx31i?=
 =?us-ascii?Q?/O/SgbB7LL4NgSK+atFeI4Iw2ov4m7pzZqHEuiZIZuQzapJdqgjqwQr8aW4n?=
 =?us-ascii?Q?JN68ByFD47ayYa+RJkeG6ig62ib3Nf6kxSFAQQDAU/OiWk7Rx/Ho+LJGUDj+?=
 =?us-ascii?Q?XdXzXhIks2SJaSeYgcCW1vl32PkeMsZtihnA3+Lynzn581q8mjCAcKJXxItG?=
 =?us-ascii?Q?rDpJ83FVNOLBwsDqerLI0dN1YkpQEz3OXpquO6LKXWd9UI+Z9OedHrezrrLS?=
 =?us-ascii?Q?U4I7f2JQrSmK6LfaQjStKAhExROQAo+2Fprq/MAdpjjCivE76ls0bkcVt7Gx?=
 =?us-ascii?Q?lxsxois44Zitkuy+1xLYn8m7DHu8DnyObXrt3A3N0xeEtDOW/jnHwJ/HLkmm?=
 =?us-ascii?Q?7Qzq+v9lMQYMsF3KBCTaykb7jHgGtt+DVI/D9u5Mn1c9U6omf97Wa8HtGOvu?=
 =?us-ascii?Q?U2lMN56KxhQx40GzcOFj97ue3vfbUZGU75vMXMMB6WiuLlBb5c+fKPdXyvKO?=
 =?us-ascii?Q?7XlCKNtgRfqcOC5k69jL7vMJjofOFq0tQY9ZvygDw8c2MJhYWna+TlVeHkqO?=
 =?us-ascii?Q?Cxe7W5nk99U7RinTO3O25eUa?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3299fae6-5846-432c-806f-08d97da25be0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 08:24:12.7905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GZn1BczSdT42ykzH3bwdpq1ZYaI11ch/OEbHi/xZQ39gTMOfNf28yWhrG9LJh8IbvzlqCXSCfCHfLrTRRhbzvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8963
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Saturday, September 18, 2021 3:49 AM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-phy@lists.infradead.org;
> l.stach@pengutronix.de; linux-arm-kernel@lists.infradead.org;
> kernel@pengutronix.de; kishon@ti.com; linux-kernel@vger.kernel.org;
> vkoul@kernel.org; shawnguo@kernel.org; devicetree@vger.kernel.org;
> galak@kernel.crashing.org
> Subject: Re: [PATCH 2/4] dt-bindings: phy: add imx8 pcie phy driver suppo=
rt
>=20
> On Fri, 17 Sep 2021 10:31:01 +0800, Richard Zhu wrote:
> > Add dt-binding for the standalone i.MX8 PCIe PHY driver.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  .../bindings/phy/fsl,imx8-pcie-phy.yaml       | 66 +++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
> >
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
Thanks for your comments. The errors are fixed by adding "$ref" below.
       Refer include/dt-bindings/phy/phy-imx8-pcie.h for the constants
       to be used.
+    $ref: /schemas/types.yaml#/definitions/uint32
     enum: [ 0, 1, 2 ]

Best Regards
Richard Zhu
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/=
fsl,i
> mx8-pcie-phy.yaml: properties:fsl,refclk-pad-mode: 'oneOf' conditional fa=
iled,
> one must be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type: boolean"
> 	Additional properties are not allowed ('enum' was unexpected)
> 		hint: A vendor boolean property can use "type: boolean"
> 	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/ph
> y/fsl,imx8-pcie-phy.yaml: properties:fsl,refclk-pad-mode: 'oneOf' conditi=
onal
> failed, one must be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdevice=
tree
> .org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=3D04%7C01%7Chon
> gxing.zhu%40nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3
> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637675049421428781%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DlOkPSEyYhyhHPHQBi916FgdPeqK
> GWi1yCC1KyhlsUCU%3D&amp;reserved=3D0
> 	0 is not of type 'string'
> 		hint: A vendor string property with exact values has an implicit type
> 	1 is not of type 'string'
> 		hint: A vendor string property with exact values has an implicit type
> 	2 is not of type 'string'
> 		hint: A vendor string property with exact values has an implicit type
> 	hint: Vendor specific properties must have a type and description unless
> they have a defined, common suffix.
> 	from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdevice=
tree
> .org%2Fmeta-schemas%2Fvendor-props.yaml%23&amp;data=3D04%7C01%7Chon
> gxing.zhu%40nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3
> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637675049421428781%7CUnkno
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DlOkPSEyYhyhHPHQBi916FgdPeqK
> GWi1yCC1KyhlsUCU%3D&amp;reserved=3D0
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/=
fsl,i
> mx8-pcie-phy.yaml: ignoring, error in schema: properties: fsl,refclk-pad-=
mode
> warning: no schema found in
> file: ./Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
> Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.example.dt.yaml:0=
:0:
> /example-0/pcie-phy@32f00000: failed to match any schema with compatible:
> ['fsl,imx8mm-pcie-phy']
>=20
> doc reference errors (make refcheckdocs):
>=20
> See
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatch=
wor
> k.ozlabs.org%2Fpatch%2F1529140&amp;data=3D04%7C01%7Chongxing.zhu%40
> nxp.com%7Cfacb5eafa5eb4fe72a1908d97a1430c0%7C686ea1d3bc2b4c6fa92c
> d99c5c301635%7C0%7C0%7C637675049421428781%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C1000&amp;sdata=3DqePjUlHV6abE0GeKxqqoddS8%2Bc28wRGOoLB
> NyDPpDc8%3D&amp;reserved=3D0
>=20
> This check can fail if there are any dependencies. The base for a patch s=
eries is
> generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.