Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Sep 2021 14:01:37 +0200
From:   Daniel Kiper <daniel.kiper@oracle.com>
To:     Ross Philipson <ross.philipson@oracle.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        iommu@lists.linux-foundation.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, dpsmith@apertussolutions.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        luto@amacapital.net, kanth.ghatraju@oracle.com,
        trenchboot-devel@googlegroups.com
Subject: Re: [PATCH v4 01/14] x86/boot: Fix memremap of setup_indirect
 structures
Message-ID: <20210922120137.3smvvedpxroi7bkw@tomti.i.net-space.pl>
References: <1630070917-9896-1-git-send-email-ross.philipson@oracle.com>
 <1630070917-9896-2-git-send-email-ross.philipson@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1630070917-9896-2-git-send-email-ross.philipson@oracle.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RW69mn7RYifo/V9W3cBbLKttOBMA16GHOty5ruGBvz4C0wO0r9N/b1WnxOCJ?=
 =?us-ascii?Q?DdsOy2Dg9GcuvTKRkEc4p3L41lnlAeF4Vxw5eiZsp0KZJtOJPN5gaGdg5BD+?=
 =?us-ascii?Q?2mL+fbQlfC1J3SHxGa+GArc6+oqdtj8OV7dgWKw22FojTcbthQ3IpzbEqQCx?=
 =?us-ascii?Q?zZZbq0YD/4v1SfrqgFrDb2cURKFwL/CbURdexP2ovZB9Iz88UJ7XWS5tlmlL?=
 =?us-ascii?Q?xxSpQT6HPWcwIa6tSUtcre0hPXIfbvg5MdI1cXT9bztloxbJEaMsldu7A95R?=
 =?us-ascii?Q?Sj41N61jGpTM1YkKh/uTynuVl+FUysz4tCVqMGoQrz7UCgnELDpn+jO8DV4s?=
 =?us-ascii?Q?UDIUHNWzKYezg6P7xxgNVFhEZ99Z1wFon72TvrdBiW53TD82beJQecikh1Cq?=
 =?us-ascii?Q?/CEm2DUC2QhbiyRRa3Kr22Y3Xvb6YFogq5nbpxJMU17UDGEvCMZdI0KmpuV2?=
 =?us-ascii?Q?TfMMVrokJhQyxymnSgFkYsFC6fQrpICZ1JZPwuLvaxdbLgZnmt7UTZQMV8Bn?=
 =?us-ascii?Q?ALC8HX0KNzldpiq/fhyUM/Urlp+Tyq3tEMI0eInf3cuJe0qUqZ4JIgGXkxVd?=
 =?us-ascii?Q?Z0LbhSSKMX0LefkTc/4KGtwnxOLjDdd/IiS2ON4pn4diELX2EWLNR4grcQiw?=
 =?us-ascii?Q?gu6MPvA5g/Hid7sTWHHQxCvjdRfNxAXhyHJF/SUE0fSi5dtw9GvqNXOAJjMO?=
 =?us-ascii?Q?/oGOrETO7AjawMMMv/nllCpEglNp6nKTvevF6pjDye8tEnMazQh7loqzdLtx?=
 =?us-ascii?Q?PwYFeUBk/JW/yhahEm05+wElU/1rDoNIV7PM9On0Y73nWy5Qu4mFxl1nLOpg?=
 =?us-ascii?Q?1xTHis1K6YJZMfxY+cV9BRoTZvOQ1AiH2yeQqyeMY1VaO1oCJ6ehOJF3N57o?=
 =?us-ascii?Q?fbLEDOOc5rCP3DIl4IVlL9jYz7hucqbmlZsgX8UqvgSmjVqB0ClLkGTDNh+l?=
 =?us-ascii?Q?7KlmVSKY3hXoqRmiiT1RZEMaXrRJdeqt5XdPMYfS7MTy0xz+2ni8u933JVZ/?=
 =?us-ascii?Q?X3CFbuGmnwVOM6AodpXEin50GTSZwF0YbvWfjT42hPM7qI8WsWIxZlS1l8n/?=
 =?us-ascii?Q?DdXB5brUCPZHhtGnllz+379/Hni8zDT0h1RBoGCnWAfn6VgIgT2JpNgiofiG?=
 =?us-ascii?Q?tXZfAagNyj962ObAOwAAmjLoxikhIxAwDA5/qQdQnIVRBw2Qf7aD6EhIK9zr?=
 =?us-ascii?Q?pQ80AZCSuBWeVDOqQVJsCIvwgo7MxpD2mDKLAoWTQ61MeGpNg6X7xFuCtAgX?=
 =?us-ascii?Q?kVrWFRWiwkwtdISj7yNWNz26anlIM36fhdAMaROT/MVqRQP76wOyTumBQESC?=
 =?us-ascii?Q?0X/fNVUoN6QbA+IpvcqePf7b?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa8aab86-2058-4d1f-26cd-08d97dc0c08b
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 12:01:47.0881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hSNYRrnBlEQzY1Sr1I2hijy4NHJONGTVB8i4benxNH226b8p8ZE3ISROJ9FQDCFOZW2/sKP1b/1dVuOAHBIClg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1380
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109200000 definitions=main-2109220085
X-Proofpoint-GUID: a314SK0ROoq0Q0UhakaBAdyllWTqP0yr
X-Proofpoint-ORIG-GUID: a314SK0ROoq0Q0UhakaBAdyllWTqP0yr
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 27, 2021 at 09:28:24AM -0400, Ross Philipson wrote:
> As documented, the setup_indirect structure is nested inside
> the setup_data structures in the setup_data list. The code currently
> accesses the fields inside the setup_indirect structure but only
> the sizeof(struct setup_data) is being memremapped. No crash
> occured but this is just due to how the area is remapped under the
> covers.
>
> The fix is to properly memremap both the setup_data and setup_indirect
> structures in these cases before accessing them.
>
> Fixes: b3c72fc9a78e ("x86/boot: Introduce setup_indirect")
>
> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

This is the fix. So, I think it should be taken now, regardless of the
fate of the other patches in the series.

Daniel