Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v4 net-next 7/8] net: mscc: ocelot: use index to set vcap
 policer
Thread-Topic: [PATCH v4 net-next 7/8] net: mscc: ocelot: use index to set vcap
 policer
Thread-Index: AQHXr56I1X8k6Vdwpky9OCEV9EsRoauwCXaA
Date:   Wed, 22 Sep 2021 13:18:37 +0000
Message-ID: <20210922131837.ocuk34z3njf5k3yp@skbuf>
References: <20210922105202.12134-1-xiaoliang.yang_1@nxp.com>
 <20210922105202.12134-8-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20210922105202.12134-8-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UNbGNcKG9ovCnAvR67KsvcBWvmvGrpQroxh8shKf6IXhjgk2SYcz2SjL109l?=
 =?us-ascii?Q?YdiVE92VXiyRu0EoYHOX0cMPm/2GSQnOFmRbQaK60j+MsCZRB9RYKBIkKS2r?=
 =?us-ascii?Q?TDRJfWo6biDjiSfYkC7+uqxz6kWh1SuZGk5SpLxw0MtPWhIPwP+gbiX9Q5vb?=
 =?us-ascii?Q?wN3Ol67ncfFHOpRiYIJ9/pQGrkzmJLJziuPBTmkytQ1jDLs4PBpRmnBxGrko?=
 =?us-ascii?Q?TXlnabPtMF8W+ujMbolMaYP7yfHaqCIEsVC3abdZM4K3zj3dpSULMqdJWFNA?=
 =?us-ascii?Q?mOI4eDh8u3v/KZq7MMTmtbusfWkxgC43DKyBGmYNGmxy7cUfDYe+/ywRLA+Q?=
 =?us-ascii?Q?AQ5dSvzsP1ZVTUqy7lTKpzq34y5PlP6clN55vZLfHZUwGqvxzwfTAwnQSlw/?=
 =?us-ascii?Q?/Hrk72uBUykZtNJgLOjoBsnNxV0xswIrPmT089xLLe7aE/4sLGGGpjdDCHZ5?=
 =?us-ascii?Q?XfJe8lOBvzIIu28XfYcCHcU/4bG70yMI2t6o9mAw+2XkZJiv33JUn8sL/aYp?=
 =?us-ascii?Q?9buQWNrMtpa75PwMbTu8pjEf0Hy7sF7uforCuPsV2IUNEzQIyK4DXwbp9cAg?=
 =?us-ascii?Q?zl7M4ax0Fl29L6JWEwr8w04iFFULziXRJ1lvRCwG+bubJXnaBMnqfjjCWgsw?=
 =?us-ascii?Q?JZv968ZO2gO99HsFOxLnaZUebk7xeTSKeUkjtG6qdU0Hlv+wXm8c1hhs513c?=
 =?us-ascii?Q?6x2X/w6wzyA1MoyaiOqhxEDfUdzex0uZ8BKu7/i24syRWNTTdmP+WlOwCBnx?=
 =?us-ascii?Q?dcl/BFc+scVAPeqKXkobH3mjcU+sTXfrV2lZh+cZL4sqLUGsbbtYCns1snuj?=
 =?us-ascii?Q?q9DM5obpZObShiGvSVbWJeePOlGO7qpLOMG4nRqgCBm+FtfMCCO9QD9JZ0By?=
 =?us-ascii?Q?zUwVKDYUjAJADmwp0035kNHop5FVpjDQHRpIIVAecroYJMTA2o7qkqQicaVs?=
 =?us-ascii?Q?oBu01+yhlQV1d8hH29yTYRm7rw4kS84xUWm6It4KX/us7fSPTjYCZfCdjfcS?=
 =?us-ascii?Q?Ltnm36kX1ZzqTN7nCzqrP+EO10IxbBG9SjXheWMxFAYthlyHTs7nw406CAf1?=
 =?us-ascii?Q?oKZSaKJ1Xih70n/jS7jwLi8+jCf4TSzL2xqLOQCq5XjPH9ZIpI4LgPudzU7M?=
 =?us-ascii?Q?lqCm+se4nRo/fdx38ovTlkS6t+ZOcQIGE+sGtFGBUiT5EkQsOiSRAjWijCve?=
 =?us-ascii?Q?Lb9tkwseaXI4l0EYea6nPYP60tE833WDdE4g1oR6rVscNcSoDO2xKP4wiRCN?=
 =?us-ascii?Q?S5CBjBbIjn/ng/BtBu6ZslaHypBTOGhlr02aBoHx8w1oT5dFZVYEBe7DRtM7?=
 =?us-ascii?Q?a3A+8drCdmsI6/OathcIZhAr?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BE911CA3556C5D4D86F04F7752A7738C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7dccea-3026-49a8-caff-08d97dcb7d2c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 13:18:37.9767
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FjjQP7Q0d/tMwzDdkUKbv4kOwwIP6A6eXdjBzyhkkaAPu9rF4MzZlRnG8TSDV4wHUVOju5NzILY2nFPw187Q/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3615
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 22, 2021 at 06:52:01PM +0800, Xiaoliang Yang wrote:
> Policer was previously automatically assigned from the highest index to
> the lowest index from policer pool. But police action of tc flower now
> uses index to set an police entry. This patch uses the police index to
> set vcap policers, so that one policer can be shared by multiple rules.
>=20
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---
> +#define VSC9959_VCAP_POLICER_BASE	63
> +#define VSC9959_VCAP_POLICER_MAX	383
> =20

> +#define VSC7514_VCAP_POLICER_BASE			128
> +#define VSC7514_VCAP_POLICER_MAX			191

I think this deserves an explanation.

The VSC7514 driver uses the max number of policers as 383 (0x17f) ever
since commit b596229448dd ("net: mscc: ocelot: Add support for tcam"),
aka the very beginning.

Yet, the documentation at "3.10.1 Policer Allocation"
https://ww1.microchip.com/downloads/en/DeviceDoc/VMDS-10491.pdf
says very clearly that there are only 192 policers indeed.

What's going on?

Also, FWIW, Seville has this policer allocation:

      0 ----+----------------------+
            |  Port Policers (11)  |
     11 ----+----------------------+
            |  VCAP Policers (21)  |
     32 ----+----------------------+
            |   QoS Policers (88)  |
    120 ----+----------------------+
            |  VCAP Policers (43)  |
    162 ----+----------------------+=