Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] xen/privcmd: drop "pages" parameter from
 xen_remap_pfn()
To:     Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        lkml <linux-kernel@vger.kernel.org>
References: <0f0db6fa-2604-9a0d-1138-0063b5a39a87@suse.com>
 <036ad8a2-46f9-ac3d-6219-bdc93ab9e10b@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <53732207-cd36-2214-94b3-be1837957d8d@oracle.com>
Date:   Wed, 22 Sep 2021 10:02:12 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <036ad8a2-46f9-ac3d-6219-bdc93ab9e10b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2NGdi91bTF2QUUwWHRYQmY0cDhmdTJmYjBqZStDVHdLL0NNbWs4dGhsS2s0?=
 =?utf-8?B?TmhMTjNLVnpROFJjWkI0Qi9ENlRENG1WL3laa3RKNzRIRVJMUmlLNk1ObW9u?=
 =?utf-8?B?Zk1WcCt1S3ZSa051cnBUVU5zT3B5WU9adHZFKzNkV3pIQ3k5aDhrTUlFTWth?=
 =?utf-8?B?UlRYbnVUOGJyeFZtaHJMNDZEWGtodWFBSk5VSFcxaVFONmI5djRjUkxIZVE5?=
 =?utf-8?B?WEtZbTk5SkkvVkdJY3dxdFFaL2l3MjYwbW5YUmhxOUhSZTlGRDEycU03N0hj?=
 =?utf-8?B?ZUlXb2IyZkRqNTc5ZG5mQWhmVlR5QWd6Vkc0cU9nZEpFTEphSXRLcUJRdzB4?=
 =?utf-8?B?Vko0eWo3bG1OTFdVK0hEL2JKNzJKZWFjQXozbWtpa0oxcEN0cUZwQjFwVm4x?=
 =?utf-8?B?RS82TXRoRXVHVXNEMHIwRFRJaUtIekNFcFBmcElPUjEramFFWTIxamY0M0F2?=
 =?utf-8?B?dStlNkxhTlVFNFlXUU9GUDNNMzRGSW9PTkpqV1RlMHdQSHgxanJISUVtbE5h?=
 =?utf-8?B?SmNjN3V2eGtRSWNzTnBzeDU2RXFLb1NSOTBhek5pRGtPQ3hzbmY4NGJ1UnNK?=
 =?utf-8?B?OVhxeHdwd1FPd2dXV0RYUHFzTkhWd3U2dlFJWmNCN1Jjbmc4RFBnMVpZV1RR?=
 =?utf-8?B?L01xQUhXTVhNRVY0bUdOOU9SVStOUDNqNjNyNUVnaXY2RFgrRkMzZ25GdWk2?=
 =?utf-8?B?WDR0VGwrUmlmQzNQcEhqNHVSb051aE0rL3cxbTYxM3gxcVFtOHhVbjJHMUZV?=
 =?utf-8?B?K0hEUzNaeXZObG5rallHZ0pza010MlI1ckxSSHcyTWUzWUdqTDhkZ0F4UE5t?=
 =?utf-8?B?N3l1WHdHNFBaSEdKWHdjWklDc2lZRUt6UDFsZHE2VXhtN2J4cjZhc0pYSkdk?=
 =?utf-8?B?SnI4VlViSFlSZVMyMnVaaTVDdVNuSmtvSG1XRWRNZVQ4VC9xdlk0SWtycnBv?=
 =?utf-8?B?cWhwZk9aWG4yVVh0dUFtSk45OUliSHVjSHYzWVNON0s1NjhKVXVRdFQwZXMx?=
 =?utf-8?B?VlJ4SEtDTXBmZ3FBWWhTOGhyQUZia3pPVWs2YmM4NGpDS0pFMnoxQ09oeU9a?=
 =?utf-8?B?MStqZUJpNXdldGt1ZkIyK0xhMDdRS0F2QXQ5dDk3WC9jR1E4ZWZiWkE2bVZU?=
 =?utf-8?B?WXBSdTViK2p4My9rMzEvR1J6ZkR4MlBtbFo4N2RkSjYwTGY2aFZjMEIyb01F?=
 =?utf-8?B?dEErdFFlSXdlRkx1aFhrOE9NdmNtZEJLOG44cHllN0ZPaGhDNTdGM2J1RGRq?=
 =?utf-8?B?a0RncnR6aWJWR0pkNUlPYlpIRU1LYkptYzFibnpKYjE5YUFNYm9iWmtXVEpN?=
 =?utf-8?B?NWUyQnI1NDVEVlBoK0xFVDRsQk5PRURsalUwUmFMWStzQk5UclJJNTgzWitR?=
 =?utf-8?B?N3pueG9Fdjd3OENWM1A1MC9OeEV1di9TNjRubldraGRQZE1qTWRNdnV4cjUy?=
 =?utf-8?B?V3g4cjlJSGJUOVFXM0Z0M1owZ3k2QXJXYkVzeFdDa01rRk5YbHhLMy9EUkR5?=
 =?utf-8?B?aFoyWVlTYUovazN2RWdBSFZvSkpIRUh5K0lmamlPeHROdHZrMlRqclFZdTNo?=
 =?utf-8?B?YjlxdkFJYzFFZlBxa3QwMmczY3F0RlNYR3FSVThlR01iQ2EwZS9zZnpqcW9l?=
 =?utf-8?B?ZzBXQWY4NkxqYzQ0ZHhoNnNoUjQyVytDOWhHbmg4SHRCSC96M1ZBUVA2TDZa?=
 =?utf-8?B?T3hJZDI0ZFBuZm11Z2htaWp5MklkR0JMZC9tS01Oc2JUS1dPK2l1TmdDTTdk?=
 =?utf-8?Q?YC5zzDaMsCdaN9ram0scRfckdA069qW8dG65uE4?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10cde072-fcad-40c8-65ab-08d97dd195c8
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2021 14:02:16.6291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k8hvdfdMbSDLTyzuQddvfFiK+JWMKBkhE8SQFf2nO4M0HRE4vDnjTkFqRc1jkBHOygZWbkmtYmLGvS+N4ksApWh+ms6iaUwfPzRxgw8RQBo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5201
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10114 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109200000 definitions=main-2109220101
X-Proofpoint-GUID: cloD8LtIeUPUxAx6a11sZF801fOJ2kPS
X-Proofpoint-ORIG-GUID: cloD8LtIeUPUxAx6a11sZF801fOJ2kPS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/22/21 6:18 AM, Jan Beulich wrote:
> The function doesn't use it and all of its callers say in a comment that
> their respective arguments are to be non-NULL only in auto-translated
> mode. Since xen_remap_domain_mfn_array() isn't supposed to be used by
> non-PV, drop the parameter there as well. It was bogusly passed as non-
> NULL (PRIV_VMA_LOCKED) by its only caller anyway. For
> xen_remap_domain_gfn_range(), otoh, it's not clear at all why this
> wouldn't want / might not need to gain auto-translated support down the
> road, so the parameter is retained there despite now remaining unused
> (and the only caller passing NULL); correct a respective comment as
> well.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>