Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "hch@lst.de" <hch@lst.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "parav@mellanox.com" <parav@mellanox.com>,
        "lkml@metux.net" <lkml@metux.net>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "lushenming@huawei.com" <lushenming@huawei.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "yi.l.liu@linux.intel.com" <yi.l.liu@linux.intel.com>,
        "Tian, Jun J" <jun.j.tian@intel.com>, "Wu, Hao" <hao.wu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>
Subject: RE: [RFC 15/20] vfio/pci: Add VFIO_DEVICE_[DE]ATTACH_IOASID
Thread-Topic: [RFC 15/20] vfio/pci: Add VFIO_DEVICE_[DE]ATTACH_IOASID
Thread-Index: AQHXrSGrvqwDmY670Eehf+r4QAc6S6uuy+yAgACk0sCAAJgXgIAAFfCA
Date:   Wed, 22 Sep 2021 14:17:56 +0000
Message-ID: <BN9PR11MB5433D992DE87A7F8E09E24CF8CA29@BN9PR11MB5433.namprd11.prod.outlook.com>
References: <20210919063848.1476776-1-yi.l.liu@intel.com>
 <20210919063848.1476776-16-yi.l.liu@intel.com>
 <20210921180417.GZ327412@nvidia.com>
 <BN9PR11MB543319F29F0260EBE2A9F3478CA29@BN9PR11MB5433.namprd11.prod.outlook.com>
 <20210922125833.GO327412@nvidia.com>
In-Reply-To: <20210922125833.GO327412@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HsQ66fNu0xlLRCXqHxqqKddkwsAVhkmff6z51UMIdmXQ5F8NjF55BLo2abHI?=
 =?us-ascii?Q?NY3hyCFXUGZ2bn2Fj7tGVmfN/XW1cSnR/gd049s51kMpBEMWOLTx7S352ZAJ?=
 =?us-ascii?Q?aAdg5KlW7qDES1FLT2Lwrzn6rLi1EIHO3K9PUUcqcUV1wqyigXhiOU6vVR4j?=
 =?us-ascii?Q?XPIWNlw1bKUmc/PI8UzM/Y+iH2MtlfpxiDFsSJreCwu52vdthXDyQyAAWrTZ?=
 =?us-ascii?Q?45QAclNIu10+RdPWDMyMdgSfzGvhTM8R+Av1+X5yjdee6JdCzpU64+QFF1FH?=
 =?us-ascii?Q?eatXFsw5Xi+1l3rI6DtGK+Ps9WHcWslIEdusIoUwuS3G7YrntS07QdTZak7J?=
 =?us-ascii?Q?aKR88sYKwzDZNwl86WWs7Mo+Y2DO3xK7D82hxBz0bUw/NjLlU9gxI4XEoCf+?=
 =?us-ascii?Q?50YJ6XP0HOWYXBD2NBkhIvBFAQccdjwmJpMmSE62my1jsDw/9V0tQcOWHV2T?=
 =?us-ascii?Q?T+dEurKZtF22+HkJcr7IDmT//jZ+UDL6zr9jWEI0MMuxOGUYgmHpk/ZdqIQC?=
 =?us-ascii?Q?ZI+V2uDABcQJqx/hp/yPmqHBHHlMkbKCc6pQ2aiiCWEyaghrZDQLqHkLaUju?=
 =?us-ascii?Q?fKUwvijHhgmi0Ij5N1M2K8rxNCTMNGCY/mnpFb06pJVIFyLg5lHa7nblBAnS?=
 =?us-ascii?Q?72QGEKbo7j40pcCiSe7sBo4nbCxfAer9x/nKVCMKmTWme31E7hXc313CRHQo?=
 =?us-ascii?Q?izVWbAHQjLGq2+DFuJvvslMIEOM8mmP83SKFceL8HMMGUBXLYqk+3+R00hT/?=
 =?us-ascii?Q?JCvDpQ/omxY4Jitmpl8UTMi4gVeDIKIgnv44Gn7pseHay28LsjTTYW4ii2tX?=
 =?us-ascii?Q?fVXij7/ysOZGpbWEYjX5YLuncKWYu6fP/d/nkdBQ0/9tsHuPdULlvFN0Mwvz?=
 =?us-ascii?Q?kh41BiN3Y8fsw6IzBaePZPltYbEeBrUOpyXHU0PsqPyTng3pA2BAopHZk+LL?=
 =?us-ascii?Q?ZEJi92J9yJN1LH2Eeju8h3gH+cK8qIce7kh4GaFg/EzpW9EItbtL4NSKKSK3?=
 =?us-ascii?Q?B6GwSLLqjgavt07aqJeH60GWS7nrWPQCvtfS3e4dMz1Wf/WlcroIjv9JmkHA?=
 =?us-ascii?Q?iekD3GuRw0oEJI6/g1juCKGvgY3glGc5A7jhOS/kkLUhyBqCK/xDGmAOd4cW?=
 =?us-ascii?Q?XObz8XZ5EZ0BnH20MrqYk9g2YK7s94+o+lzvoeFbR28rWB1KFr2WedjUZzRb?=
 =?us-ascii?Q?pEp01h9Mg8b1KY4AoE5BuOGzXPtDBYm8OBB6a0n8zOxWdMykw8cr3BonrUXH?=
 =?us-ascii?Q?GbmdAdomdQW9l9oFZrMvhTGXDDtxFnhNe5LIRr7upzHzxjXGlPXVUM+EsMAZ?=
 =?us-ascii?Q?0SLscLeJUvxBYMQ2trTRrr/R?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5433.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb483d66-456b-4b17-58ee-08d97dd3c611
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 14:17:56.2241
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /jhs0TYsyM5NkC7KMYgtL6/DW1a+AeCXReyhMIA+w2R+5cFXm7HY7tr90Z8xTU32k/46y1ppsD1JtJDKRX01Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2145
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, September 22, 2021 8:59 PM
>=20
> On Wed, Sep 22, 2021 at 03:56:18AM +0000, Tian, Kevin wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > Sent: Wednesday, September 22, 2021 2:04 AM
> > >
> > > On Sun, Sep 19, 2021 at 02:38:43PM +0800, Liu Yi L wrote:
> > > > This patch adds interface for userspace to attach device to specifi=
ed
> > > > IOASID.
> > > >
> > > > Note:
> > > > One device can only be attached to one IOASID in this version. This=
 is
> > > > on par with what vfio provides today. In the future this restrictio=
n can
> > > > be relaxed when multiple I/O address spaces are supported per devic=
e
> > >
> > > ?? In VFIO the container is the IOS and the container can be shared
> > > with multiple devices. This needs to start at about the same
> > > functionality.
> >
> > a device can be only attached to one container. One container can be
> > shared by multiple devices.
> >
> > a device can be only attached to one IOASID. One IOASID can be shared
> > by multiple devices.
> >
> > it does start at the same functionality.
> >
> > >
> > > > +	} else if (cmd =3D=3D VFIO_DEVICE_ATTACH_IOASID) {
> > >
> > > This should be in the core code, right? There is nothing PCI specific
> > > here.
> > >
> >
> > but if you insist on a pci-wrapper attach function, we still need somet=
hing
> > here (e.g. with .attach_ioasid() callback)?
>=20
> I would like to stop adding ioctls to this switch, the core code
> should decode the ioctl and call an per-ioctl op like every other
> subsystem does..
>=20
> If you do that then you could have an op
>=20
>  .attach_ioasid =3D vfio_full_device_attach,
>=20
> And that is it for driver changes.
>=20
> Every driver that use type1 today should be updated to have the above
> line and will work with iommufd. mdevs will not be updated and won't
> work.
>=20

will do.=20