Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1302-gc62ab821ef-fm-20210921.001-gc62ab821
Mime-Version: 1.0
Message-Id: <d8024591-0142-442e-98e9-0c92a7679768@www.fastmail.com>
In-Reply-To: <YUniTtc/DwGYPD+c@kuha.fi.intel.com>
References: <20210918120934.28252-1-sven@svenpeter.dev>
 <20210918120934.28252-9-sven@svenpeter.dev>
 <YUniTtc/DwGYPD+c@kuha.fi.intel.com>
Date:   Wed, 22 Sep 2021 17:00:31 +0200
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Heikki Krogerus" <heikki.krogerus@linux.intel.com>
Cc:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>,
        "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Hector Martin" <marcan@marcan.st>,
        "Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
        "Stan Skowronek" <stan@corellium.com>,
        "Mark Kettenis" <mark.kettenis@xs4all.nl>,
        "Alexander Graf" <graf@amazon.com>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>
Subject: =?UTF-8?Q?Re:_[RFT_PATCH_8/9]_usb:_typec:_tipd:_Switch_power_state_to_S0?=
 =?UTF-8?Q?_for_Apple_variant?=
Content-Type: text/plain
Precedence: bulk


On Tue, Sep 21, 2021, at 15:46, Heikki Krogerus wrote:
> On Sat, Sep 18, 2021 at 02:09:33PM +0200, Sven Peter wrote:
>> The Apple CD321x comes up in a low-power state after boot. Usually, the
>> bootloader will already power it up to S0 but let's do it here as well
>> in case that didn't happen.
>> 
>> Suggested-by: Stan Skowronek <stan@corellium.com>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>>  drivers/usb/typec/tipd/core.c     | 44 +++++++++++++++++++++++++++++++
>>  drivers/usb/typec/tipd/tps6598x.h |  6 +++++
>>  2 files changed, 50 insertions(+)
>> 
>> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
>> index e96b17fe6af6..26807c050662 100644
>> --- a/drivers/usb/typec/tipd/core.c
>> +++ b/drivers/usb/typec/tipd/core.c
>> @@ -30,6 +30,7 @@
>>  #define TPS_REG_INT_MASK2		0x17
>>  #define TPS_REG_INT_CLEAR1		0x18
>>  #define TPS_REG_INT_CLEAR2		0x19
>> +#define TPS_REG_SYSTEM_POWER_STATE	0x20
>>  #define TPS_REG_STATUS			0x1a
>>  #define TPS_REG_SYSTEM_CONF		0x28
>>  #define TPS_REG_CTRL_CONF		0x29
>> @@ -84,6 +85,8 @@ struct tps6598x_hw {
>>  	unsigned int irq_data_status_update;
>>  	unsigned int irq_plug_event;
>>  	void (*irq_trace)(u64 event1, u64 event2);
>> +
>> +	bool supports_spss;
>>  };
[...]
>>  static int devm_tps6598_psy_register(struct tps6598x *tps)
>>  {
>>  	struct power_supply_config psy_cfg = {};
>> @@ -648,6 +685,11 @@ static int tps6598x_probe(struct i2c_client *client)
>>  	if (ret)
>>  		return ret;
>>  
>> +	/* Switch Apple chips to the correct system power state */
>> +	ret = cd321x_switch_power_state(tps, TPS_SYSTEM_POWER_STATE_S0);
>> +	if (ret)
>> +		return ret;
>
> If you call this from the same quirk where you set the mask for your
> board, you don't need that supports_spss flag at all, right?

Yup, that one will also disappear then.

Thanks,

Sven