Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210908172420.879240-1-namhyung@kernel.org> <YTvRNj09IwVfyZr1@krava>
 <CAM9d7cjjjV0uNCNLohFMFizRxvu2vwJBgE-Cge1Y6F3jDuPLNg@mail.gmail.com>
In-Reply-To: <CAM9d7cjjjV0uNCNLohFMFizRxvu2vwJBgE-Cge1Y6F3jDuPLNg@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 22 Sep 2021 12:34:20 -0700
Message-ID: <CAM9d7cg_=EFQNVvEWsmNiQ_jjjiRSXjc=uH=4uQzuVbVNzuLDw@mail.gmail.com>
Subject: Re: [PATCH v2] perf/core: Add a new read format to get a number of
 lost samples
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Peter,

On Fri, Sep 10, 2021 at 3:40 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Fri, Sep 10, 2021 at 2:42 PM Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Wed, Sep 08, 2021 at 10:24:20AM -0700, Namhyung Kim wrote:
> > > Sometimes we want to know an accurate number of samples even if it's
> > > lost.  Currenlty PERF_RECORD_LOST is generated for a ring-buffer which
> > > might be shared with other events.  So it's hard to know per-event
> > > lost count.
> > >
> > > Add event->lost_samples field and PERF_FORMAT_LOST to retrieve it from
> > > userspace.
> >
> > hi,
> > looks good.. will there be some tools/perf change using this?
>
> Sure, I'll work on the userspace part after this is merged.
> I'm thinking about adding LOST_SAMPLES records at the end
> of the data section as if they came from the kernel.

Can I get your feedback?

Thanks,
Namhyung